uPortal IRC Logs-2011-10-07

Owned by Apereo Infrastructure
Last updated: Oct 07, 2011Version comment
4 min read

[12:24:57 CDT(-0500)] <jdlich> can anyone explain this ticket https://issues.jasig.org/browse/UP-3145

[12:25:22 CDT(-0500)] <jdlich> is this something that was forgot about? or is it more complicated than that to change the skin name?

[12:25:26 CDT(-0500)] <EricDalquist> didn't you report it?

[12:25:32 CDT(-0500)] <jdlich> yeah

[12:25:45 CDT(-0500)] <jdlich> I know the name and thumb in the gallery can be changed quite easily

[12:25:51 CDT(-0500)] <EricDalquist> so for 4.0 the gallery image needs to be changed

[12:26:02 CDT(-0500)] <jdlich> but what about the skin directory?

[12:26:06 CDT(-0500)] <EricDalquist> I'm not sure

[12:26:09 CDT(-0500)] <jdlich> how much plumbing is tied to "uportal3"

[12:26:16 CDT(-0500)] <EricDalquist> not much I bet

[12:26:16 CDT(-0500)] <EricDalquist> but

[12:26:28 CDT(-0500)] <EricDalquist> do you think that could cause problems for someone that is already working on skinning up4?

[12:26:35 CDT(-0500)] <EricDalquist> I'm thinking it shouldn't

[12:26:58 CDT(-0500)] <EricDalquist> I believe the only places it would be listed are in the skins.xml and one or two files in src/main/data that list it as the default skin

[12:27:56 CDT(-0500)] <jdlich> is the source fully in git yet?

[12:28:06 CDT(-0500)] <EricDalquist> nope

[12:28:17 CDT(-0500)] <EricDalquist> still need to finish poking people for git usernames

[12:28:22 CDT(-0500)] <EricDalquist> and then put out a move plan

[12:28:26 CDT(-0500)] <EricDalquist> probably the end of next week

[12:42:39 CDT(-0500)] <jdlich> looks like it appears in uportal-war/pom.xml and it's even hardcoded in java…

[12:43:41 CDT(-0500)] <EricDalquist> right so in the pom the aggregator plugin would need updating

[12:43:42 CDT(-0500)] <jdlich> still probably simple to swap out everywhere, but there might be a better solution in some cases

[12:43:48 CDT(-0500)] <EricDalquist> where are you seeing it in java code?

[12:44:06 CDT(-0500)] <jdlich> uportal-war/src/test/java/org/jasig/portal/rendering/RenderingPipelineIntegrationTest.java

[12:45:06 CDT(-0500)] <EricDalquist> ah ok so that's easier to fix

[12:45:14 CDT(-0500)] <jdlich> shouldn't the default skin be in the portal preferences?

[12:45:30 CDT(-0500)] <jdlich> and then referenced in all of these other places?

[12:45:46 CDT(-0500)] <EricDalquist> yes, though I'm not sure we can actually make that happen right now

[12:45:59 CDT(-0500)] <EricDalquist> since at runtime there is only one location

[12:46:01 CDT(-0500)] <EricDalquist> the DB

[12:46:27 CDT(-0500)] <EricDalquist> the problem is the build needs to know about all the skins (perhaps we could make the aggregator plugin smarter to do directory scanning or something)

[12:46:46 CDT(-0500)] <EricDalquist> and then unit tests ... well they just end up being maintained by hand

[12:49:11 CDT(-0500)] <jdlich> well, I guess for now uportal3 lives on

[12:49:28 CDT(-0500)] <EricDalquist> I think we could probably change that skin name for 4.0.2

[12:49:46 CDT(-0500)] <jdlich> and update the thumb too at least

[12:49:56 CDT(-0500)] <EricDalquist> thumb for sure

[12:50:10 CDT(-0500)] <EricDalquist> but even the skin, if people are following best pracitces no one should be modifying the uportal4 skin

[12:50:16 CDT(-0500)] <EricDalquist> they should be copying it and customizing that

[12:54:10 CDT(-0500)] <jdlich> best practices would be to reference the default skin from a preference file (tongue)

[12:54:35 CDT(-0500)] <jdlich> I uploaded a new thumb https://issues.jasig.org/browse/UP-3145

[12:55:36 CDT(-0500)] <EricDalquist> like I said, it is essentially setup that way: https://source.jasig.org/uPortal/trunk/uportal-war/src/main/data/required_entities/stylesheet-descriptor/DLMXHTML.stylesheet-descriptor.xml

[12:55:47 CDT(-0500)] <EricDalquist> that should be the one place runtime code ever finds the skin name from

[12:56:06 CDT(-0500)] <EricDalquist> the unit test issue is easy, that just gets updated manually when the skin name changes

[12:56:29 CDT(-0500)] <EricDalquist> and the aggregator ... well someone needs time to update it so you don't have to list every skin explicitly

[12:57:11 CDT(-0500)] <jdlich> just realized something… if you do a new skin and don't add it to the list it doesn't get aggregated does it?

[12:57:27 CDT(-0500)] <EricDalquist> nope (sad)

[12:57:33 CDT(-0500)] <EricDalquist> and everything "works"

[12:57:37 CDT(-0500)] <EricDalquist> in that your skin displays

[12:57:49 CDT(-0500)] <EricDalquist> but your JS/CSS downloads are going to be really gross

[12:58:27 CDT(-0500)] <EricDalquist> its the resource-server-plugin module of https://source.jasig.org/resource-server/trunk/ that needs the work

[12:58:37 CDT(-0500)] <EricDalquist> something where you can specify an ant pattern or something for the skin.xml files

[12:59:15 CDT(-0500)] <EricDalquist> so you could configure <skinPattern>/src/main/webapp/media/skins/**/skin.xml</skinPattern>

[12:59:38 CDT(-0500)] <EricDalquist> and just have the plugin magically work on any skin.xml file it found under the skins directory

[12:59:56 CDT(-0500)] <EricDalquist> that would make life a lot easier for deployers

[13:00:38 CDT(-0500)] <jdlich> nice, is that all there is to it?

[13:01:02 CDT(-0500)] <EricDalquist> yeah

[13:01:15 CDT(-0500)] <EricDalquist> that would be a wonderful feature if you're up for it

[13:02:05 CDT(-0500)] <EricDalquist> also seems like you've contributed enough to get you setup with actual commit access

[13:02:43 CDT(-0500)] <jdlich> Git is right around the corner though right so no big deal?

[13:02:52 CDT(-0500)] <EricDalquist> right

[13:03:00 CDT(-0500)] <EricDalquist> but commit access would still help with git

[13:03:05 CDT(-0500)] <EricDalquist> you could then commit right to our main repo

[13:03:10 CDT(-0500)] <EricDalquist> instead of having to do pull reqs

[13:05:01 CDT(-0500)] <EricDalquist> and plus stuff like the resource server won't be moving to git yet

[13:05:11 CDT(-0500)] <EricDalquist> so you'd still need svn commit access to contribute there (smile)

[13:07:39 CDT(-0500)] <jdlich> not sure how much I can really contribute to the resource server to tell you the truth

[13:08:07 CDT(-0500)] <EricDalquist> time or java experience?

[13:08:12 CDT(-0500)] <jdlich> but committing directly on git would be sweet

[13:08:55 CDT(-0500)] <jdlich> java… I am primarily a designer

[13:09:28 CDT(-0500)] <EricDalquist> ah, no problem (smile)

[13:15:18 CDT(-0500)] <jdlich> it doesn't scare me or anything, there's just not enough time in the day!

[13:16:36 CDT(-0500)] <EricDalquist> I know how that goes

[13:16:59 CDT(-0500)] <EricDalquist> and honestly I'd rather have you focus on your designer side since we seem to always been in short supply of those skills