uPortal IRC Logs-2012-08-03

Owned by Apereo Infrastructure
Last updated: Aug 03, 2012
1 min read

[14:25:54 CDT(-0500)] <dmccallum54> athena i'm looking at https://github.com/Jasig/uPortal/blob/master/uportal-war/src/main/java/org/jasig/portal/portlets/lookup/PersonLookupHelperImpl.java

[14:26:09 CDT(-0500)] <dmccallum54> searchForPeople() has this near the bottom

[14:26:18 CDT(-0500)] <dmccallum54> if (list.size() > 10) {

[14:26:18 CDT(-0500)] <dmccallum54>             list = list.subList(0, 9);

[14:26:18 CDT(-0500)] <dmccallum54>         }

[14:26:51 CDT(-0500)] <dmccallum54> this has, um, catastrophic effects on SSP's attempts to look up uP users from its main portlet

[14:27:04 CDT(-0500)] <dmccallum54> git blame instructed me to check with you

[14:27:40 CDT(-0500)] <dmccallum54> if i just remove that restriction, what are the actual changes of either 1) OOM and/or 2) breaking a UI somewhere

[14:27:50 CDT(-0500)] <athena> yes, you can totally just remove that if you like

[14:27:54 CDT(-0500)] <dmccallum54> thx. done

[14:27:57 CDT(-0500)] <athena> basically that's in there for the directory portlet

[14:28:25 CDT(-0500)] <athena> so that you can't enter a search like "a" and get back 5000 results from the university directory

[14:28:38 CDT(-0500)] <athena> to prevent people from just scraping it, as well as for performance reasons

[14:28:52 CDT(-0500)] <dmccallum54> sure sure

[14:28:58 CDT(-0500)] <athena> actually a lot of LDAP servers have a limit for results anyway, so a search like that really would probably cause an error

[14:29:00 CDT(-0500)] <athena> anyway.

[14:29:05 CDT(-0500)] <athena> that really needs to become configurable

[14:29:21 CDT(-0500)] <dmccallum54> k

[14:29:30 CDT(-0500)] <athena> such that schools can turn that on and off to meet their needs

[14:29:34 CDT(-0500)] <athena> feel free to submit a ticket for that