jasig-ssp IRC Logs-2013-06-05

Owned by Apereo Infrastructure
Last updated: Jun 05, 2013
10 min read

[09:52:10 CDT(-0500)] <TonyUnicon> Hey Jason

[09:52:23 CDT(-0500)] <TonyUnicon> can you confirm a bug I found?

[09:52:46 CDT(-0500)] <JasonElwood1> sure. what's up

[09:53:02 CDT(-0500)] <JasonElwood1> is anybody else having problems with the chat room? I'm getting logged in and out a bunch

[09:53:13 CDT(-0500)] <TonyUnicon> how old is that build?

[09:53:20 CDT(-0500)] <TonyUnicon> no my connection has been stable

[09:53:23 CDT(-0500)] <TonyUnicon> on CI linux

[09:53:39 CDT(-0500)] <JasonElwood1> last night at midnight

[09:54:34 CDT(-0500)] <TonyUnicon> ok, nevermind, let me confirm some stuff on my end, I'm unable to drag courses onto maps

[09:55:14 CDT(-0500)] <JasonElwood1> I'm not having any problems in Fireforx on Linux CI

[09:55:44 CDT(-0500)] <TonyUnicon> yeah CI linux is fine, and it should have Jim's changes from last night so I may have broken it

[09:55:49 CDT(-0500)] <TonyUnicon> so don't do a build yet(smile)

[09:55:53 CDT(-0500)] <JasonElwood1> but I've been testing reports this morning

[09:55:55 CDT(-0500)] <JasonElwood1> ok

[10:04:51 CDT(-0500)] <TonyUnicon> nope this bug was checked in

[10:05:14 CDT(-0500)] <TonyUnicon> but I guess CI Linux did not pick it up

[10:05:35 CDT(-0500)] <TonyUnicon> Jason, on the save template/plan is name the only field we want to enforce as being required?

[10:05:36 CDT(-0500)] <JasonElwood1> the build ran successfully last night

[10:06:12 CDT(-0500)] <JasonElwood1> but I have seen some strange things with some fixes not appearing

[10:06:29 CDT(-0500)] <TonyUnicon> let me see if its a browser cache thing

[10:06:34 CDT(-0500)] <TonyUnicon> which happens when we run minified

[10:07:25 CDT(-0500)] <TonyUnicon> hmm nope

[10:07:47 CDT(-0500)] <TonyUnicon> yeah there is no way this piece of code would not throw an error

[10:07:59 CDT(-0500)] <TonyUnicon> and it was checked in yesterday aftenroon

[10:08:32 CDT(-0500)] <TonyUnicon> when copy on drop was done for plan courses

[10:08:37 CDT(-0500)] <TonyUnicon> or sorry delete on drop

[10:09:04 CDT(-0500)] <JasonElwood1> at 4a ET, Fetching upstream changes from origin

[10:09:04 CDT(-0500)] <JasonElwood1> Commencing build of Revision b83f1563d0eb7e56cda43b20f3719dbffea69a28 (origin/master)

[10:09:04 CDT(-0500)] <JasonElwood1> Checking out Revision b83f1563d0eb7e56cda43b20f3719dbffea69a28 (origin/master)

[10:10:45 CDT(-0500)] <TonyUnicon> whatever he did for /src/main/webapp/app/controller/tool/map/SavePlanViewController.js

[10:10:51 CDT(-0500)] <TonyUnicon> sorry

[10:11:00 CDT(-0500)] <TonyUnicon> what is the timestamp for that file in the exploded war?

[10:12:05 CDT(-0500)] <TonyUnicon> and in the same dir SemesterGridViewController.js

[10:12:39 CDT(-0500)] <JasonElwood1> all files in the dir are from this morning

[10:12:56 CDT(-0500)] <TonyUnicon> weird

[10:14:11 CDT(-0500)] <JasonElwood1> in source SemesterGridViewController.js is 6/3

[10:14:22 CDT(-0500)] <JasonElwood1> SavePlanViewController.js is 5/31

[10:14:37 CDT(-0500)] <TonyUnicon> yeah those have been updated

[10:14:50 CDT(-0500)] <TonyUnicon> let me work it out with Jim

[10:35:30 CDT(-0500)] <JasonElwood1> JS- for 1248 can you put the results in a table so at least the courses are separated?

[10:36:29 CDT(-0500)] <JasonElwood1> And the student ID label doesn't really fit as a page label. That would be more appropriate as Course

[10:59:58 CDT(-0500)] <JasonElwood1> Paul- If you are testing locally, I'll kick of the LInux CI build to try and get the latest changes

[11:01:39 CDT(-0500)] <pspaude> Sure, yeah it would be a good time to do that.

[11:11:58 CDT(-0500)] <TonyUnicon> hey Paul

[11:12:11 CDT(-0500)] <TonyUnicon> I was able to reproduce your seven course issue

[11:12:19 CDT(-0500)] <TonyUnicon> can you write it up and assign to me>

[11:13:13 CDT(-0500)] <pspaude> Sure, no problem. I'm in the process now!

[11:13:26 CDT(-0500)] <JasonElwood1> Linux CI is back up

[11:18:09 CDT(-0500)] <pspaude> Cool, and Tony the issue is up! SSP-1314.

[11:21:07 CDT(-0500)] <TonyUnicon> thanks

[11:22:04 CDT(-0500)] <pspaude> Hey, you are fast (smile) Just tested again and Linux CI and I don't get it?

[11:22:43 CDT(-0500)] <pspaude> Does anyone know the max number of courses allowed in a term?

[11:22:55 CDT(-0500)] <JasonElwood1> there shouldn't be a limit

[11:24:17 CDT(-0500)] <pspaude> Okay, great. That's what I thought.

[11:24:29 CDT(-0500)] <TonyUnicon> there is a bug for sure, hasn't been fixed, working on it though

[11:25:19 CDT(-0500)] <pspaude> Alright, guess it was a fluke, got Linux CI MAP to hang.

[11:25:22 CDT(-0500)] <pspaude> but now you have to add over 8. But, its flakey sometimes its 7.

[11:26:19 CDT(-0500)] <TonyUnicon> no worries, its been addressed

[11:26:29 CDT(-0500)] <TonyUnicon> being&

[11:26:29 CDT(-0500)] <TonyUnicon> being*

[11:27:09 CDT(-0500)] <pspaude> Cool, was hoping you didn't need the call stack since I'm updating/re-building my local.

[11:29:58 CDT(-0500)] <TonyUnicon> no call stack for this one, its a straight javascript bug

[11:31:41 CDT(-0500)] <pspaude> Ahh, okay. My console was logging errors. So I thought they were related.

[11:31:59 CDT(-0500)] <TonyUnicon> whats the errpr?

[11:32:03 CDT(-0500)] <pspaude> BTW, does anyone get errors logged to the console when they use the filters per terms?

[11:32:08 CDT(-0500)] <TonyUnicon> your browser cansole or the server log?

[11:32:16 CDT(-0500)] <TonyUnicon> console*

[11:32:18 CDT(-0500)] <pspaude> The browser console.

[11:32:39 CDT(-0500)] <pspaude> The filters always have an uncaught type error for 'apply' of undefined.

[11:32:53 CDT(-0500)] <TonyUnicon> you get that sometimes when you click too fast through the app

[11:33:00 CDT(-0500)] <TonyUnicon> usually clicking away from main tool

[11:33:43 CDT(-0500)] <pspaude> The error for the 7+ course in a term on the browser console is: uncaught type error cannot call method findParentByType of undefined.

[11:34:03 CDT(-0500)] <TonyUnicon> right

[11:34:12 CDT(-0500)] <TonyUnicon> we got it(smile) no worries

[11:34:41 CDT(-0500)] <pspaude> Ah, yes I do click quickly through the app. Computers spend so much time waiting for user input... say the experts.

[11:35:51 CDT(-0500)] <pspaude> cool

[11:57:49 CDT(-0500)] <TonyUnicon> I had a nightmare once where I woke up and everything was written in javascript

[11:58:51 CDT(-0500)] <JasonElwood1> that's as bad as Dan dreaming about timestamps

[11:59:59 CDT(-0500)] <TonyUnicon> heh

[12:13:19 CDT(-0500)] <JasonElwood1> Tony- I'm looking at 1290. it mentions a new property- cacheLifeSpanInMillis=86400000. is that a new property in ssp-config.properties? I don't see the entry in https://github.com/Jasig/SSP/blob/master/src/main/config/external/ssp-config.properties

[12:24:18 CDT(-0500)] <JasonElwood1> The text with the Template Notes icon just says Template. Is that intention? Or should it say Template Notes>

[12:24:20 CDT(-0500)] <JasonElwood1> ?

[12:27:24 CDT(-0500)] <js70> for the save dialog?

[12:29:23 CDT(-0500)] <js70> never mind

[12:29:29 CDT(-0500)] <js70> I see what you are saying

[12:31:32 CDT(-0500)] <js70> supposed to be Template Notes

[12:35:22 CDT(-0500)] <JasonElwood1> that would be consistent, but I wasn't sure if it was abbreviated for space. Template Notes would be preferred

[12:38:23 CDT(-0500)] <js70> lots of space

[12:38:34 CDT(-0500)] <JasonElwood1> SSP-1316

[12:39:45 CDT(-0500)] <TonyUnicon> its in the default config

[12:40:09 CDT(-0500)] <TonyUnicon> ssp-config.properties I thought is created from the default

[12:42:46 CDT(-0500)] <TonyUnicon> should I add it to ssp-config.properties?

[12:43:16 CDT(-0500)] <JasonElwood1> please. that's what people use to start their configuration

[12:43:50 CDT(-0500)] <TonyUnicon> ok

[12:44:48 CDT(-0500)] <TonyUnicon> in

[14:07:09 CDT(-0500)] <pspaude> I updated the code on my local and now on SSP login I get a JScript error: unexpected token ( in SemesterGridViewController.js line 70.

[14:10:35 CDT(-0500)] <pspaude> I looked at it but it looked good. Going to try JSlint but will take me a bit to get it spun up. Just fyi before you rebuild Linux CI.

[14:43:15 CDT(-0500)] <js70> tony's on it paul

[14:43:47 CDT(-0500)] <TonyUnicon> update

[14:54:58 CDT(-0500)] <js70> SSP-1246 jason, can you take a look at my comments and give me some guidance as to how you want the report to work?

[14:55:24 CDT(-0500)] <JasonElwood1> yeah. just finished a call but saw the email come in

[14:55:46 CDT(-0500)] <js70> k, you must get a lot of email. I can barely keep up with my tickets.

[14:55:56 CDT(-0500)] <JasonElwood1> it is pretty bad

[14:55:59 CDT(-0500)] <js70> Jira is nothing if not detailed

[14:58:36 CDT(-0500)] <JasonElwood1> JS- how about this? if you don't select a term, just show the aggregate (course & occurrences), if you select a term, group by term (courses & occurrences)

[14:59:10 CDT(-0500)] <JasonElwood1> that may be too complex. probably easier to just group by term always

[14:59:27 CDT(-0500)] <js70> yeah, that will work. the first way is easier actually.

[14:59:27 CDT(-0500)] <JasonElwood1> that would follow the pattern of other reports

[14:59:49 CDT(-0500)] <js70> because by default selecting a term will group it by term.

[15:00:00 CDT(-0500)] <JasonElwood1> so always group by term?

[15:00:19 CDT(-0500)] <js70> Nope

[15:00:24 CDT(-0500)] <js70> if the don't select a term. we aggregate

[15:00:32 CDT(-0500)] <JasonElwood1> no term, aggregate yes term, group

[15:00:38 CDT(-0500)] <js70> right

[15:01:02 CDT(-0500)] <JasonElwood1> that may not work though. because I would never know the term in aggregate

[15:01:07 CDT(-0500)] <js70> the aggregate report is going to be intense. since it will be for all terms.

[15:01:41 CDT(-0500)] <js70> does Sinclair allow an aggregate report right now?

[15:01:53 CDT(-0500)] <JasonElwood1> I just checked. it is by term

[15:01:58 CDT(-0500)] <JasonElwood1> the screen shot is in the issue

[15:02:20 CDT(-0500)] <js70> right, the force a term.

[15:02:26 CDT(-0500)] <JasonElwood1> we would need to group by term because you can't select multiple terms.

[15:02:26 CDT(-0500)] <js70> they

[15:02:50 CDT(-0500)] <js70> of course. its going to be grouped by the term you select. we just won't allow them not to select a course.

[15:03:03 CDT(-0500)] <js70> a term

[15:03:37 CDT(-0500)] <JasonElwood1> I don't know that they force a term. there could be a blank entry in the drop down

[15:04:16 CDT(-0500)] <js70> so, thats what I am asking. does sinclair allow an all terms. My guess is no as that adds significant complexity.

[15:04:32 CDT(-0500)] <js70> if they did that they would allow you to select multiple terms individually.

[15:04:39 CDT(-0500)] <JasonElwood1> so the best option now is to force a term selection

[15:04:42 CDT(-0500)] <js70> which the ui suggests they don't

[15:04:47 CDT(-0500)] <js70> yep!

[15:05:02 CDT(-0500)] <JasonElwood1> force term, group by course, provide a count

[15:05:23 CDT(-0500)] <js70> I'll make the change and check-in

[15:05:28 CDT(-0500)] <JasonElwood1> cool

[15:05:46 CDT(-0500)] <JasonElwood1> I'll change the specs and issue

[15:06:13 CDT(-0500)] <js70> thks

[15:06:40 CDT(-0500)] <js70> you're a good listener, Jason. Management material for sure.:^)

[15:30:35 CDT(-0500)] <JasonElwood1> Paul- have you experienced the red delete icon to remove a course not displaying in Chrome?

[15:32:47 CDT(-0500)] <JasonElwood1> Questions to refresh my memory- 1) Did we agree to never indicate that a course has notes? And you always have to open a planned course to see if notes have been written

[15:34:55 CDT(-0500)] <JasonElwood1> 2) We didn't put anything in to indicate that a term is important

[15:36:30 CDT(-0500)] <JasonElwood1> by that I mean an indicator on the plan

[15:36:47 CDT(-0500)] <pspaude> Not yet. I've always seen the icon. The only thing giving me an issue in chrom is save template or save plan where the private option or other checkboxes may be not inline etc. This is similar to the IE issue, so I'm waiting to see a fix on that otherwise I'll create a new one.

[15:36:51 CDT(-0500)] <TonyUnicon> we agreed that the indicator would be gone

[15:37:15 CDT(-0500)] <TonyUnicon> the course note indicator

[15:38:06 CDT(-0500)] <TonyUnicon> because we wanted more room for the formatted course name

[15:41:34 CDT(-0500)] <JasonElwood1> this can be for b3, but I'm getting some feedback on indicators. course notes and dev ed courses then the terms marked as important

[15:42:03 CDT(-0500)] <TonyUnicon> since terms aren't entities

[15:42:07 CDT(-0500)] <TonyUnicon> that would be difficult

[15:42:40 CDT(-0500)] <JasonElwood1> we do it for term notes

[15:42:50 CDT(-0500)] <JasonElwood1> the paper icon

[15:43:04 CDT(-0500)] <TonyUnicon> right...

[15:43:14 CDT(-0500)] <TonyUnicon> not important

[15:43:17 CDT(-0500)] <TonyUnicon> let me focus on bugs

[15:43:23 CDT(-0500)] <TonyUnicon> worry about b3

[15:43:27 CDT(-0500)] <JasonElwood1> yeah

[15:43:31 CDT(-0500)] <TonyUnicon> later

[15:51:42 CDT(-0500)] <JasonElwood1> Paul- let me know a good time to build new on Linux CI

[15:57:27 CDT(-0500)] <pspaude> Right now is a great time. Trying to duplicate something on my local.

[15:57:58 CDT(-0500)] <JasonElwood1> thanks. building

[16:21:11 CDT(-0500)] <js70> jason: https://issues.jasig.org/browse/SSP-1321 student notes are ok to print and email?

[16:21:35 CDT(-0500)] <JasonElwood1> student notes are ok

[16:25:25 CDT(-0500)] <JasonElwood1> JS- 1248 looks good. thanks

[16:30:48 CDT(-0500)] <JasonElwood1> Just wanted to say you guys are doing a great job knocking down these bugs.

[16:45:46 CDT(-0500)] <JasonElwood1> JS- I'm testing 957 which was re-opened because electives that are marked as inactive in SSP admin are showing in the list. I'm still seeing the problem but the issue is marked resolved. Are you not seeing the issue locally?

[16:48:47 CDT(-0500)] <js70> there is a note.

[16:48:55 CDT(-0500)] <js70> you have to log out

[16:49:12 CDT(-0500)] <js70> not log out but reset.

[16:49:27 CDT(-0500)] <js70> to see the changes. I did add code that should work.

[16:50:11 CDT(-0500)] <js70> does work

[16:50:18 CDT(-0500)] <JasonElwood1> this is for 957?

[16:51:22 CDT(-0500)] <js70> the notes are probably in the commit.

[16:51:25 CDT(-0500)] <js70> sorry about that.

[16:52:23 CDT(-0500)] <js70> or in my dreams. I know I wrote somebody.

[16:52:33 CDT(-0500)] <js70> :-$

[16:54:34 CDT(-0500)] <js70> created an ActiveElectiveStore that only pulls back active electives but noticed that you had to reset or logout (I forget which now) to see the changes. There's some caching going on that I did not chase down.

[16:54:41 CDT(-0500)] <JasonElwood1> sorry, I'm going to kick it back. I'm seeing all the inactive elective codes in the list for a planned course

[16:55:27 CDT(-0500)] <TonyUnicon> we cache them because they were another ticket saying we fetch electives 1000 times

[16:55:31 CDT(-0500)] <TonyUnicon> its gotta be one or the other

[16:56:23 CDT(-0500)] <js70> I think the 1000 times has been fixed. Not sure, so maybe we don't need to cache any longer.

[16:56:40 CDT(-0500)] <TonyUnicon> the cache was the fix...

[16:56:47 CDT(-0500)] <js70> ah

[16:57:53 CDT(-0500)] <TonyUnicon> meaning we dont reload electives if they are already populated

[16:58:05 CDT(-0500)] <TonyUnicon> if whatever it is that makes the electives inactive updates the store in memory

[16:58:56 CDT(-0500)] <JasonElwood1> so do you want me to kick it back to so that the update triggers a flush

[17:00:25 CDT(-0500)] <js70> up to you.

[17:01:00 CDT(-0500)] <js70> you should definitely confirm that it flushes on logout. and inactive electives are not shown.

[17:02:17 CDT(-0500)] <JasonElwood1> logout made no difference

[17:02:22 CDT(-0500)] <JasonElwood1> still seeing the full list

[17:02:35 CDT(-0500)] <js70> k. kick it back. I'll take a look.

[17:03:56 CDT(-0500)] <JasonElwood1> you got it. thanks

[17:05:44 CDT(-0500)] <js70> So do all of the inactive electives show or are there some that are hidden. Not including the ones you are currently editing.

[17:06:04 CDT(-0500)] <JasonElwood1> all are showing

[17:14:10 CDT(-0500)] <JasonElwood1> Paul- I need to push another build to Linux CI

[17:15:20 CDT(-0500)] <pspaude> Ok, go ahead. The builds have been going fast lately (smile)

[17:15:37 CDT(-0500)] <JasonElwood1> building

[17:19:06 CDT(-0500)] <JasonElwood1> finished, tomcat is starting

[17:21:38 CDT(-0500)] <pspaude> Cool

[17:30:27 CDT(-0500)] <JasonElwood1> good catch on 1322 Tony

[17:47:57 CDT(-0500)] <TonyUnicon> sorry had this minimized, Jim actually caught it, I just opened the ticket and fixed it(smile)

[17:48:54 CDT(-0500)] <JasonElwood1> then great catch Jim. superb ticket opening Tony

[17:50:20 CDT(-0500)] <TonyUnicon> i try

[18:00:23 CDT(-0500)] <JasonElwood1> I've been through all the resolved issue with Firefox on PG. That took longer than expected. I'll start on Safari tomorrow and get the Win CI ready for testing. Thanks again for all the efforts.