jasig-ssp IRC Logs-2013-06-04

[10:40:02 CDT(-0500)] <JasonElwood> Paul- for lack of a better way for us to coordinate, here's a proposed process. I added labels to all the resolved issues. There are 8 total to represent each browser and database combination. As a browser-db combo passes QA, go ahead and remove the label. When all labels are gone, we can close the issue. If you have any suggestions or feedback, please let me know.

[10:56:57 CDT(-0500)] <pspaude1> Sounds good Jason.

[11:01:42 CDT(-0500)] <JasonElwood> Paul- If you do get to the point that all the testing labels are gone and you are ready to close and issue, make sure to remove the Current Iteration from the Fix Version. Also, make sure the Affected and Fix versions are correct and have a specific release number assigned. IE: Not 2.0.X, should be 2.0.0-b2

[11:04:49 CDT(-0500)] <pspaude1> Alright, I'll do that. Thanks.

[11:11:23 CDT(-0500)] <JasonElwood> JS- ignore 1308. I assigned it to Greg

[11:14:32 CDT(-0500)] <GregElliott1> will take a look at 1308.

[11:16:08 CDT(-0500)] <js70> kk

[11:17:16 CDT(-0500)] <js70> God, I hate IE

[11:21:24 CDT(-0500)] <pspaude1> Don't we all?

[11:22:55 CDT(-0500)] <js70> Why can't we just recommend Chrome and let the rest of them fend for themselves. This is a serious question. It is so much more performant, clean. Making it work in the other browsers is just going to making kinda not very nice in all.

[11:26:33 CDT(-0500)] <JasonElwood> Unfortunately, IE is widely used in higher ed. Two reasons: 1) 90+ % of the desktops are Windows on Windows networks 2) For security reasons, most locations lock down machines in labs and for staff so that other software can't be installed. Preventative support

[11:27:14 CDT(-0500)] <TonyUnicon1> IE is still by far the most widely used browser in almost any context

[11:27:33 CDT(-0500)] <TonyUnicon1> as much as it pains me to say it, we HAVE to support IE,

[11:28:33 CDT(-0500)] <JasonElwood> so remember everybody, Tony made the decision to support IE.

[11:28:41 CDT(-0500)] <js70> Crappy ui for everyone! :^)

[11:28:48 CDT(-0500)] <TonyUnicon1> hah, im just stating the obvious

[11:29:06 CDT(-0500)] <TonyUnicon1> IE is a pile of poop, unfortunately its the most popular pile of poop on the world

[11:29:14 CDT(-0500)] <TonyUnicon1> in*

[11:29:19 CDT(-0500)] <js70> I blame Paul

[11:29:28 CDT(-0500)] <TonyUnicon1> me too

[11:29:29 CDT(-0500)] <pspaude1> Don't blame the messenger.

[11:29:29 CDT(-0500)] <js70> He wrote the ticket

[11:29:31 CDT(-0500)] <JasonElwood> actually Windows is. IE is probably second

[11:29:38 CDT(-0500)] <GregElliott1> oh, tough guy. Blame the intern, why doncha?

[11:30:12 CDT(-0500)] <js70> Hey, I graduated before the outlawed bullying. Always worked for me…all 120 pounds.

[11:30:26 CDT(-0500)] <pspaude1> Personally, after IE9 I haven't seen this bad of issues in IE dispalying JScript.

[11:30:41 CDT(-0500)] <pspaude1> Usually, its bit different looing between the three.

[11:30:48 CDT(-0500)] <pspaude1> I wonder how much of this is extJS?

[11:31:30 CDT(-0500)] <js70> I am glad we are getting testing on all platforms.

[11:32:45 CDT(-0500)] <js70> just a little frustrating that we are going to end up compromising all platforms. Might help if we had a ux guy.

[11:33:52 CDT(-0500)] <pspaude1> Oh, btw I haven't produced the ticket yet, as I'm looking into solutions, but IE doesn't let you resize SSP popup windows. Their "solution" is an html "resize"... seeing if possible to call with JScript or not.

[11:34:38 CDT(-0500)] <pspaude1> Yeah, I agree its frustrating, a ux guy would be nice!

[11:35:21 CDT(-0500)] <TonyUnicon1> ExtJs is by far the most IE friendly framework i've used

[11:35:35 CDT(-0500)] <TonyUnicon1> you should have seen the MyGPS problems we had with IE

[11:35:39 CDT(-0500)] <TonyUnicon1> that uses Jquery moble

[11:35:53 CDT(-0500)] <TonyUnicon1> or struts, which is generally a crap shoot when you try to render in IE the first time

[11:36:41 CDT(-0500)] <TonyUnicon1> in my experience (which is about 3 years of Extjs) IE issues with Extjs are quicky javascript things that are done in custom code that IE doesn't like

[11:36:55 CDT(-0500)] <TonyUnicon1> quirky*

[11:38:57 CDT(-0500)] <TonyUnicon1> i remember JSF wasn't awesome either

[11:39:08 CDT(-0500)] <TonyUnicon1> in theory HTML5 is suppose to fix all these issues

[11:40:26 CDT(-0500)] <TonyUnicon1> lets just all be glad we aren't testing on IE 6

[11:40:50 CDT(-0500)] <pspaude1> Yes in "theory". My last group project was on Spring/Hibernate - HTML5 with bootstrap and JQuery. We hardly had any issues with IE even on tablets/phones other than a few odd aesthetics that were easily fixed. Don't know how much bootstrap played into that though...

[11:41:22 CDT(-0500)] <pspaude1> Yes definately!

[11:44:43 CDT(-0500)] <TonyUnicon1> if you really want to have fun with browser incompatibility, my last project was pretty much turning an old struts app into something that was that section 508 compliant (handicapped accessible) and the support for that varies WILDLY between browsers

[11:45:05 CDT(-0500)] <pspaude1> Oh, wow... I feel bad for you.

[11:45:28 CDT(-0500)] <TonyUnicon1> yeah it was probably one of the worst things i've ever had to do

[11:45:34 CDT(-0500)] <TonyUnicon1> learned a lot though!

[11:45:56 CDT(-0500)] <pspaude1> I bet, the experience would be great.

[11:47:40 CDT(-0500)] <pspaude1> There is alot of discussion on (508) and then readjusting mindsets for touch (no hover menus) etc. Alot to think about when designing.

[11:47:53 CDT(-0500)] <TonyUnicon1> yup

[11:48:25 CDT(-0500)] <TonyUnicon1> you sometimes hardly realize the implications of certain UI designs on people who have low-functioning or no motor skills

[11:48:55 CDT(-0500)] <TonyUnicon1> for example drag and drop is generally a no-no

[11:49:11 CDT(-0500)] <TonyUnicon1> making actions 'hot keyable'

[11:49:13 CDT(-0500)] <TonyUnicon1> ect..

[11:52:28 CDT(-0500)] <pspaude1> Yep

[12:31:38 CDT(-0500)] <pspaude1> Ok, no more hating the messenger. The messenger fixed an IE issue. The popup windows for MAP weren't resizable by the user. By changing line 590 inside the third quotes of window.open and adding resizble=1. The windows resize. This is in SemesterPanelContainerViewController.js.

[12:32:30 CDT(-0500)] <JasonElwood> that's great

[12:32:53 CDT(-0500)] <pspaude1> If one of you wants to commit it, Greg? With the other IE fixes that would be fine. Otherwise I can let me know if you want ti assigned to a Jira issue (I guess I could create one).

[12:33:18 CDT(-0500)] <pspaude1> Otherwise * You * can let me know.

[12:36:00 CDT(-0500)] <pspaude1> Oops sorry I should be more descriptive. The popup windows were for print MAP, and View All. They weren't handled by JavaScript and instead were browser pop-ups. IE needs resizable=yes/1 in the window.open() to resize. All other browsers ignore resizable and always let the user resize. FYI

[12:50:23 CDT(-0500)] <js70> Never hate the messenger.

[12:54:33 CDT(-0500)] <TonyUnicon1> great catch, Paul

[16:16:43 CDT(-0500)] <JasonElwood1> Paul- I'm seeing a console error for an API call. Are you seeing something similar? http://ec2-23-20-222-7.compute-1.amazonaws.com/ssp/api/1/reference/elective?_dc=1370380505236&page=1&start=0&limit=20&sort=%5B%7B%22property%22%3A%22sortOrder%22%2C%22direction%22%3A%22ASC%22%7D%5D"

[16:18:27 CDT(-0500)]

[16:18:52 CDT(-0500)] <TonyUnicon1> where do you see it?

[16:18:57 CDT(-0500)] <pspaude> Let me check. What were you doing? I've seen that before, but on my local machine.

[16:19:58 CDT(-0500)] <JasonElwood1> occurs on the initial MAP load on Linux CI

[16:20:12 CDT(-0500)] <JasonElwood1> simply choose student, choose MAP

[16:21:34 CDT(-0500)] <pspaude> I get it in chrome but not IE.

[16:21:38 CDT(-0500)] <TonyUnicon1> which student?

[16:21:45 CDT(-0500)] <JasonElwood1> I was testing 1271. that is about the API call being made 23 times. The error occurs twice.

[16:21:47 CDT(-0500)] <JasonElwood1> John Garcia

[16:22:02 CDT(-0500)] <pspaude> I was on James Montana

[16:23:41 CDT(-0500)] <pspaude> For what it's worth I only get it once per MAP in chrome.

[16:24:11 CDT(-0500)] <TonyUnicon1> that is a strange error, could you open a ticket and include any sort of server log you see?

[16:24:19 CDT(-0500)] <TonyUnicon1> weird that an error like that would be inconsistent

[16:24:26 CDT(-0500)] <TonyUnicon1> sometimes I get it, sometimes I don't

[16:24:53 CDT(-0500)] <JasonElwood1> does it matter that there are electives marked on the plan?

[16:24:57 CDT(-0500)] <pspaude> I can check my local build in a sec, but right now the log isn't good because of the minified

[16:25:19 CDT(-0500)] <JasonElwood1> the log on linux ci will be minified

[16:25:30 CDT(-0500)] <TonyUnicon1> the log would be?

[16:25:44 CDT(-0500)] <JasonElwood1> sorry. already is minified

[16:27:12 CDT(-0500)] <TonyUnicon1> this will be hard to troubleshoot without see the log

[16:27:16 CDT(-0500)] <TonyUnicon1> not a error I see locally

[16:27:42 CDT(-0500)] <TonyUnicon1> has anyone deleted electives?

[16:27:51 CDT(-0500)] <pspaude> No, I haven't.

[16:28:18 CDT(-0500)] <JasonElwood1> nope

[16:28:24 CDT(-0500)] <pspaude> And Jason, no it doesn't matter on electives, I get only one error per open MAP whether there are electives or courses or not.

[16:31:03 CDT(-0500)] <TonyUnicon1> would it be possible to restart the server with normal logging and capture the error on the server side?

[16:32:26 CDT(-0500)] <pspaude> Yes

[16:32:48 CDT(-0500)] <pspaude> Turn minified off and I can get the trace from Chrome Dev tools

[16:33:07 CDT(-0500)] <TonyUnicon1> cool, i see it now, thanks

[16:33:45 CDT(-0500)] <JasonElwood1> you are doing this on Pauls local machine?

[16:33:58 CDT(-0500)] <TonyUnicon1> am I?

[16:34:02 CDT(-0500)] <TonyUnicon1> I meant I see the log on the ticket

[16:34:11 CDT(-0500)] <JasonElwood1> oh ok

[16:34:24 CDT(-0500)] <JasonElwood1> do you need more?

[16:35:27 CDT(-0500)] <TonyUnicon1> nope I think that is enough for me to go on, thanks

[16:35:36 CDT(-0500)] <JasonElwood1> np

[16:35:48 CDT(-0500)] <pspaude> Hmmm, that is interesting I don't get it on my local machine either.

[16:35:48 CDT(-0500)] <TonyUnicon1> I may kick this over the Tyler, I think this was his work unless he's busy, but I'll find the root cause first

[16:36:19 CDT(-0500)] <JasonElwood1> he said he has clients in through Thursday i believe. not sure if it's 100% each day

[16:38:32 CDT(-0500)] <TonyUnicon1> ok

[16:42:26 CDT(-0500)] <pspaude> Tony, got it on my local machine...

[16:42:47 CDT(-0500)] <pspaude> The main thing its pointing to is CoursesGridController line 52

[16:43:09 CDT(-0500)] <pspaude> The me.electiveStore.load()

[16:43:22 CDT(-0500)] <TonyUnicon1> yup, i got it tracked down, thanks

[16:43:36 CDT(-0500)] <TonyUnicon1> after I updated and built I get it as well

[16:43:50 CDT(-0500)] <pspaude> ok, cool

[16:52:05 CDT(-0500)] <TonyUnicon1> when was the last build you guys did?

[16:52:24 CDT(-0500)] <JasonElwood1> it would have been last night

[16:59:34 CDT(-0500)] <js70> thats my code

[17:00:12 CDT(-0500)] <TonyUnicon1> yeah I'm not sure what the problem is though

[17:00:24 CDT(-0500)] <TonyUnicon1> it could be the server side code is stale

[17:00:38 CDT(-0500)] <TonyUnicon1> so I may sit on the ticket till the next build, see if it still pops up

[17:00:40 CDT(-0500)] <js70> what's the error? i checked in a bad ssp.jsb3 last night. corrected in the latest

[17:01:14 CDT(-0500)] <TonyUnicon1> I saw that but I don't think that would mattter, its a hibernate error, its bitching that sortOrder isn't a property of elective

[17:01:16 CDT(-0500)] <TonyUnicon1> but it is

[17:01:21 CDT(-0500)] <js70> my guess is that store is not being loaded because can't find the ElectiveActive.js file

[17:01:30 CDT(-0500)] <js70> ok. cool

[17:01:31 CDT(-0500)] <TonyUnicon1> https://issues.jasig.org/secure/attachment/13588/ssp.log

[17:01:58 CDT(-0500)] <TonyUnicon1> so it looks to me like the server code is a bit stale, but before I put my foot in my mouth, we can wait will the next build tomorrow and see if it's still around

[17:02:09 CDT(-0500)] <TonyUnicon1> I'll handle it since you are picking up the facet UI stuff

[17:02:19 CDT(-0500)] <js70> k

[17:02:44 CDT(-0500)] <JasonElwood1> I can build it now

[17:03:06 CDT(-0500)] <TonyUnicon1> if you want to, but it can wait till tomorrow, it is a pretty harmless

[17:03:15 CDT(-0500)] <TonyUnicon1> I think it just impacts the sort

[17:03:25 CDT(-0500)] <TonyUnicon1> electives load

[17:03:41 CDT(-0500)] <TonyUnicon1> so if it can wait till tomororw, we dont need a build tonight, up to you though

[17:07:25 CDT(-0500)] <JasonElwood1> Paul- I'll rebuild if you aren't testing on Linux CI right now

[17:10:49 CDT(-0500)] <pspaude> Yeah, you can rebuild.

[17:11:35 CDT(-0500)] <JasonElwood1> building now

[17:13:21 CDT(-0500)] <JasonElwood1> JS- I was able to get courses in the Courses in Plan just now. Not sure why it didn't work the other day. I'm building the latest code now to pick up your changes. I did notice that the course counts on the report include courses in Templates instead of just plans. Can you confirm that's what you built?

[17:20:26 CDT(-0500)] <js70> I don't think that should be the case.

[17:20:32 CDT(-0500)] <js70> I'll take a look.

[17:22:31 CDT(-0500)] <TonyUnicon1> I don't see the error anymore in the new build, please confirm

[17:25:50 CDT(-0500)] <js70> Don't see how template courses being included is even possible. PlanCourse and TemplateCourse are completly seperate as well as Plan, Template. I am querying on Plan and PlanCourse. There may be some doubling up going on but definitely template courses are not being counted.

[17:26:23 CDT(-0500)] <JasonElwood1> let me query the db. I didn't expect that many courses. there are only a few test plans

[17:26:46 CDT(-0500)] <js70> k

[17:27:46 CDT(-0500)] <pspaude> The error Jason pointed out (the select MAP api SSP-1310) I'm still getting. It's rarer. The first student it doesn't throw it, but each one subsequently after the MAP fully loads it throws the api error in the console.

[17:30:28 CDT(-0500)] <TonyUnicon1> are we sure its the same error, can you pull the log?

[17:33:13 CDT(-0500)] <JasonElwood1> JS- I have results that show the template courses are not in the report. however, I'm not seeing the same numbers through a query to match the report. Do you have the query handy? Are the courses only for active plan?

[17:33:16 CDT(-0500)] <pspaude> It is the same error. I get it on my local that is up to date and built as well.

[17:36:25 CDT(-0500)] <js70> bingo

[17:37:20 CDT(-0500)] <js70> oops. nope I'm setting objectStatus = ACTIVE

[17:37:46 CDT(-0500)] <js70> man I'm tired. I'm setting it to INACTIVE

[17:38:22 CDT(-0500)] <js70> that is the problem

[17:39:20 CDT(-0500)] <JasonElwood1> I just re-opened 1246 with a minor text problem too while you are in there

[17:41:24 CDT(-0500)] <JasonElwood1> Tony- I'm also seeing the problem as Paul described. I login, select a student, select MAP = no problem. Select a different student, select MAP = same elective sort error

[17:41:56 CDT(-0500)] <JasonElwood1> the first student has elective indicators on courses; the second student does not

[17:46:00 CDT(-0500)] <TonyUnicon1> yup

[17:46:01 CDT(-0500)] <TonyUnicon1> thanks

[17:46:25 CDT(-0500)] <TonyUnicon1> i see it now too, but not the first few times I tried, love those type of bugs

[17:51:25 CDT(-0500)] <pspaude> Anyone change the JScript for the Main tool recent activity? It's really small on IE now? Can't even see all of one entry?

[17:52:52 CDT(-0500)] <pspaude> Nevermind... resizing the window fixes it. Got to love IE every other time resizing it gets small then goes back to normal... :/

[19:34:44 CDT(-0500)] <JasonElwood1> For 1253, I think this can be handled in 1203. the context is switching

[19:35:45 CDT(-0500)] <JasonElwood1> I'll clean up the comments and pass this one

[19:38:09 CDT(-0500)] <TonyUnicon> I did find this https://issues.jasig.org/browse/SSP-1313

[19:38:17 CDT(-0500)] <TonyUnicon> unlucky number too

[19:38:34 CDT(-0500)] <TonyUnicon> looks like I broke this on thursday