jasig-ssp IRC Logs-2013-07-10

Owned by Apereo Infrastructure
Last updated: Jul 10, 2013
4 min read

[10:48:24 CDT(-0500)] <tbain> Just curious with the documents upload, is there anything that prevents users from uploading executables with a .pdf extension at the end?

[10:49:00 CDT(-0500)] <TonyUnicon> none of the file validation is implemented yet

[10:49:08 CDT(-0500)] <TonyUnicon> but I raised that concern yesterday

[10:49:13 CDT(-0500)] <TonyUnicon> probably not much we can do to prevent that

[10:49:27 CDT(-0500)] <tbain> yeah, I noticed that when you were talking about just validating the extension

[15:32:02 CDT(-0500)] <pspaude1> Is there supposed to be a console.log(me.getView()) in the SearchFormController?

[15:32:29 CDT(-0500)] <dmccallum54> doubtful

[15:33:26 CDT(-0500)] <tbain> thank goodness I'm not the only one who leaves those in there ocassionally

[15:33:34 CDT(-0500)] <pspaude1> Ok, its been there awhile, thought maybe whoever had it would be done with it by now. You want me to remove it?

[15:35:03 CDT(-0500)] <dmccallum54> yes pls

[15:35:22 CDT(-0500)] <dmccallum54> let's not enrage IE if we can help it

[15:35:51 CDT(-0500)] <tbain> No! leave it there!

[15:35:56 CDT(-0500)] <tbain> it's really hard to type that

[15:38:59 CDT(-0500)] <pspaude1> Alright its done. Now my console is cleaner.

[15:39:02 CDT(-0500)] <pspaude1> tbain you can test in IE then. (smile)

[17:38:51 CDT(-0500)] <tbain1> Jason?

[17:39:36 CDT(-0500)] <JasonElwood> yep

[17:40:22 CDT(-0500)] <tbain1> I'm having trouble reproducing what you most recently saw on SSP-1336, would it be possible to go back and see if it might have been stale code or something on CI?

[17:40:54 CDT(-0500)] <tbain1> On my local environment, it's working okay, so if worse coems to worse we could just have my laptop run things for the schools

[17:40:59 CDT(-0500)] <tbain1> comes*

[17:41:14 CDT(-0500)] <JasonElwood> I'll retest now

[17:41:18 CDT(-0500)] <tbain1> okay

[17:48:19 CDT(-0500)] <JasonElwood> definitely still seeing it

[17:48:24 CDT(-0500)] <tbain1> hmm

[17:49:41 CDT(-0500)] <JasonElwood> on Linux CI now. I changed elective type Test Color to inactive, but I still see it in the list on the MAP. almost like the API is lagging

[17:50:05 CDT(-0500)] <tbain1> will it mess things up if I go in and try to reproduce it myself?

[17:50:20 CDT(-0500)] <JasonElwood> absolutely not

[17:50:27 CDT(-0500)] <tbain1> okay, thanks

[18:02:14 CDT(-0500)] <pspaude> Jason, it seems you have to log back in or refresh the page and then it updates. I noticed this testing recently. I don't remember if it's always been like that or not.

[18:12:11 CDT(-0500)] <tbain1> Based on real worl usage, while the coaches and advisors ALWAYS be logged in, or will they log out when they go use the bathroom or out for lunch or leave for the day?

[18:12:51 CDT(-0500)] <tbain1> probably comes down to the individual person, but I'm curious if they are sitting there logged in using the system 12 hours a day, or if they occassionally pop on for an appointment?

[18:19:45 CDT(-0500)] <JasonElwood> most will try to stay logged in all day. at IRSC the advisors wants the default timeout changed to 4 hours

[18:22:18 CDT(-0500)] <dmccallum54> so i guess i dont understand on 1336… the issue is that stores don't reload when you nav back into MAP from somewhere else?

[18:22:40 CDT(-0500)] <dmccallum54> or the issue was that your browser had stale code?

[18:23:24 CDT(-0500)] <dmccallum54> if it's that stores dont reload… maybe that's OK if that needs to happen for perf reasons… but that's not in general how the rest of SSP tends to work, i dont think

[18:23:25 CDT(-0500)] <tbain1> So the usual worst case scenario would be that an admin makes an elective inactive at like 10:00am, and for the rest of the day logged in advisors might be erroneously assigning that elective before they logout and in the next morning?

[18:24:06 CDT(-0500)] <tbain1> The electives don't update until you refresh the app or otherwise refresh your session (just refreshing the page will do it)

[18:24:55 CDT(-0500)] <dmccallum54> hmmm…. that sounds like a fairly significant departure from how reference types are handled elsewhere in the app

[18:25:43 CDT(-0500)] <dmccallum54> like… look at CampusAdminViewController.js

[18:26:02 CDT(-0500)] <dmccallum54> it's init() causes stores to refresh

[18:26:18 CDT(-0500)] <dmccallum54> now … there's obviously a perf tradeoff here

[18:26:39 CDT(-0500)] <dmccallum54> but i think that's how most of the SSP tooling works… errs on the side of "refresh" rather than "cache"

[18:27:02 CDT(-0500)] <dmccallum54> is there, like, a deep structural assumption in MAP that makes that not feasible or prohibitively non-performant?

[18:27:32 CDT(-0500)] <tbain1> I'm not too sure, I can't remember the code well enough to say

[18:27:56 CDT(-0500)] <tbain1> it might just be a matter of calling electivesStore.load() at the point where that double click dialog is loaded up

[18:28:09 CDT(-0500)] <tbain1> (though I feel like that's probably what it is doing...)

[18:28:50 CDT(-0500)] <dmccallum54> i think 1336 needs to stay open until we can say one way or another whether it's onerous to always present a fresh list of electives

[18:30:30 CDT(-0500)] <tbain1> probably something I can look at tomorrow morning

[18:30:52 CDT(-0500)] <tbain1> it probably would be fairly simple to implement, just need to look at it, and I'm currently in the middel of doing something for my other project

[18:31:03 CDT(-0500)] <tbain1> Unless Jason just wants to leave it resolved

[18:31:08 CDT(-0500)] <dmccallum54> by "tomorrow morning" you mean, of course, "tonight, in lieu of sleep", right?

[18:31:22 CDT(-0500)] <dmccallum54> yeah… jason's call in the end. i did go ahead and reopen it tho

[18:32:04 CDT(-0500)] <tbain1> hrm... sure

[18:32:13 CDT(-0500)] <tbain1> tomorrow morning in lieu of sleep (big grin)

[18:32:41 CDT(-0500)] <dmccallum54> no sleeping. that's the rule.

[18:32:56 CDT(-0500)] <dmccallum54> i can ship you a 2yr old if you need help with that

[18:58:34 CDT(-0500)] <tbain1> kk, I did an update that makes it so it refreshes every time you open that double click dialog, it works very nicely now

[18:58:40 CDT(-0500)] <tbain1> very responsive to the elective changes