jasig-ssp IRC Logs-2013-07-01
[11:07:33 CDT(-0500)] <tbain> Can coaches only see their plans, or once a coach saves a plan can all other coaches access them?
[11:08:41 CDT(-0500)] <JasonElwood> coaches can see all plans
[11:08:55 CDT(-0500)] <tbain> kk
[13:12:07 CDT(-0500)] <JasonElwood> Paul- we had some problems with SSP rendering in IE8 during the NC training. if you still have the IE8 env running, it would be great to run through the current code. The training env was based on b2.
[13:13:26 CDT(-0500)] <pspaude1> I do have the enviro somewhat up (it's a VM). However, I'm unsure if IE8 is supported or not. I know the icon issues weren't resolved?
[13:14:00 CDT(-0500)] <pspaude1> Furthermore, is this just a test enviro? What are they going to be using post 2014?
[13:15:35 CDT(-0500)] <JasonElwood> at one school, all of their cpu's are centrally managed. IE8 is the standard browser. I didn't ask what they plan to do. the page didn't render, just a gray screen.
[13:16:36 CDT(-0500)] <pspaude1> Ok, that seems like the same issue we had earlier and was fixed correct?
[13:16:49 CDT(-0500)] <JasonElwood> I thought so
[13:17:48 CDT(-0500)] <pspaude1> Ok, then I'll check it out here on my end.
[13:19:28 CDT(-0500)] <JasonElwood> thanks
[13:20:24 CDT(-0500)] <pspaude1> Alright, I verified on Linux CI. Gray screen in IE8. 'undefined' is null of not an object.
[13:21:06 CDT(-0500)] <pspaude1> My local is building with unminified, give me a second and I'll have a better stack trace. Do you want to reopen the previous ticket or create new?
[13:22:53 CDT(-0500)] <JasonElwood> create a new please
[13:44:15 CDT(-0500)] <pspaude1> ok. Created a new issue: SSP-1449. This is the exact same issue as before, stacktrace is field.js meaning there is most likely an extraneous comma in a model somewhere. IE8 doesn't support commas on the last item.
[13:44:53 CDT(-0500)] <JasonElwood> thanks for checking into it
[13:45:09 CDT(-0500)] <pspaude1> No problem
[13:55:44 CDT(-0500)] <js70> Its not just a model correct?
[13:56:02 CDT(-0500)] <js70> Do we have anything we can use to find this extra commas?
[13:56:08 CDT(-0500)] <dmccallum54> jslint
[13:56:17 CDT(-0500)] <pspaude1> Technically, no, I'm unsure what Greg fixed last time.
[13:56:24 CDT(-0500)] <dmccallum54> jslint
[13:56:34 CDT(-0500)] <pspaude1> He used JSLint, but I have not got that to work in sts.
[14:01:01 CDT(-0500)] <js70> did you see this?
[14:01:03 CDT(-0500)] <js70> http://www.andyjamesdavies.com/javascript/installing-jslint-on-eclipse-ide
[14:01:23 CDT(-0500)] <js70> I'm trying it now.
[14:02:03 CDT(-0500)] <pspaude1> Yep, it installs. However, I can't or maybe don't know how to configure it. I need to get it to stop looking at all the files (it takes forever).
[14:02:22 CDT(-0500)] <dmccallum54> i hope that link points to a blog post that just tells you how to download intellij
[14:02:24 CDT(-0500)] <js70> ah, yeah that's going to be a problem.
[14:03:14 CDT(-0500)] <pspaude1> haha Dan, I wish, I haven't found a JSLint for the free version, but I haven't asked around the office or looked into it too much yet.
[14:35:22 CDT(-0500)] <GregElliott1> intelli-who?
[14:44:20 CDT(-0500)] <GregElliott1> I'm going to write up some notes on how I approached 1274 when all was bombing in IE8.
[14:44:39 CDT(-0500)] <GregElliott1> short story that hopefully will get you through is that there are all sorts of online jslint checkers.
[14:45:11 CDT(-0500)] <GregElliott1> if you are checking 3-6 files just before checkin, it might be best to just copy paste the contents into the window and chck that way.
[14:46:03 CDT(-0500)] <GregElliott1> the alternative I used was to check the entire app directory tree, so used jsl-0.3.0 to accomplish that.
[15:19:10 CDT(-0500)] <dmccallum54> StudentActivities.js, line 32 perhaps
[15:20:13 CDT(-0500)] <dmccallum54> SemesterPanel.js line 47
[15:20:28 CDT(-0500)] <dmccallum54> UploadDocuments.js line 117
[15:20:43 CDT(-0500)] <dmccallum54> MapPlanToolViewController.js line 30
[15:20:55 CDT(-0500)] <dmccallum54> MovePlan.js line 25
[15:21:09 CDT(-0500)] <dmccallum54> caseloadassignmentviewcontroller line 49
[15:21:18 CDT(-0500)] <dmccallum54> searchperson line 34
[15:21:27 CDT(-0500)] <dmccallum54> search line 31
[15:21:35 CDT(-0500)] <dmccallum54> tools.js line 39
[15:21:47 CDT(-0500)] <dmccallum54> recentsspactivity line 48
[15:22:00 CDT(-0500)] <dmccallum54> caseloadassignment line 83
[15:22:08 CDT(-0500)] <dmccallum54> contact.js line 113
[15:22:20 CDT(-0500)] <dmccallum54> searchformviewcontroller line 39
[15:22:32 CDT(-0500)] <dmccallum54> moveplandialogcontroller line 27
[15:22:47 CDT(-0500)] <dmccallum54> and line 33
[15:23:02 CDT(-0500)] <dmccallum54> and line 40
[15:23:07 CDT(-0500)] <dmccallum54> moveplandialog line 26
[15:23:16 CDT(-0500)] <dmccallum54> and line 109
[15:23:29 CDT(-0500)] <dmccallum54> courseworkhoursaddadmin line 75
[15:23:42 CDT(-0500)] <dmccallum54> registrationloadaddadmin line 76
[15:31:11 CDT(-0500)] <pspaude1> Changed those still gray screen. I didn't see the error in Tools though, as mine doesn't have an extra comma there, and it looks good compared to the rest of the lines.
[15:32:20 CDT(-0500)] <dmccallum54> sorry. there are two Tool.js. this is the one in ./app/store
[15:32:29 CDT(-0500)] <dmccallum54> the "Accommodation" line
[15:35:15 CDT(-0500)] <pspaude1> Yep, in that one as its the only one with enough lines. What is the error? I don't see it, and it's the second to last line so needs a comma. I even checked the line above, nothing that I can see comapred to the others.
[15:36:49 CDT(-0500)] <dmccallum54> looks like i've got old code. jim pushed a patch to that file this morning
[15:38:30 CDT(-0500)] <pspaude1> Ah, ok, good. Let me go back through and make sure I made all the changes as I was going fast, I'm doing it locally in webapps so I can refresh, then I'll check the trace see if it's different.
[15:44:35 CDT(-0500)] <dmccallum54> i see there's a console statement in JournalToolViewController.js too
[15:44:43 CDT(-0500)] <dmccallum54> i wouldn't expect the app to blow up right away from that, though
[15:47:44 CDT(-0500)] <pspaude1> Yep, and also from early alerts no matter minified or not. But, it shouldn't affect it on login.
[15:48:57 CDT(-0500)] <dmccallum54> all browsers are having trouble with EA still?
[15:50:12 CDT(-0500)] <pspaude1> Yes, I actually fixed it to work on minified, but haven't assigned the issue to me because I haven't tested yet.
[15:50:21 CDT(-0500)] <pspaude1> I commented out this line: in earlyalertservice.js
[15:50:24 CDT(-0500)] <pspaude1> // clear the early alerts
[15:50:24 CDT(-0500)] <pspaude1> /* me.treeStore.setRootNode({
[15:50:24 CDT(-0500)] <pspaude1> text: 'EarlyAlerts',
[15:50:24 CDT(-0500)] <pspaude1> leaf: false,
[15:50:24 CDT(-0500)] <pspaude1> expanded: false
[15:50:25 CDT(-0500)] <pspaude1> });
[15:50:25 CDT(-0500)] <pspaude1> */
[15:51:06 CDT(-0500)] <pspaude1> After that there is only the proxy error buildurl not found which happens no matter what. I tried tracing that down fri and couldn't figure it out either.
[15:53:19 CDT(-0500)] <dmccallum54> k
[15:53:20 CDT(-0500)] <pspaude1> Okay I have an error on caseloadassignement.js 104 and 106,
[16:33:42 CDT(-0500)] <pspaude1> On second thought, I'm unsure why I'm getting those errors. That code hasn't been touched and it was also hanging up my chrome browser too. I will clean and rebuild here in a bit, but it looks like the fixes Dan specd above work and IE8 works now.