jasig-ssp IRC Logs-2013-06-19

[11:48:00 CDT(-0500)] <dmccallum54> FWIW i've been keeping an eye on the New Relic perf monitoring for Jason's training env… been looking pretty darned good from this vantage

[13:52:23 CDT(-0500)] <js70> Dan and the NSA keeping us all in line!

[13:52:29 CDT(-0500)] <js70> that's good news dan

[16:50:51 CDT(-0500)] <pspaude1> Hey Dan, any thoughts on how to reference student_type referance table from the backend to check if an external student type is valid? From the looks of it nothing on the backend references that table at least directly.

[16:52:31 CDT(-0500)] <dmccallum54> look at ExternalPersonServiceImpl#updatePersonFromExternalPerson()

[16:52:48 CDT(-0500)] <dmccallum54> there are a number of other code blocks there where we're mapping from an external code to a reference type code

[16:53:20 CDT(-0500)] <dmccallum54> you'll be doing the same thing (and in the same place) w/ student types

[16:54:10 CDT(-0500)] <pspaude1> Ok, that sounds good. that is the class I'm in right now making the changes to the backend.

[16:54:25 CDT(-0500)] <dmccallum54> k

[16:56:48 CDT(-0500)] <dmccallum54> pspaude1 while you're coding that up, be aware of this: https://issues.jasig.org/browse/SSP-525

[16:57:12 CDT(-0500)] <dmccallum54> that problem makes some of the existing code mapping, um, code, not work as intended

[16:57:58 CDT(-0500)] <dmccallum54> pls make sure the new student type mapping stuff does work properly when it can't resolve a code, tho

[16:58:35 CDT(-0500)] <pspaude1> Ok, so were talking about if it can't find it in the student_type ref table right?

[16:58:55 CDT(-0500)] <dmccallum54> right

[17:25:11 CDT(-0500)] <pspaude1> Now I look dumb, I had that all set up Dan, even have student type open, just forgot to autowire the service.... argh. But, hey I found out about SSP-525...

[17:28:19 CDT(-0500)] <pspaude1> So, I'm going to follow how the others are guarded against, it has seemed to work so far and I'll test it.