uPortal IRC Logs-2013-07-10

Owned by Apereo Infrastructure
Last updated: Jul 10, 2013
3 min read

[10:05:53 CDT(-0500)] <jgribonvald> hi everybody

[10:06:24 CDT(-0500)] <jgribonvald> I'm looking on https://issues.jasig.org/browse/UP-3760

[10:06:33 CDT(-0500)] <jgribonvald> and I have some questions

[10:06:48 CDT(-0500)] <jgribonvald> and maybe need some help

[10:43:36 CDT(-0500)] <EricDalquist> hi jgribonvald

[10:43:46 CDT(-0500)] <jgribonvald> hi EricDalquist

[10:44:36 CDT(-0500)] <jgribonvald> did you watch on https://issues.jasig.org/browse/UP-3760 ?

[10:44:57 CDT(-0500)] <EricDalquist> looking at it now

[10:45:04 CDT(-0500)] <jgribonvald> ok

[10:45:11 CDT(-0500)] <jgribonvald> i will wait so

[10:46:04 CDT(-0500)] <EricDalquist> I think the change looks good

[10:46:10 CDT(-0500)] <EricDalquist> but there are a lot of whitespace changes

[10:46:13 CDT(-0500)] <EricDalquist> which make it hard to read

[10:46:26 CDT(-0500)] <jgribonvald> yes i can't do things better

[10:46:45 CDT(-0500)] <jgribonvald> my development env delete all useless whitespaces

[10:46:53 CDT(-0500)] <jgribonvald> when i edit a file

[10:46:54 CDT(-0500)] <EricDalquist> ah, you can't turn that off?

[10:47:29 CDT(-0500)] <EricDalquist> I mean I agree with cleaning up whitespace issues

[10:47:38 CDT(-0500)] <EricDalquist> so one thing you could do in the future

[10:47:42 CDT(-0500)] <EricDalquist> is fix the whitespace

[10:47:43 CDT(-0500)] <EricDalquist> commit

[10:47:47 CDT(-0500)] <EricDalquist> then make the actual change

[10:47:59 CDT(-0500)] <EricDalquist> then we have two commits, one with the whitespace changes and one with the content change

[10:48:04 CDT(-0500)] <EricDalquist> that makes merging a lot easier

[10:48:28 CDT(-0500)] <jgribonvald> ok i will wtach on that for futur so

[10:48:47 CDT(-0500)] <jgribonvald> So my pull solve the "bug"

[10:48:56 CDT(-0500)] <jgribonvald> but not the user UI

[10:49:02 CDT(-0500)] <EricDalquist> ok

[10:49:08 CDT(-0500)] <jgribonvald> where some things could be done

[10:49:11 CDT(-0500)] <EricDalquist> yeah

[10:49:17 CDT(-0500)] <EricDalquist> well the UI I'm not as familiar with

[10:49:39 CDT(-0500)] <jgribonvald> my PR push a way to do things like sending message

[10:50:13 CDT(-0500)] <EricDalquist> yeah

[10:50:20 CDT(-0500)] <EricDalquist> so we can get that merged

[10:50:21 CDT(-0500)] <jgribonvald> like "portlet Added" or "can't add portlet" or "can't save layout"

[10:50:41 CDT(-0500)] <jgribonvald> but my problem now

[10:50:51 CDT(-0500)] <jgribonvald> is to show these messages to the user

[10:51:22 CDT(-0500)] <jgribonvald> and/or a way to activate/disable the Add portlet

[10:51:56 CDT(-0500)] <jgribonvald> for current tab that are locked

[10:52:24 CDT(-0500)] <jgribonvald> for messages it's not a big difficult, but what is the best ?

[10:53:44 CDT(-0500)] <jgribonvald> do you know who has made the jquery code for up-layout-gallery.js ?

[10:54:46 CDT(-0500)] <jgribonvald> after to activate/disable the Add portlet it's a bit difficult do to some references

[10:55:03 CDT(-0500)] <jgribonvald> *due to

[10:55:08 CDT(-0500)] <EricDalquist> I'm not sure, it should be in the commit history of the file

[10:55:19 CDT(-0500)] <jgribonvald> ah yes i didn't check that

[10:58:32 CDT(-0500)] <jgribonvald> EricDalquist: else do you see a way to render such messages to users ?

[10:58:54 CDT(-0500)] <EricDalquist> I'm not familiar enough with the UI code to really have an answer therre

[10:59:13 CDT(-0500)] <jgribonvald> authors are Jen Bourey and the main editor Matthew Polizzotti

[10:59:19 CDT(-0500)] <EricDalquist> you could try emailing the dev list an explicitly asking Matt Polizzotti

[10:59:25 CDT(-0500)] <EricDalquist> to see if he can help

[10:59:37 CDT(-0500)] <jgribonvald> ok, i will see so

[10:59:51 CDT(-0500)] <jgribonvald> but i can make changes, just need some advices (tongue)

[11:00:51 CDT(-0500)] <jgribonvald> I can add an element like it's done when a tab doesn't have a content, with the message "You can customize ..."

[11:01:32 CDT(-0500)] <jgribonvald> or open a dialog box during few seconds or with a confirm before coming back

[11:04:32 CDT(-0500)] <jgribonvald> I have a concept, so i needed to talk a bit about (tongue)