uPortal IRC Logs-2013-06-27

Owned by Apereo Infrastructure
Last updated: Jun 27, 2013
4 min read

[10:18:28 CDT(-0500)] <jgribonvald> Hello everybody

[10:18:49 CDT(-0500)] <tlev> hello

[10:18:50 CDT(-0500)] <jgribonvald> I would like to talk about a feature,

[10:19:03 CDT(-0500)] <EricDalquist> sounds great (smile)

[10:19:11 CDT(-0500)] <EricDalquist> I still need to review all those pull requests

[10:19:23 CDT(-0500)] <jgribonvald> about to render some iframe on a new window on maximized view

[10:19:43 CDT(-0500)] <jgribonvald> yes that's true (wink)

[10:20:24 CDT(-0500)] <jgribonvald> So my need is to render some iframe portlet in a new browser tab when we "MAXIMIZE" it

[10:20:50 CDT(-0500)] <jgribonvald> i would like to know if you think that i did it in the way

[10:21:16 CDT(-0500)] <jgribonvald> I added a parameter in the iframe description

[10:21:31 CDT(-0500)] <jgribonvald> to tell if we open the iframe in a new window when maximized

[10:22:21 CDT(-0500)] <EricDalquist> like when you click on the iframe portlet's title you get the iframe's src in a new window all by itself?

[10:22:37 CDT(-0500)] <jgribonvald> yes

[10:23:03 CDT(-0500)] <jgribonvald> but not only here, i worked on the org.jasig.portal.url.UrlSyntaxProviderImpl

[10:23:23 CDT(-0500)] <jgribonvald> to generate all links as direct link in the xsl

[10:23:35 CDT(-0500)] <EricDalquist> ok

[10:23:40 CDT(-0500)] <jgribonvald> like that you have on your navigation tabs direct links

[10:23:53 CDT(-0500)] <EricDalquist> so one idea would be to add a new portlet parameter

[10:24:04 CDT(-0500)] <jgribonvald> yes

[10:24:06 CDT(-0500)] <EricDalquist> that is a "alternativeMaximixedLink"

[10:24:12 CDT(-0500)] <jgribonvald> that's what i did

[10:24:22 CDT(-0500)] <EricDalquist> and when you publish the portlet you set that

[10:24:33 CDT(-0500)] <EricDalquist> and then in the XSL you can just replace the generated URL with the portlet param

[10:24:34 CDT(-0500)] <jgribonvald> so now my questions are how to name it

[10:24:40 CDT(-0500)] <jgribonvald> yes

[10:24:56 CDT(-0500)] <jgribonvald> and in the href i add the target

[10:25:34 CDT(-0500)] <EricDalquist> "alternativeMaximixedLink" is a fine name (smile)

[10:25:41 CDT(-0500)] <jgribonvald> ok

[10:25:46 CDT(-0500)] <jgribonvald> and an other question

[10:26:13 CDT(-0500)] <jgribonvald> should i add this param for all portlet, or only for iframe, an other one ?

[10:27:19 CDT(-0500)] <EricDalquist> you can add it to the root CPD

[10:27:21 CDT(-0500)] <jgribonvald> because for iframe i used the prefrence url

[10:27:48 CDT(-0500)] <jgribonvald> but if i set a parameter maybe the best is to set an url

[10:28:08 CDT(-0500)] <jgribonvald> * an url value in this parameter

[10:28:17 CDT(-0500)] <jgribonvald> what do you think ?

[10:29:38 CDT(-0500)] <jgribonvald> but maybe one problem in setting the url in a paramater, will be the length, for the database column

[10:29:50 CDT(-0500)] <EricDalquist> hrm

[10:29:58 CDT(-0500)] <EricDalquist> yeah I'm not sure what the limit is for the parameter data

[10:33:09 CDT(-0500)] <jgribonvald> so ok we can set it : varchar(2000)

[10:33:14 CDT(-0500)] <EricDalquist> right

[10:33:18 CDT(-0500)] <EricDalquist> but people already have it

[10:34:02 CDT(-0500)] <jgribonvald> ?

[10:34:16 CDT(-0500)] <EricDalquist> so we can't change the column length in a patch release

[10:34:33 CDT(-0500)] <jgribonvald> yes but 2000 char is really enougth

[10:34:49 CDT(-0500)] <EricDalquist> ah sorry I miss-understood

[10:34:54 CDT(-0500)] <EricDalquist> yes it 2k right now

[10:35:25 CDT(-0500)] <EricDalquist> and yes that should be enough

[10:36:22 CDT(-0500)] <jgribonvald> so how do you prefer that i do ?

[10:36:25 CDT(-0500)] <jgribonvald> I define a paremeter "alternativeMaximixedLink" for all portlets that will be an alternative url to open in a new browser window when the user want to render it in "MAXIMIZED" view ?

[10:36:38 CDT(-0500)] <EricDalquist> that sounds perfect

[10:36:57 CDT(-0500)] <jgribonvald> ok so i will do that in this way

[10:39:03 CDT(-0500)] <jgribonvald> I just hope that my changes in UrlSyntaxProviderImpl.java will be good, I'm not really familiar with the uses of thsi class

[10:39:10 CDT(-0500)] <jgribonvald> let see in my PR so (wink)

[10:40:36 CDT(-0500)] <EricDalquist> (smile)

[10:40:49 CDT(-0500)] <EricDalquist> well I'm getting tlev introduced to doing uPortal releases

[10:40:59 CDT(-0500)] <EricDalquist> so he and I can review them together in the next few days

[10:41:49 CDT(-0500)] <jgribonvald> ok thx

[10:42:29 CDT(-0500)] <jgribonvald> else for all my PR do you want that i create a JIRA, maybe it's better for you to follow the feature ?

[10:42:40 CDT(-0500)] <EricDalquist> well we need a jira and a PR

[10:42:45 CDT(-0500)] <EricDalquist> we can create the jira for you if you don't

[10:43:09 CDT(-0500)] <jgribonvald> ok, so i will take a look for that when i will a some time so

[10:44:53 CDT(-0500)] <jgribonvald> it's better to talk about some things, because for one feature (sidebar elements) I'm not entirely satisfied, this feature could be improved

[10:45:14 CDT(-0500)] <jgribonvald> but I don't know how to do more

[10:45:15 CDT(-0500)] <EricDalquist> ok

[10:46:04 CDT(-0500)] <jgribonvald> my PR is like a sandbox feature

[10:46:17 CDT(-0500)] <jgribonvald> but it works

[10:46:22 CDT(-0500)] <EricDalquist> good to know, we will keep that in mind when reviewing it

[10:46:42 CDT(-0500)] <jgribonvald> ok thx

[10:47:09 CDT(-0500)] <jgribonvald> don't hesitate to comment in github to talk about it (wink)

[10:47:22 CDT(-0500)] <EricDalquist> will do

[10:50:08 CDT(-0500)] <jgribonvald> my thought about this feature would be about to build an internal portlet, that could be in the middle of navigation links and bookmarks that the user/fragment-template could add in

[10:50:57 CDT(-0500)] <jgribonvald> a such thing would be great in my mind, but I don't have time and ressources to make it