uPortal IRC Logs-2012-09-20

Owned by Apereo Infrastructure
Last updated: Sept 20, 2012
4 min read

[10:47:23 CDT(-0500)] <athena> EricDalquist: have you tested the maven sass plugin on windows?

[10:47:29 CDT(-0500)] <athena> peter seems to have run into some issues

[10:47:30 CDT(-0500)] <EricDalquist> I know its broken

[10:47:33 CDT(-0500)] <athena> oh (sad)

[10:47:34 CDT(-0500)] <athena> shoot.

[10:47:36 CDT(-0500)] <EricDalquist> people keep yelling at me on twitter about it

[10:47:42 CDT(-0500)] <athena> oh, yikes!

[10:47:44 CDT(-0500)] <EricDalquist> there should be a fix coming

[10:47:53 CDT(-0500)] <athena> thanks (smile)

[10:47:54 CDT(-0500)] <EricDalquist> let me see ....

[10:47:57 CDT(-0500)] <EricDalquist> well not from me

[10:48:01 CDT(-0500)] <EricDalquist> from one of the windows users

[10:48:05 CDT(-0500)] <athena> ah!

[10:48:09 CDT(-0500)] <EricDalquist> someone DMd me on twitter asking how to contribute a fix

[10:48:15 CDT(-0500)] <athena> tasked peter with refactoring some of the confusing sass in the mobile theme nad he ran into it

[10:48:26 CDT(-0500)] <EricDalquist> https://github.com/jwachter/sass-maven-plugin/commit/a67a439630ec5e1a1439afd3f8f30acd3af12b62

[10:48:33 CDT(-0500)] <EricDalquist> https://github.com/jimkinsey/sass-maven-plugin/commit/0f708cfb0f88f0506e3e7f50aa9de2ea155ea12b

[10:48:46 CDT(-0500)] <EricDalquist> both people with forks that appear to plan on pulling soon

[10:49:17 CDT(-0500)] <athena> is there something you'd like peter to help with testing?

[10:49:42 CDT(-0500)] <EricDalquist> um ... honestly I haven't done anything about the windows bug

[10:49:49 CDT(-0500)] <EricDalquist> other than wait for someone to submit a pull request

[10:50:04 CDT(-0500)] <athena> maybe he could try one of these locally and see, though

[10:51:03 CDT(-0500)] <EricDalquist> yeah

[10:51:28 CDT(-0500)] <athena> first one looks a lot shorter so i'll have him start there (smile)

[10:51:38 CDT(-0500)] <EricDalquist> https://github.com/jwachter/sass-maven-plugin/commits/master

[10:51:46 CDT(-0500)] <EricDalquist> that guy specifically has 2 commits that fix things for windows

[10:52:01 CDT(-0500)] <athena> oh i see, thanks

[12:33:23 CDT(-0500)] <athena> ok, peter confirms that it works on windows, yay

[12:33:32 CDT(-0500)] <EricDalquist> with that fix?

[12:33:35 CDT(-0500)] <athena> though it'd be good to check it works elsewhere too, i suppose

[12:33:36 CDT(-0500)] <athena> yep

[12:34:13 CDT(-0500)] <EricDalquist> ok

[12:34:24 CDT(-0500)] <EricDalquist> I'll see if I can find some time to get that fixed before 4.0.7

[12:34:53 CDT(-0500)] <athena> awesome :0

[12:35:22 CDT(-0500)] <athena> so just to confirm, i'm trying to remember where we left off the sass-generated vs. static file debate

[12:35:35 CDT(-0500)] <EricDalquist> so 4.0 is doing manual sass gen

[12:35:37 CDT(-0500)] <athena> did we decide not to have the sass goal as part of the uportal build?

[12:35:39 CDT(-0500)] <athena> ok, cool

[12:35:44 CDT(-0500)] <EricDalquist> in master I need to switch to do sass at build time

[12:35:47 CDT(-0500)] <EricDalquist> and remove the css from git

[12:36:08 CDT(-0500)] <athena> gotcha

[12:37:15 CDT(-0500)] <athena> want me to do that?

[12:37:27 CDT(-0500)] <EricDalquist> sure

[12:37:29 CDT(-0500)] <EricDalquist> that would be great

[12:37:33 CDT(-0500)] <athena> ok, sure

[12:37:59 CDT(-0500)] <EricDalquist> one thing we should do with that work though

[12:38:11 CDT(-0500)] <EricDalquist> is to document how to get sass to generate the css for a sklin

[12:38:16 CDT(-0500)] <EricDalquist> and clone that into a CSS based skin

[12:38:22 CDT(-0500)] <EricDalquist> for people that don't want to deal with sass

[12:39:13 CDT(-0500)] <athena> yeah that sounds like a good plan

[15:59:24 CDT(-0500)] <athena> EricDalquist: could you sanity check this for me? i'm sure i'm doing something stupid

[15:59:26 CDT(-0500)] <athena> mvn org.jasig.maven:sass-maven-plugin:watch -DoutputDirectory=/usr/local/tomcat_instances/up3/webapps/uPortal -Dskin=uportal3

[15:59:39 CDT(-0500)] <athena> i'm getting: The parameters 'outputDirectory', 'skin' for goal org.jasig.maven:sass-maven-plugin:1.0.0:watch are missing or invalid

[15:59:39 CDT(-0500)] <EricDalquist> that seems reasonable

[15:59:46 CDT(-0500)] <EricDalquist> oh

[15:59:50 CDT(-0500)] <EricDalquist> hrm

[15:59:52 CDT(-0500)] <EricDalquist> just a sec

[15:59:55 CDT(-0500)] <athena> sure

[16:00:02 CDT(-0500)] <athena> figured i'd missed something obvious

[16:00:17 CDT(-0500)] <EricDalquist> prefix both with watch.

[16:00:21 CDT(-0500)] <athena> oh!

[16:00:22 CDT(-0500)] <EricDalquist> so -Dwatch.skin

[16:00:31 CDT(-0500)] <athena> excellent, thanks (smile)

[16:02:18 CDT(-0500)] <athena> ah, actually watch.output, there we go

[16:02:21 CDT(-0500)] <athena> neato

[16:02:26 CDT(-0500)] <EricDalquist> yup

[16:02:30 CDT(-0500)] <EricDalquist> sadly only one skin at a time

[16:02:34 CDT(-0500)] <athena> so the way this works w/ specifying skin name

[16:02:36 CDT(-0500)] <athena> how is that mapped?

[16:02:37 CDT(-0500)] <EricDalquist> sass keeps some sort of shared state on the file system

[16:02:40 CDT(-0500)] <EricDalquist> best match

[16:02:41 CDT(-0500)] <athena> can you specify common?

[16:02:54 CDT(-0500)] <EricDalquist> it knows about all the "sass templates" it finds using the ant path matching

[16:03:02 CDT(-0500)] <athena> oh ok

[16:03:02 CDT(-0500)] <EricDalquist> and then you specify part of the directory name the skin is in

[16:03:18 CDT(-0500)] <EricDalquist> https://github.com/Jasig/sass-maven-plugin/blob/master/src/main/java/org/jasig/maven/plugin/sass/AbstractSassMojo.java#L66

[16:03:25 CDT(-0500)] <athena> thanks so much

[16:03:36 CDT(-0500)] <athena> i need to go find somewhere useful to document this

[16:03:40 CDT(-0500)] <EricDalquist> yeah

[16:03:43 CDT(-0500)] <EricDalquist> I wasn't really sure ...

[16:03:50 CDT(-0500)] <EricDalquist> you could document some of it on github

[16:03:53 CDT(-0500)] <athena> i guess this part can go in the manual, since it applies to 4.0 as well

[16:03:56 CDT(-0500)] <EricDalquist> via pages for the project

[16:03:58 CDT(-0500)] <EricDalquist> but the up stuff

[16:04:01 CDT(-0500)] <EricDalquist> yeah it can go in the manual

[16:04:10 CDT(-0500)] <athena> but you're right, probably some should go in the project too

[16:04:14 CDT(-0500)] <athena> anyway, progress!

[16:04:49 CDT(-0500)] <EricDalquist> yay (smile)

[16:05:02 CDT(-0500)] <EricDalquist> going to see if I can look at that login report toninight

[16:05:33 CDT(-0500)] <athena> awesome