uPortal IRC Logs-2010-03-01

Owned by Apereo Infrastructure
Last updated: Mar 01, 2010Version comment
6 min read

[07:48:46 EST(-0500)] * athena (~athena@adsl-99-90-243-15.dsl.wlfrct.sbcglobal.net) has joined ##uportal
[09:01:37 EST(-0500)] * EricDalquist (~dalquist@2607:f388:e:0:221:9bff:fe37:e768) has joined ##uportal
[10:11:36 EST(-0500)] * holdorph (~holdorph@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
[10:22:21 EST(-0500)] <athena> hey EricDalquist
[10:22:25 EST(-0500)] <EricDalquist> hello
[10:22:28 EST(-0500)] <athena> i found a pretty major skin bug over the weekend
[10:22:37 EST(-0500)] <athena> the "fl-theme-mist" class on the body isn't being set properly
[10:22:40 EST(-0500)] <EricDalquist> yeah, and there is that portlet caching bug
[10:22:52 EST(-0500)] <athena> yeah, that is also no good (sad)
[10:22:53 EST(-0500)] <athena> thou
[10:22:56 EST(-0500)] <EricDalquist> I need to get caught up on the lists
[10:23:07 EST(-0500)] <EricDalquist> was on vacation thu/fri doing home remodeling
[10:23:14 EST(-0500)] <athena> yeah we missed you (smile)
[10:23:16 EST(-0500)] <athena> it go well?
[10:23:26 EST(-0500)] <EricDalquist> yes
[10:23:27 EST(-0500)] <EricDalquist> still going
[10:23:32 EST(-0500)] <athena> i'm glad parker at least was able to characterize the portlet caching issue better than i ever could
[10:23:35 EST(-0500)] <EricDalquist> which is why I haven't been as active
[10:23:42 EST(-0500)] * michelled (~michelled@142.150.154.101) has joined ##uportal
[10:23:46 EST(-0500)] <athena> so for the skin thing, i know what's wrong, but wanted to talk to you before just fixing it
[10:23:53 EST(-0500)] <EricDalquist> every non-work moment has been devoted to basement renovation
[10:24:00 EST(-0500)] <EricDalquist> so is it a simple fix?
[10:24:03 EST(-0500)] <athena> yeah that sounds pretty busy (smile)
[10:24:12 EST(-0500)] <athena> well, yes, but i wanted to ask why you'd made a change
[10:24:20 EST(-0500)] <EricDalquist> ok
[10:24:27 EST(-0500)] <athena> it was revision 47878
[10:24:35 EST(-0500)] <athena> took out something gary had added to skin.xml
[10:24:49 EST(-0500)] <athena> which i assume is probably because it wasn't part of the XML schema, or something like that
[10:25:08 EST(-0500)] <athena> he'd added something like <css type="fss-theme" name="fl-theme-mist">
[10:25:12 EST(-0500)] <EricDalquist> right
[10:25:21 EST(-0500)] <athena> and set up universality.xml to look for that property to properly set the body class
[10:25:22 EST(-0500)] <EricDalquist> which never made it through to the XSL as far as I know
[10:25:29 EST(-0500)] <athena> it did, actually
[10:25:31 EST(-0500)] <EricDalquist> oh
[10:25:32 EST(-0500)] <EricDalquist> weird
[10:25:41 EST(-0500)] <EricDalquist> that is probably unintended
[10:25:41 EST(-0500)] <athena> so now all the portlet chrome is missing
[10:26:01 EST(-0500)] <athena> so anyway, that's why i wanted to talk to you before just changing it back
[10:26:18 EST(-0500)] <athena> we do need to address it though, because it'll affect our mobile development conference seminar
[10:26:32 EST(-0500)] <EricDalquist> nick is confused as to how that was getting through as well
[10:26:36 EST(-0500)] <athena> but we can talk about it tomorrow or something if that's easier - i'm sure you have a lot to catch up on
[10:26:41 EST(-0500)] <EricDalquist> we can talk now
[10:26:45 EST(-0500)] <athena> ok
[10:26:52 EST(-0500)] <EricDalquist> the problem is we have no idea how that makes it through
[10:27:07 EST(-0500)] <EricDalquist> the skin aggregator reads skin.xml via JAXB
[10:27:12 EST(-0500)] <athena> here we go:
[10:27:12 EST(-0500)] <athena> <xsl:variable name="FLUID_THEME" select="document($SKIN_CONFIG_URL)/s:resources/css[@type='fss-theme']/@name"/>
[10:27:20 EST(-0500)] <EricDalquist> then generates the <head> entries from scratch
[10:27:22 EST(-0500)] <EricDalquist> oh ...
[10:27:24 EST(-0500)] <athena> it's not really coming through the aggregator
[10:27:25 EST(-0500)] <EricDalquist> up that's not good
[10:27:38 EST(-0500)] <EricDalquist> so the real fix would be to fix to skin aggregator
[10:27:40 EST(-0500)] <athena> looks like gary added that line to universality.xml
[10:27:48 EST(-0500)] <EricDalquist> that is not ok
[10:27:51 EST(-0500)] <athena> yeah
[10:27:51 EST(-0500)] <EricDalquist> yeah
[10:27:56 EST(-0500)] <athena> i agree that's not what we want to be doing
[10:28:20 EST(-0500)] <athena> but i wasn't sure what we did want to do
[10:28:40 EST(-0500)] <athena> you're thinking we add some ability for the aggregator to set a class on the body element?
[10:28:54 EST(-0500)] <EricDalquist> well we need to add type and name to the supported attributes for the aggregator
[10:28:55 EST(-0500)] <athena> or make some property available somewhere?
[10:29:09 EST(-0500)] <EricDalquist> wait
[10:29:09 EST(-0500)] <EricDalquist> hrm
[10:29:17 EST(-0500)] <EricDalquist> I'm confused
[10:29:30 EST(-0500)] <EricDalquist> does he need those to end up on the <link> attribute?
[10:29:32 EST(-0500)] <EricDalquist> or on the body?
[10:29:33 EST(-0500)] <athena> no
[10:29:37 EST(-0500)] <athena> it's a class on the body
[10:29:48 EST(-0500)] <athena> so it winds up as <body class="up fl-theme-mist"
[10:29:54 EST(-0500)] <athena> and we do very much need that attribute there
[10:29:56 EST(-0500)] <EricDalquist> so just this one skin has a special class name on the body?
[10:30:10 EST(-0500)] <athena> actually they're all supposed to
[10:30:22 EST(-0500)] <athena> looks like the coal one never got disabled, so that skin renders correctly
[10:30:39 EST(-0500)] <athena> well, not correctly, because it actually has a bunch of bugs, but they're unrelated
[10:30:45 EST(-0500)] <EricDalquist> so we need a way to associate something like "skin X needs fluid theme Y"?
[10:30:55 EST(-0500)] <athena> not even, really . . .
[10:31:07 EST(-0500)] <athena> i mean, the CSS import information is already in the file and that's all working fine
[10:31:23 EST(-0500)] <athena> more like "skin X uses the following string as the body class"
[10:32:02 EST(-0500)] <EricDalquist> and that isn't easily predictable
[10:32:16 EST(-0500)] <EricDalquist> since it all depends on the skin?
[10:33:24 EST(-0500)] <athena> yes
[10:33:54 EST(-0500)] <EricDalquist> uhg
[10:33:57 EST(-0500)] <EricDalquist> uhg uhg uhg
[10:35:26 EST(-0500)] <EricDalquist> ok
[10:35:31 EST(-0500)] <EricDalquist> well his solution is good for now
[10:35:35 EST(-0500)] <EricDalquist> we're going to really have to fix this
[10:35:49 EST(-0500)] <EricDalquist> can you create two jiras?
[10:35:54 EST(-0500)] <EricDalquist> one for the immediate fix
[10:36:13 EST(-0500)] <EricDalquist> and one for a 'update the skin aggregator to support parameters' ?
[10:36:22 EST(-0500)] <EricDalquist> I'll take a look at parker's issue later today too
[10:36:45 EST(-0500)] <EricDalquist> and we can plan on getting 3.2.1 out on Thursday
[10:38:31 EST(-0500)] <athena> yes
[10:38:33 EST(-0500)] <athena> i'll do that
[10:38:38 EST(-0500)] <athena> oh, that'd be cool
[10:38:45 EST(-0500)] <athena> actually there are some other things that could use fixing
[10:38:52 EST(-0500)] <athena> bugs in the coal skin
[10:38:59 EST(-0500)] <athena> and turns out the weather portlet is misbehaving
[10:39:03 EST(-0500)] <athena> i'll try and assemble a list
[10:39:14 EST(-0500)] <EricDalquist> great
[10:39:15 EST(-0500)] <athena> i have to leave for the airport in a couple hours though, so it may not be until tomorrow
[10:39:19 EST(-0500)] <EricDalquist> that's fine
[10:39:23 EST(-0500)] <athena> ok, sounds great
[10:39:24 EST(-0500)] <EricDalquist> yeah so my idea for the real fix for this
[10:39:38 EST(-0500)] <EricDalquist> is to add a <themeParameter> section in skin.xml
[10:39:53 EST(-0500)] <EricDalquist> and then have the skin dao in the portal code participate in the theme XSLT setup
[10:39:54 EST(-0500)] <athena> and then have those be available to the theme xsl files?
[10:40:00 EST(-0500)] <EricDalquist> yeah
[10:40:01 EST(-0500)] <athena> that sounds great
[10:40:10 EST(-0500)] <athena> and would allow us to re-use it when necessary
[10:40:12 EST(-0500)] <athena> i like that plan (smile)
[10:40:13 EST(-0500)] <EricDalquist> yup
[10:40:16 EST(-0500)] <athena> awesome
[10:40:21 EST(-0500)] <EricDalquist> too big to fix for Thursday though
[10:40:26 EST(-0500)] <athena> yeah
[10:40:29 EST(-0500)] <athena> sounds good
[11:06:43 EST(-0500)] * awills (~awills@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
[11:49:59 EST(-0500)] * colinclark (~colin@142.150.154.101) has joined ##uportal
[11:56:22 EST(-0500)] * Sememmon (~Sememmon@unaffiliated/sememmon) has joined ##uportal
[14:06:57 EST(-0500)] * athena (~athena@wsip-70-166-149-189.ri.ri.cox.net) has joined ##uportal
[14:09:33 EST(-0500)] * athena7 (~athena@wsip-70-166-149-189.ri.ri.cox.net) has joined ##uportal
[14:20:43 EST(-0500)] * colinclark (~colin@142.150.154.101) has joined ##uportal
[14:21:11 EST(-0500)] * michelled (~michelled@142.150.154.101) has joined ##uportal
[15:03:58 EST(-0500)] * athena (~athena@wsip-70-166-149-189.ri.ri.cox.net) has joined ##uportal
[15:07:10 EST(-0500)] <athena> hey EricDalquist - one other question for you
[15:07:29 EST(-0500)] <athena> we have a couple projects that have a ProxyView class that basically take a url and sends back a proxy of it
[15:07:32 EST(-0500)] <EricDalquist> ok
[15:07:34 EST(-0500)] <athena> useful for ajax and such
[15:07:43 EST(-0500)] <athena> do we want to bring that into the ajaxportletsupport project?
[15:07:47 EST(-0500)] <EricDalquist> sounds like a nice security hole too (wink)
[15:07:51 EST(-0500)] <athena> seems generally useful, though it does require HttpClient
[15:07:54 EST(-0500)] <athena> haha
[15:07:54 EST(-0500)] <athena> yes
[15:08:09 EST(-0500)] <athena> potentially - i'd agree it's a "use with caution" type of thing
[15:08:20 EST(-0500)] <athena> maybe adding it to the main library is just inviting too much danger - dunno
[15:08:20 EST(-0500)] <EricDalquist> can the code have URL restrictions put in place?
[15:08:28 EST(-0500)] <EricDalquist> better yet can it be used in a white-list only mode?
[15:08:39 EST(-0500)] <athena> well, it only takes URLs you pass to it via the model
[15:08:43 EST(-0500)] <EricDalquist> ah
[15:08:44 EST(-0500)] <EricDalquist> ok
[15:08:54 EST(-0500)] <athena> so you have to call something like model.put(ProxyView.URL, "urlhere");
[15:08:56 EST(-0500)] <EricDalquist> so you can't just pass a URL on the request
[15:08:59 EST(-0500)] <athena> so it's not like user-accessible or anything
[15:09:01 EST(-0500)] <athena> no
[15:09:01 EST(-0500)] <EricDalquist> ok
[15:09:05 EST(-0500)] <EricDalquist> sounds good
[15:09:13 EST(-0500)] <athena> it's a Spring View implementation
[15:09:27 EST(-0500)] <athena> though i'd still agree you should probably only use it for trusted sites
[15:09:46 EST(-0500)] <athena> gah the airport alarm is piercing
[15:10:17 EST(-0500)] <athena> you have a preference for what version of HttpClient I add it with?
[15:10:40 EST(-0500)] <EricDalquist> nope
[15:10:43 EST(-0500)] <athena> ok
[15:10:49 EST(-0500)] <athena> i suppose i'll just do the latest
[15:11:13 EST(-0500)] <athena> and i think httpclient 3 and 4 are different enough that you can include both in a project without causing problems
[15:11:25 EST(-0500)] <EricDalquist> yeah
[15:29:39 EST(-0500)] <athena> flight boarding
[15:29:40 EST(-0500)] <athena> cya!
[17:57:53 EST(-0500)] * awills (~awills@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
[19:17:49 EST(-0500)] * awills (~awills@wsip-72-215-204-133.ph.ph.cox.net) has left ##uportal
[21:34:57 EST(-0500)] * Sememmon (~Sememmon@unaffiliated/sememmon) has joined ##uportal