jasig-ssp IRC Logs-2013-02-13

Owned by Apereo Infrastructure
Last updated: Feb 13, 2013
5 min read

[09:39:11 CST(-0600)] <TonyUnicon> I haven't taken full inventory of every question yet but I did identify at least one question that shouldn't be using hard coded values

[09:39:25 CST(-0600)] <TonyUnicon> created a ticket-735

[09:39:47 CST(-0600)] <TonyUnicon> it looks like someone had thought about the problems around dependencies

[09:40:20 CST(-0600)] <TonyUnicon> because if you try to delete 'military' for example from Education Goals, it gives you a message about it being important to SSP functionality

[09:40:42 CST(-0600)] <TonyUnicon> it just wasn't followed through on the questionnaire side of things

[09:41:35 CST(-0600)] <TonyUnicon> SSP-735 rather

[09:46:37 CST(-0600)] <dmccallum54> i see Ssp.util.Constants.EDUCATION_GOAL_MILITARY_ID listed as a "restricted admin item id" in Constants.js

[09:46:48 CST(-0600)] <dmccallum54> so yeah there's definitely been some thought

[09:47:27 CST(-0600)] <dmccallum54> SSP-451 suggests there's some bodies buried out there tho...

[09:47:39 CST(-0600)] <dmccallum54> i.e. deps that aren't protected by that list of IDs

[09:48:01 CST(-0600)] <TonyUnicon> well Jason's document will help

[09:48:06 CST(-0600)] <dmccallum54> my other concern for SSP-671 was that it seemed like entire select boxes in some cases were just hard-coded

[09:48:11 CST(-0600)] <TonyUnicon> I'll go through and make sure everything is being enforced

[09:48:19 CST(-0600)] <dmccallum54> not just the references to "special" reference data IDs

[09:49:03 CST(-0600)] <TonyUnicon> right

[09:49:09 CST(-0600)] <TonyUnicon> education goals being one of them

[09:49:25 CST(-0600)] <TonyUnicon> once im done with these new fields I'll go through and try to identify all of them

[09:49:37 CST(-0600)] <TonyUnicon> to hook em up to the reference values takes very little time

[09:49:46 CST(-0600)] <TonyUnicon> relatively

[09:50:42 CST(-0600)] <dmccallum54> ok. thx. wasn't sure if you were talking about collecting an inventory of deps or an inventory of static menu options which shouldnt be.

[09:50:53 CST(-0600)] <TonyUnicon> well both

[09:50:59 CST(-0600)] <TonyUnicon> need to be done

[09:51:02 CST(-0600)] <dmccallum54> k

[09:51:44 CST(-0600)] <dmccallum54> might make sense to track the static menu items work as a separate ticket. e.g. if someone else is just looking for a small task to pick up.

[09:51:59 CST(-0600)] <TonyUnicon> i will

[09:52:01 CST(-0600)] <dmccallum54> thx

[09:52:10 CST(-0600)] <dmccallum54> dont want to create excess admin overhead.

[09:52:25 CST(-0600)] <dmccallum54> but we will have a bunch of people coming free looking to contribute a few hours here and there

[09:52:28 CST(-0600)] <TonyUnicon> SSP-735 only refers to work around static menu items

[09:52:30 CST(-0600)] <TonyUnicon> not dependencies

[09:53:04 CST(-0600)] <dmccallum54> gotcha.

[09:54:30 CST(-0600)] <TonyUnicon> what is merciful about the way the intake questionnaire is designed is the GUI is super generic and the question instances them selves are modeled 100% in java

[09:54:36 CST(-0600)] <TonyUnicon> which makes the task 200% easier IMO

[09:55:07 CST(-0600)] <TonyUnicon> StudentIntakeFormManager is ripe for refactoring though

[09:55:12 CST(-0600)] <dmccallum54> was going to ask about that

[09:55:26 CST(-0600)] <dmccallum54> b/c it's somewhat of a departure from the way the rest of the app is built

[09:55:38 CST(-0600)] <dmccallum54> where the backend really has very little to nothing to say about how any given screen is built

[09:56:08 CST(-0600)] <TonyUnicon> yeah and I have to say I'm grateful for it

[09:56:37 CST(-0600)] <TonyUnicon> if I had to go through and monkey around with coffee scripts and add this to a java script view model it would have increased development time significantly

[09:58:04 CST(-0600)] <TonyUnicon> by making the client side generic it makes authoring new questions very easy

[09:58:12 CST(-0600)] <TonyUnicon> which I think was their intention

[09:58:29 CST(-0600)] <TonyUnicon> you give up some control in terms of how these questions are rendered

[09:58:35 CST(-0600)] <TonyUnicon> but its a fair trade I think

[09:59:05 CST(-0600)] <dmccallum54> if you're a java dev (smile)

[10:00:34 CST(-0600)] <TonyUnicon> indeed

[10:00:38 CST(-0600)] <TonyUnicon> (smile)

[10:00:52 CST(-0600)] <TonyUnicon> but I think even a javascript dev would cringe to see this done in js

[10:01:11 CST(-0600)] <TonyUnicon> its ugly enough in java

[10:01:50 CST(-0600)] <TonyUnicon> or coffee script —> js

[10:01:58 CST(-0600)] <TonyUnicon> which is what we would have had to do

[10:04:24 CST(-0600)] <dmccallum54> yeah, i buy that building out the form dynamically in straight coffeescript would be a pain

[10:04:59 CST(-0600)] <TonyUnicon> i like coffeescript the more I use it but there are some pain points

[10:05:00 CST(-0600)] <dmccallum54> but… i also see the equivalent form in the ext.js app and the js looks really quite manageable

[10:05:52 CST(-0600)] <dmccallum54> which makes me think that just given the right framework support you neednt end up with spaghetti on the client but can still maintain the clear separation between "data on the server"/"UI on the client"

[10:06:05 CST(-0600)] <dmccallum54> but anyway… it's all just idle chit-chat

[10:06:15 CST(-0600)] <dmccallum54> not going to change how it works at this point

[10:06:20 CST(-0600)] <TonyUnicon> yeah

[10:06:34 CST(-0600)] <TonyUnicon> I think I was just excited to right some java at this point

[10:06:38 CST(-0600)] <dmccallum54> and if they way it works is helping you get shit done…. great!

[10:06:40 CST(-0600)] <TonyUnicon> its been few and far between

[10:06:42 CST(-0600)] <dmccallum54> heh

[10:06:45 CST(-0600)] <dmccallum54> i feel your pain

[10:07:04 CST(-0600)] <dmccallum54> give me a css task and you're looking at a whole day ordeal

[10:07:12 CST(-0600)] <TonyUnicon> uhg

[10:07:24 CST(-0600)] <TonyUnicon> yeah I think its css I hate the most

[10:17:11 CST(-0600)] <dmccallum54> TonyUnicon speaking of large java classes… thought you might like this… https://github.com/dmccallum/antipatterns-presentation/blob/master/content/images/siteaction-line-count.png

[10:18:38 CST(-0600)] <TonyUnicon> lol

[10:19:45 CST(-0600)] <TonyUnicon> written by someone using emacs im sure

[10:20:26 CST(-0600)] <dmccallum54> crazed gerbils using emacs, more like

[10:21:45 CST(-0600)] <TonyUnicon> I was on a project that used some nanny maven plugin (I tried to remember the name but it escapes me at the moment), it would enforce architectural layers, method length, number of branches per method, class length ect..

[10:21:53 CST(-0600)] <TonyUnicon> it would reject the build if something was violated

[10:22:32 CST(-0600)] <dmccallum54> the infinum team was, i think, using PMD aggressively for stuff like that

[10:23:03 CST(-0600)] <TonyUnicon> yeah I think it has its place

[10:23:25 CST(-0600)] <dmccallum54> i dont know that we need to be terribly re/prescriptive. but i would definitely like to get findbugs hooked up (cheap win) and add Sonar to our CI env

[10:23:39 CST(-0600)] <TonyUnicon> i agree

[10:24:25 CST(-0600)] <TonyUnicon> code quality is not an issue in general, the java classes especially are pretty slim. StudentIntakeFormManager is just a broad departure from that

[10:25:09 CST(-0600)] <TonyUnicon> but those there is no penalty in using those tools

[10:25:25 CST(-0600)] <TonyUnicon> but there is no*

[10:29:49 CST(-0600)] <TonyUnicon> dependometer

[10:29:54 CST(-0600)] <TonyUnicon> that was the name of the plugin

[10:30:27 CST(-0600)] <TonyUnicon> http://source.valtech.com/display/dpm/Dependometer

[10:31:18 CST(-0600)] <TonyUnicon> it was funny because at the time I was working along side devs in Germany, it was their idea to use it, and I'm sure if it they could they'd have the plugin output 'NEIN STACKENBLOCHEN' if it failed the build

[10:32:03 CST(-0600)] <TonyUnicon> (snl reference)

[10:32:57 CST(-0600)] <dmccallum54> heh

[10:47:24 CST(-0600)] <TonyUnicon> ahh conan not snl, close enough

[14:20:31 CST(-0600)] <prabhu> hi

[14:20:52 CST(-0600)] <prabhu> What version of uportal does this SSP uses?

[14:53:50 CST(-0600)] <dmccallum54> the details are a bit complicated but basically boil down to 4.1.x or 4.0.x