jasig-ssp IRC Logs-2013-08-30

[10:42:19 CDT(-0500)] <dmccallum54> can i rebuild Linux CI to pick up 1697?

[10:43:11 CDT(-0500)] <pspaude> I'm not on it, so go ahead if no one else is.

[10:43:34 CDT(-0500)] <TonyUnicon> fine by me

[11:02:32 CDT(-0500)] <dmccallum54> Patty_ linux CI is back if you'd like to test the 1697 fix

[11:30:17 CDT(-0500)] <pspaude> What happened to attach screenshot in Jira? Is there some new hidden way?

[11:31:11 CDT(-0500)] <TonyUnicon> i think that was a plugin and didnt make the upgrade

[11:33:46 CDT(-0500)] <pspaude> Ok, cool. The attach file does nearly the same thing. Has a preview too I guess if its something it can read like png jpeg.

[11:35:56 CDT(-0500)] <Patty_> trying to test with

[11:36:00 CDT(-0500)] <Patty_> jtexas902

[11:36:06 CDT(-0500)] <Patty_> student

[11:36:11 CDT(-0500)] <Patty_> with advisor0 as password

[11:36:19 CDT(-0500)] <Patty_> says invalid username and password

[11:37:09 CDT(-0500)] <dmccallum54> that user is not in the uportal database

[11:37:26 CDT(-0500)] <Patty_> ok

[11:37:28 CDT(-0500)] <dmccallum54> i dont know why, but linux CI has only a small fraction of student users in the uP database

[11:37:35 CDT(-0500)] <Patty_> I'll pick another user

[11:37:41 CDT(-0500)] <TonyUnicon> we ran init portal yesterday no?

[11:37:47 CDT(-0500)] <pspaude> I can add him if you want Patty

[11:38:05 CDT(-0500)] <TonyUnicon> init portal would scrub those uportal userse

[11:38:16 CDT(-0500)] <TonyUnicon> users*

[11:39:22 CDT(-0500)] <pspaude> Patty you can use my user I always use, probably the data is scrubbed but he seems to be on most of the ci's jwhite226.

[11:39:34 CDT(-0500)] <pspaude> Just checked he's in.

[11:39:55 CDT(-0500)] <TonyUnicon> Dan, do you think I should try to get SSP-1700 in?

[11:41:53 CDT(-0500)] <dmccallum54> Patty_ here's an abbreviated list of students I see in the uP db

[11:42:15 CDT(-0500)] <dmccallum54> https://gist.github.com/dmccallum/6391861

[11:43:16 CDT(-0500)] <dmccallum54> TonyUnicon no did not run initportal yesterday b/c i was eventually able to reproduce a problem consistently

[11:43:29 CDT(-0500)] <dmccallum54> so decided it wasn't just crap data

[11:44:01 CDT(-0500)] <TonyUnicon> ok

[11:44:22 CDT(-0500)] <pspaude> Dan does the sync have to happen for an added student? I added jTexas902 and I can't login or get out of mygps. Has login button only not logout so now its stuck (until I clear browser cache).

[11:44:26 CDT(-0500)] <dmccallum54> TonyUnicon if you think the SSP-1700 fix is dead simple, sure

[11:44:38 CDT(-0500)] <Patty_> thanks dan

[11:44:46 CDT(-0500)] <TonyUnicon> yeah it is, ok

[11:45:14 CDT(-0500)] <dmccallum54> pspaude what do you mean exactly by "added"?

[11:46:19 CDT(-0500)] <pspaude> Added via uPortal the usual way (since I was in CI as admin already). He was already in SSP.

[11:46:50 CDT(-0500)] <pspaude> Then I logged out adn logged in as him to verify. Went to mygps screen but login button displayed. So I was stuck, couldn't logout and it won't let me login.

[11:47:03 CDT(-0500)] <dmccallum54> i see this the logs

[11:47:16 CDT(-0500)] <dmccallum54> https://gist.github.com/dmccallum/6391914

[11:48:39 CDT(-0500)] <pspaude> Hmm interesting. So why didnt' the existing account work?

[11:48:53 CDT(-0500)] <pspaude> I tried it first before I created as Patty said she couldn't log in.

[11:50:25 CDT(-0500)] <dmccallum54> ssp=# select username from person where lower(school_id) = 'jtexas902';

[11:50:25 CDT(-0500)] <dmccallum54> username

[11:50:25 CDT(-0500)] <dmccallum54> ----------

[11:50:25 CDT(-0500)] <dmccallum54> jtexas

[11:50:25 CDT(-0500)] <dmccallum54> (1 row)

[11:50:27 CDT(-0500)] <dmccallum54> that's why

[11:50:43 CDT(-0500)] <dmccallum54> any idea where 'jtexas' came from?

[11:51:11 CDT(-0500)] <Patty_> do you want me to describe issues in this room

[11:51:15 CDT(-0500)] <Patty_> or create a jira ticket?

[11:51:21 CDT(-0500)] <dmccallum54> just create tickets

[11:52:12 CDT(-0500)] <js70> Txas?

[11:52:15 CDT(-0500)] <js70> Texas?

[11:53:55 CDT(-0500)] <dmccallum54> username and school_id have to agree

[11:54:09 CDT(-0500)] <dmccallum54> in this case uP and SSP match on school_id but not username

[11:54:45 CDT(-0500)] <dmccallum54> i will just update the SSP recrord

[11:55:15 CDT(-0500)] <dmccallum54> done

[11:55:19 CDT(-0500)] <dmccallum54> try again pls

[11:55:35 CDT(-0500)] <pspaude> Right makes sense

[11:56:09 CDT(-0500)] <pspaude> I'm trying now. Was just going to do the same thing and then I clicked on retrieve and saw you updated it.

[11:57:00 CDT(-0500)] <pspaude> Aright jtexas902 works. And is a bad student lots of student intakes to fill out.

[11:57:13 CDT(-0500)] <dmccallum54> texas. figures.

[12:00:20 CDT(-0500)] <TonyUnicon> ohh

[12:00:48 CDT(-0500)] <TonyUnicon> the only time I speak ill of texas is during the cowboys - giants games

[12:00:59 CDT(-0500)] <Patty_> ha

[12:01:13 CDT(-0500)] <Patty_> thanks tony

[12:02:28 CDT(-0500)] <TonyUnicon> it is a bitter rivalry

[12:02:45 CDT(-0500)] <TonyUnicon> there is quite a number of cowboy fans in NY believe it or not

[12:03:00 CDT(-0500)] <TonyUnicon> before the home games, the sports radio station will plead with people not to sell their tickets to cowboy fans

[12:03:42 CDT(-0500)] <js70> but they still do. Those New Yorkers, always looking to make some sweet cash under the table.

[12:04:13 CDT(-0500)] <Patty_> that's funny

[12:04:58 CDT(-0500)] <TonyUnicon> its true

[12:15:02 CDT(-0500)] <dmccallum54> thought i had a journal issue

[12:15:09 CDT(-0500)] <dmccallum54> never been so happy to find out it's just crap data

[12:22:39 CDT(-0500)] <dmccallum54> 1704. sheesh.

[12:25:13 CDT(-0500)] <TonyUnicon> yep

[12:26:00 CDT(-0500)] <dmccallum54> you have to have a coach to show up in search? not just a student type?

[12:27:27 CDT(-0500)] <dmccallum54> i guess that kinda makes sense

[12:37:00 CDT(-0500)] <pspaude> Idk that is just what I found. Tony added studentTypeId != null and just checking the Dao I don't see much about coachId. Guess it was already in there or we got it for free

[12:43:15 CDT(-0500)] <TonyUnicon> ci linux acting funny for anyone?

[12:43:37 CDT(-0500)] <dmccallum54> my browser was waiting endlessly for the uP render response

[12:43:45 CDT(-0500)] <TonyUnicon> yep

[12:43:49 CDT(-0500)] <dmccallum54> closed my tab and opened a new one and it's happier now

[12:45:35 CDT(-0500)] <dmccallum54> this just flew by in the logs

[12:45:36 CDT(-0500)] <dmccallum54> https://gist.github.com/dmccallum/6392447

[12:47:23 CDT(-0500)] <pspaude> That was me I was trying to save a map with a course with humanities elective it failed spectacularly with a nice JSON error.

[12:47:44 CDT(-0500)] <pspaude> Switching to a different elective wasn't a problem.

[12:50:17 CDT(-0500)] <dmccallum54> um.

[12:50:41 CDT(-0500)] <dmccallum54> is there anything special about the humanities elective?

[12:51:14 CDT(-0500)] <pspaude> I don't know went back to admin and checked it, it appeared to be normal.

[12:51:59 CDT(-0500)] <pspaude> Now I edited it via the admin screen (just erasing and putting back the orig text) and its working fine.

[12:53:16 CDT(-0500)] <pspaude> Tried again and working fine for different user different plan(new plan).

[12:53:25 CDT(-0500)] <pspaude> Was that demo-data generated?

[12:53:35 CDT(-0500)] <pspaude> I thought I've used that elective before though.

[12:53:41 CDT(-0500)] <dmccallum54> seems unlikely b/c it's a UUID field

[12:56:38 CDT(-0500)] <pspaude> Do you think it as the color uuid?

[12:57:01 CDT(-0500)] <pspaude> Wait nope.

[13:04:06 CDT(-0500)] <TonyUnicon> https://issues.jasig.org/browse/SSP-1706 is a fun one

[13:04:17 CDT(-0500)] <dmccallum54> "fun"

[13:04:24 CDT(-0500)] <dmccallum54> you can reproduce now?

[13:04:29 CDT(-0500)] <TonyUnicon> yeah

[13:04:40 CDT(-0500)] <TonyUnicon> the cause is unfortunate

[13:05:13 CDT(-0500)] <TonyUnicon> will not be a simple fix

[13:06:05 CDT(-0500)] <TonyUnicon> the problem is

[13:06:30 CDT(-0500)] <TonyUnicon> we depend on the current state of currentMap instance

[13:06:38 CDT(-0500)] <TonyUnicon> when we send the print request

[13:06:53 CDT(-0500)] <TonyUnicon> the change detection stuff, tries to manage that

[13:06:58 CDT(-0500)] <TonyUnicon> the state that is

[13:07:14 CDT(-0500)] <TonyUnicon> and hilarity ensues

[13:07:23 CDT(-0500)] <dmccallum54> dont make my type more quotes

[13:07:33 CDT(-0500)] <TonyUnicon> hehe

[13:07:35 CDT(-0500)] <TonyUnicon> so the solution is

[13:07:40 CDT(-0500)] <TonyUnicon> to refresh the current map

[13:07:47 CDT(-0500)] <TonyUnicon> before we send the print request

[13:07:55 CDT(-0500)] <TonyUnicon> but that his potential impact on this change detection stuff

[13:07:58 CDT(-0500)] <TonyUnicon> so, hooray!

[13:11:35 CDT(-0500)] <TonyUnicon> probably the same issue with email i'd imagine

[13:35:30 CDT(-0500)] <TonyUnicon> k, think i got it

[13:43:50 CDT(-0500)] <TonyUnicon> in

[13:44:05 CDT(-0500)] <dmccallum54> rebuilding linux ci

[13:55:32 CDT(-0500)] <dmccallum54> Patty_ linux CI is available again if you want to check on 1706

[14:03:12 CDT(-0500)] <TonyUnicon> linux ci is locking up on me

[14:03:21 CDT(-0500)] <dmccallum54> John The Whiz Lucas is definitely my favorite test user

[14:04:04 CDT(-0500)] <TonyUnicon> ohh not fair at all

[14:04:22 CDT(-0500)] <TonyUnicon> need to create a Gene Roddenberry user

[14:09:13 CDT(-0500)] <dmccallum54> pspaude how's your testing looking?

[14:09:41 CDT(-0500)] <TonyUnicon> the fix looks good to me

[14:09:48 CDT(-0500)] <TonyUnicon> printing fix that is

[14:10:52 CDT(-0500)] <pspaude> Looking pretty good. Done with IE10 smoke test of whole app. Going back to IE8 in sec. Finishing JSLint now, nothing there so far almost done. I tested search, caseload, and admin pretty good. I will probably step up the level here in IE8 to finish it off.

[14:11:01 CDT(-0500)] <dmccallum54> EAs are looking good

[14:11:10 CDT(-0500)] <dmccallum54> about to go pound through reports really quickly

[14:16:16 CDT(-0500)] <dmccallum54> oops

[14:16:19 CDT(-0500)] <dmccallum54> last report blows up

[14:16:21 CDT(-0500)] <dmccallum54> of course

[14:16:39 CDT(-0500)] <pspaude> Tsk Tsk Oauth2ClientAdminViewController trailing comma not legal

[14:16:46 CDT(-0500)] <dmccallum54> DAMMIT

[14:19:37 CDT(-0500)] <dmccallum54> TonyUnicon SSP-1710

[14:22:48 CDT(-0500)] <TonyUnicon> may need help with this one

[14:23:02 CDT(-0500)] <TonyUnicon> i think its originating from the jasper report itself

[14:23:14 CDT(-0500)] <dmccallum541> k. looking.

[14:24:48 CDT(-0500)] <Patty_> I'm done with my calls and back at testing

[14:24:55 CDT(-0500)] <Patty_> tested ssp1706

[14:25:01 CDT(-0500)] <Patty_> looks good

[14:25:20 CDT(-0500)] <dmccallum541> TonyUnicon 1710 is in Hib before we get to jasper

[14:25:26 CDT(-0500)] <dmccallum541> not happening locally, of course.

[14:25:29 CDT(-0500)] <dmccallum541> still looking...

[14:27:40 CDT(-0500)] <TonyUnicon> looks like its bad data

[14:27:47 CDT(-0500)] <dmccallum541> indeed it does

[14:28:41 CDT(-0500)] <Patty_> probably should know this

[14:28:46 CDT(-0500)] <Patty_> what does the check box

[14:28:51 CDT(-0500)] <Patty_> to the left of an action item do?

[14:29:28 CDT(-0500)] <TonyUnicon> not sure I follow

[14:29:35 CDT(-0500)] <TonyUnicon> what particular screen?

[14:29:41 CDT(-0500)] <Patty_> if you are looking at any student

[14:29:44 CDT(-0500)] <Patty_> in the action plan too

[14:29:46 CDT(-0500)] <Patty_> that has a task

[14:29:49 CDT(-0500)] <Patty_> there is a check box

[14:29:57 CDT(-0500)] <Patty_> you can check or uncheck

[14:30:46 CDT(-0500)] <TonyUnicon> ...

[14:30:56 CDT(-0500)] <TonyUnicon> I have no idea actually

[14:30:57 CDT(-0500)] <pspaude> It allows you to print (and email?) only that task I believe

[14:30:57 CDT(-0500)] <Patty_> but I don't know what it does

[14:31:22 CDT(-0500)] <pspaude> So you dont' see the rest in the generated pdf

[14:31:31 CDT(-0500)] <dmccallum541> it links you to starfish i think

[14:31:41 CDT(-0500)] <Patty_> ha ha dan

[14:31:43 CDT(-0500)] <pspaude> Its unlabelled just for Dan

[14:31:57 CDT(-0500)] <dmccallum541> grrrr

[14:32:09 CDT(-0500)] <Patty_> tony's the winner

[14:32:14 CDT(-0500)] <Patty_> winner winner, chicken dinner

[14:32:16 CDT(-0500)] <TonyUnicon> haha

[14:34:07 CDT(-0500)] <pspaude> Did you want me to write up a ticket for it? Probably should at least add a on-hover

[14:34:21 CDT(-0500)] <dmccallum541> ticket is good. wont work it for 2.0.0

[14:34:55 CDT(-0500)] <pspaude> Yeah I didn't think for 2.0.0. Just in general cause that UI is cramped.

[14:35:10 CDT(-0500)] <dmccallum541> that's our look

[14:35:29 CDT(-0500)] <pspaude> Patentable like rounded corners?

[14:35:45 CDT(-0500)] <dmccallum541> was insufficiently unique

[14:35:51 CDT(-0500)] <dmccallum541> so we're working on cramped and slow

[14:43:32 CDT(-0500)] <dmccallum541> man.

[14:43:33 CDT(-0500)] <dmccallum541> obama should just ship a pile of SSP report PDFs over to syria

[14:43:33 CDT(-0500)] <dmccallum541> the fighting would stop immediately

[14:43:33 CDT(-0500)] <dmccallum541> what with all the eye-bleeding

[14:44:38 CDT(-0500)] <TonyUnicon> that violates the geneva conventions I think as cruel and unusual

[14:48:19 CDT(-0500)] <TonyUnicon> Patty_ were you able to find anything else?

[14:49:47 CDT(-0500)] <Patty_> I'm getting that file document upload error again

[14:49:58 CDT(-0500)] <dmccallum541> open a ticket with the file pls

[14:50:08 CDT(-0500)] <dmccallum541> i'll take it

[14:50:42 CDT(-0500)] <Patty_> pdfs work fine

[14:51:00 CDT(-0500)] <dmccallum541> pls open a ticket with the same file you're using. dont change the name or anything

[14:55:39 CDT(-0500)] <TonyUnicon> going off line to run some errands, I'll check back in case another fire sparks up in about an hour

[14:57:40 CDT(-0500)] <dmccallum541> dude. patty_

[14:57:51 CDT(-0500)] <dmccallum541> erorr message

[14:57:57 CDT(-0500)] <dmccallum541> File type not accepted. Please try one of these types: [doc, docx, gif, jpeg, jpg, pdf, png, xls]

[14:58:25 CDT(-0500)] <dmccallum541> i can add xslx to the default list

[14:59:30 CDT(-0500)] <Patty_> seems like xslx should be supported

[14:59:31 CDT(-0500)] <Patty_>

[15:00:51 CDT(-0500)] <Patty_> alright

[15:00:53 CDT(-0500)] <dmccallum541> alright

[15:00:54 CDT(-0500)] <Patty_> I got nothing else

[15:01:09 CDT(-0500)] <dmccallum541> i pushed a commit to add that to the defaults

[15:01:18 CDT(-0500)] <dmccallum541> also pushed a commit with a minor change to a log msg

[15:01:32 CDT(-0500)] <dmccallum541> pspaude can i do one more build?

[15:01:56 CDT(-0500)] <pspaude> please getting ready to test in IE8 and finish everything off

[15:02:28 CDT(-0500)] <dmccallum541> building...

[15:10:28 CDT(-0500)] <dmccallum541> it's back

[15:12:10 CDT(-0500)] <dmccallum541> your upload works patty

[15:12:37 CDT(-0500)] <Patty_> thanks dan

[15:12:46 CDT(-0500)] <Patty_> do we need to do another round of smoke testing?

[15:12:50 CDT(-0500)] <dmccallum541> yes

[15:15:49 CDT(-0500)] <dmccallum541> opened https://issues.jasig.org/browse/SSP-1713

[15:16:02 CDT(-0500)] <dmccallum541> dont think whatever the fix is will be simple enough for 2.0

[15:16:54 CDT(-0500)] <pspaude> Simple fix... don't use slow wifi. Problem solved.

[15:17:05 CDT(-0500)] <dmccallum541> you're just a straight shooter...

[15:18:07 CDT(-0500)] <pspaude> SSP Specs: WIFI N+, if Celluar 4g not in a moving vehicle. Wired 100gbs, Recommended Fiber. If using sattelite forget it.

[15:18:27 CDT(-0500)] <dmccallum541> …followed by a link to starfish

[15:18:31 CDT(-0500)] <pspaude> haha

[15:19:08 CDT(-0500)] <dmccallum541> brb

[15:34:18 CDT(-0500)] <dmccallum54> alright

[15:34:28 CDT(-0500)] <dmccallum54> i ran through 1696 again and looks OK

[15:34:29 CDT(-0500)] <dmccallum54> so i

[15:34:35 CDT(-0500)] <dmccallum54> so i am hands off CI

[15:34:47 CDT(-0500)] <Patty_> ok

[15:34:50 CDT(-0500)] <Patty_> I'm running through again

[15:34:57 CDT(-0500)] <dmccallum54> pspaude or Patty_ unless you find anything else i'll release at COB

[15:35:45 CDT(-0500)] <pspaude> Alright seems good. I'm actually bored in IE8 which is a good thing. Only thing I"m creating an issue now is Early Alert portlet course roster doesn't show in IE8 only.

[15:36:16 CDT(-0500)] <pspaude> Seems related to the issue with the SSP permissions we had in uPortal in IE.

[15:37:03 CDT(-0500)] <dmccallum54> think that's going to have to wait too unless you have an unbelievably trivial fix

[15:37:16 CDT(-0500)] <dmccallum54> esp given how long it takes to test ANYTHING in uP

[15:38:50 CDT(-0500)] <pspaude> No I can't do it by the end of cob and guarantee it doesn't break something else. Especially since that code is a bit different than the uP permissions stuff.

[15:39:49 CDT(-0500)] <dmccallum54> think the only reason IE8 is even on our radar at all is that's what Sinclair advisors use

[15:39:59 CDT(-0500)] <dmccallum54> dont think faculty are necessarily stuck in the same situation

[15:41:56 CDT(-0500)] <pspaude> Yeah, we'll see what Jason wants with it. I'm just hoping/betting its that same id issue that is an easy fix, probably because it was directly copied or used the same methods to create those tables for course roster as uP permissions did. Which means its like 10min + 1hr to test

[15:45:33 CDT(-0500)] <js70> what a lively bunch… reminds me of back in the day. I was hip once too you know.

[15:47:06 CDT(-0500)] <Patty_> I'm done testing

[15:47:09 CDT(-0500)] <Patty_> looks good

[15:48:53 CDT(-0500)] <pspaude> Looks good to me too. How far do you want me to take the admin/caseload/search. I've checked basic and advanced functionality and the few edge cases we know about in caseload. Anything else?

[15:49:14 CDT(-0500)] <dmccallum54> that's probably fine

[15:49:17 CDT(-0500)] <dmccallum54> here's something interesting

[15:49:25 CDT(-0500)] <dmccallum54> related to your issue with electives today

[15:49:30 CDT(-0500)] <dmccallum54> testing a MAP locally

[15:50:08 CDT(-0500)] <dmccallum54> and when i added a course that's not offered in the current term, it looks like the courseDescription field gets clobbered

[15:50:22 CDT(-0500)] <dmccallum54> courseTitle: "Integrative Aerospace",

[15:50:23 CDT(-0500)] <dmccallum54> courseDescription: " Course: AES156 is not currently offered in the selected term.",

[15:51:28 CDT(-0500)] <dmccallum54> also semi-interestingly, see the leading space? in the humanities case there was a trailing space

[15:51:41 CDT(-0500)] <dmccallum54> wonder if something similar is afoot that's copying error messages into the wrong fields

[15:53:14 CDT(-0500)] <pspaude> Wow yeah sounds like it. I had a course not offered but it was in a different term. So I did get the popup before I added valid courses into a valid term and put the humanities elective on one.

[15:53:30 CDT(-0500)] <dmccallum54> mind poking around a bit more on that issue pls?

[15:55:34 CDT(-0500)] <pspaude> Yeah I've tried and I'll continue.

[15:57:48 CDT(-0500)] <dmccallum54> thx

[15:58:38 CDT(-0500)] <pspaude> np Still not seeing the overwrite and can't reproduce the original issue. I'll go back to my local here in a bit and see.

[16:17:48 CDT(-0500)] <TonyUnicon> back

[16:19:09 CDT(-0500)] <dmccallum541> cool

[16:19:23 CDT(-0500)] <dmccallum541> currently looking at https://issues.jasig.org/browse/SSP-1715 to see if there's anything more serious going on

[16:20:07 CDT(-0500)] <dmccallum541> and

[16:20:10 CDT(-0500)] <dmccallum541> what's up with this

[16:20:10 CDT(-0500)] <dmccallum541> @PreAuthorize("hasRole('ROLE_PERSON_MAP_WRITE')")

[16:20:11 CDT(-0500)] <dmccallum541> @RequestMapping(value = "/planstatus", method = RequestMethod.POST)

[16:20:11 CDT(-0500)] <dmccallum541> public @ResponseBody

[16:20:11 CDT(-0500)] <dmccallum541> ExternalPersonPlanStatusTO getPlanStatus(final HttpServletResponse response,

[16:20:11 CDT(-0500)] <dmccallum541> @PathVariable final UUID personId)

[16:20:11 CDT(-0500)] <dmccallum541> throws ObjectNotFoundException {

[16:20:25 CDT(-0500)] <dmccallum541> why a post and why do you have to have write permissions?

[16:22:43 CDT(-0500)] <TonyUnicon> i was not the original author of that code

[16:22:50 CDT(-0500)] <dmccallum541> so i see

[16:22:54 CDT(-0500)] <dmccallum541> js70 any recollections?

[16:24:13 CDT(-0500)] <js70> I was

[16:24:39 CDT(-0500)] <js70> there was a reason. it escapes me at the momen.

[16:24:45 CDT(-0500)] <dmccallum541> ok

[16:24:54 CDT(-0500)] <js70> let me take a look.

[16:28:22 CDT(-0500)] <js70> looking at the code there is no good reason.

[16:29:36 CDT(-0500)] <js70> for some reason, I think I got the status through a different method and just never fixed it.

[16:29:49 CDT(-0500)] <dmccallum541> k

[16:30:02 CDT(-0500)] <dmccallum541> we're still hitting that thing with a POST from the UI whenever loading a plan

[16:31:10 CDT(-0500)] <js70> not sure why we need ROLE_PERSON_MAP_WRITE either.

[16:31:46 CDT(-0500)] <dmccallum541> https://issues.jasig.org/browse/SSP-1715

[16:32:07 CDT(-0500)] <dmccallum541> how about that one? just something we have to live with in order for rule violation tool tips to work?

[16:32:37 CDT(-0500)] <dmccallum541> i'm going to fix 1716 b/c i think that's a landmine if someone actually tries to make use of the read/write MAP permissions distinction

[16:33:08 CDT(-0500)] <js70> saw you working on that earlier. I really don't remember using courseDesctiptions for the error code.

[16:33:20 CDT(-0500)] <js70> I have invalidReasons for that.

[16:33:28 CDT(-0500)] <js70> not sure where its getting clobbered

[16:35:31 CDT(-0500)] <js70> invalidReasons should not be saved, it is a transient value in TO only

[16:36:48 CDT(-0500)] <dmccallum541> there it is

[16:36:51 CDT(-0500)] <dmccallum541> SemesterCourse.js

[16:37:12 CDT(-0500)] <dmccallum541> if(planCourse.invalidReasons)

[16:37:13 CDT(-0500)] <dmccallum541> me.set('description', planCourse.invalidReasons);

[16:37:24 CDT(-0500)] <dmccallum541> does it have to be that way for tool tips to work?

[16:37:36 CDT(-0500)] <dmccallum541> i can test it, but you might remember

[16:39:11 CDT(-0500)] <js70> doesn't have to work that way. I probably went to fast on that one. would need a some work on the code generating the tooltip.

[16:39:23 CDT(-0500)] <dmccallum541> k

[16:43:00 CDT(-0500)] <js70> looks like it will work if you just get rid of that descriptiion set.

[16:43:02 CDT(-0500)] <js70> record.get("invalidReasons")

[16:43:09 CDT(-0500)] <js70> metaData.tdAttr = 'data-qtip="Concerns:' + record.get("invalidReasons") + '"';

[16:43:09 CDT(-0500)] <dmccallum541> yeah. just saw that

[16:43:32 CDT(-0500)] <dmccallum541> k. so i think that leaves https://issues.jasig.org/browse/SSP-1708 as the most serious unexplained issue so far

[16:43:55 CDT(-0500)] <pspaude> Yeah, put all the pressure on me

[16:44:02 CDT(-0500)] <pspaude> Still have reproduced it.

[16:44:06 CDT(-0500)] <dmccallum541> me neither

[16:44:07 CDT(-0500)] <pspaude> *haven't

[16:45:20 CDT(-0500)] <js70> if you don't need me, I'll just go back to being a script kiddie.

[16:45:38 CDT(-0500)] <dmccallum541> js70 thanks. back to the groovy with you

[16:49:09 CDT(-0500)] <pspaude> I've added spaces to the actual name adn lots of other stuff. I don't know how it was trying to read that name as a UUID.

[16:49:47 CDT(-0500)] <dmccallum541> i doubt it was the spaces in the actual name

[16:50:08 CDT(-0500)] <dmccallum541> some cocktail of clicks is copying the wrong value into whatever is being used to hold the elective reference client side

[16:51:19 CDT(-0500)] <pspaude> haha yeah. I've tried reproducing my exact steps, I remember them pretty well, and no dice.

[16:52:40 CDT(-0500)] <dmccallum541> stop doing it right, paul

[16:52:45 CDT(-0500)] <pspaude> I added a wrong course with a prereq to fall2013. Then filtered on terms for winter2013 and added all valid terms into winter 2013. I don't rmbr the exact count >7. Then I clicked one forgot which one, and filled out all data including adding that elective. I messed up and forgot term, so I did plan notes at that time, then I went back to winter 2013 and added term notes. I saved the plan and bam! JSON error.

[16:52:49 CDT(-0500)] <dmccallum541> do it wrong. do it wrong.

[16:53:39 CDT(-0500)] <pspaude> that's the problem I"ve tried right and wrong and in between. I'm going to the random click method

[16:59:05 CDT(-0500)] <pspaude> Dan I noticed in the JSON sent that course description: " " has varying amounts of whitespace on the same unchanged course with notes. I've modified a plan 3x and each time its been different values. Could that be the issue? I'll check into the code in a sec.

[16:59:17 CDT(-0500)] <pspaude> Also I see one course here has ":" as the course description.

[17:00:27 CDT(-0500)] <pspaude> Wait sorry about that last one that was part of the error message being put into the course description.

[17:00:30 CDT(-0500)] <dmccallum541> yeah, i dont know what's going on with that

[17:01:04 CDT(-0500)] <dmccallum541> just pushed fixes for SSP-1715 and SSP-1716

[17:03:00 CDT(-0500)] <pspaude> Cool I'll take them and rebuild and see if it comes back.

[17:03:53 CDT(-0500)] <dmccallum541> kicking off CI build in a sec

[17:04:10 CDT(-0500)] <dmccallum541> fixing up some license headers...

[17:13:03 CDT(-0500)] <pspaude> Looks like that fixed the course description issue.

[17:13:22 CDT(-0500)] <dmccallum541> ok

[17:13:32 CDT(-0500)] <dmccallum541> still haven't built CI

[17:13:43 CDT(-0500)] <dmccallum541> trying to run the famous ControllerSecurityTest

[17:14:00 CDT(-0500)] <dmccallum541> tests of course are a bitch to get to run at all

[17:14:42 CDT(-0500)] <pspaude> Need to give linux CI some SSD in RAID0 .

[17:30:36 CDT(-0500)] <dmccallum541> linux CI building

[17:34:51 CDT(-0500)] <pspaude> Hey do we need to take out the beta thing over the SSP label in the left corner? Or is this a general release beta?

[17:35:32 CDT(-0500)] <dmccallum541> i'm going to leave it alone

[17:35:41 CDT(-0500)] <dmccallum541> b/c it's always rebranded on actual install

[17:35:47 CDT(-0500)] <dmccallum541> but good point

[17:36:00 CDT(-0500)] <pspaude> Ah ok, they usualy put the school's log right?

[17:36:04 CDT(-0500)] <dmccallum541> right

[17:41:16 CDT(-0500)] <dmccallum541> alright. looks good

[17:41:56 CDT(-0500)] <pspaude> Haha like your last git commit title

[17:42:36 CDT(-0500)] <dmccallum541> alright. i think it's time to call it

[17:42:39 CDT(-0500)] <dmccallum541> any objections?

[17:42:50 CDT(-0500)] <dmccallum541> for those who care...

[17:43:00 CDT(-0500)] <pspaude> Nope just thinking evil thoughts of modifying the json myself to reproduce the error just so I could say I reproduced it.

[17:43:12 CDT(-0500)] <dmccallum541> i'm going to be a bad git citizen and pick up our rel-2-0-patches branch so it points at master

[17:43:39 CDT(-0500)] <dmccallum541> i failed to plan ahead and merge master into that branch before this last big push

[17:44:18 CDT(-0500)] <dmccallum541> but since noone is likely to have interesting downstream forks with their own branches of rel-2-0-patches, i think we'll be OK. and better a little pain there then release something we didn't actually test

[17:45:06 CDT(-0500)] <dmccallum541> ok. going to step away momentarily then begin the release proper

[17:45:26 CDT(-0500)] <dmccallum541> pls email me if you find a serious issue between now and then

[17:45:49 CDT(-0500)] <pspaude> Alright sounds good.

[17:46:46 CDT(-0500)] <Patty__> call it

[17:46:47 CDT(-0500)] <Patty__> and paul

[17:46:57 CDT(-0500)] <Patty__> I need your help tuesday am

[17:46:57 CDT(-0500)] <pspaude> Yeah

[17:47:02 CDT(-0500)] <Patty__> to help prep the unicon demo site

[17:47:13 CDT(-0500)] <pspaude> Ok what time?

[17:47:14 CDT(-0500)] <Patty__> for this california community college demo on wednesday

[17:47:19 CDT(-0500)] <Patty__> I'll schedule a quick meeting

[17:47:24 CDT(-0500)] <Patty__> for us to catch-up

[17:47:31 CDT(-0500)] <Patty__> seems like there is alot to do

[17:49:31 CDT(-0500)] <pspaude> Cool no problem.

[17:49:39 CDT(-0500)] <Patty__> ok

[17:49:40 CDT(-0500)] <Patty__> thanks

[17:50:15 CDT(-0500)] <pspaude> Alright I see it now. I'm guessing it involves making some interesting pre-populated data?

[17:50:27 CDT(-0500)] <Patty__> yes

[17:50:34 CDT(-0500)] <Patty__> I need to strip out the admin stuff

[17:50:37 CDT(-0500)] <Patty__> in the unicon site

[17:50:47 CDT(-0500)] <Patty__> vicky will upgrade

[17:50:48 CDT(-0500)] <Patty__> and then

[17:50:54 CDT(-0500)] <Patty__> re-add the admin stuff

[17:51:02 CDT(-0500)] <Patty__> and manipulate some student records

[17:51:32 CDT(-0500)] <pspaude> Ok sounds invovled but not too bad depending on what all needs to be done.

[17:52:04 CDT(-0500)] <Patty__> so the supporting data just isn't consistent

[17:52:11 CDT(-0500)] <Patty__> for example, gpa is 2.0

[17:52:16 CDT(-0500)] <Patty__> and then you look at the transcript

[17:52:20 CDT(-0500)] <Patty__> and it is a's and b's

[17:52:24 CDT(-0500)] <Patty__> just stuff like that

[17:52:36 CDT(-0500)] <Patty__> and that's because we scripted that dat

[17:52:37 CDT(-0500)] <Patty__> data

[17:52:48 CDT(-0500)] <Patty__> and didn't take it from a true sis

[17:53:13 CDT(-0500)] <pspaude> GPA drops like a rock though when you get those B's and C's and I've seen where a D or F can put you in the 2.5 with all the rest at A's and B's.

[17:53:48 CDT(-0500)] <Patty__> right.. .just on the site it isn't consistent so we want to update 3 different student records

[17:53:55 CDT(-0500)] <Patty__> to show 3 different student stories

[17:54:01 CDT(-0500)] <Patty__> we'll chat on tuesday

[17:54:05 CDT(-0500)] <pspaude> Hard to maintain GPA at the top or get higher when you are near the top. Ask me how I know.

[17:54:23 CDT(-0500)] <Patty__> ha

[17:54:24 CDT(-0500)] <pspaude> Yeah that sounds good mix it up and such. No problem.

[18:07:01 CDT(-0500)] <dmccallum54> release is starting

[18:07:12 CDT(-0500)] <Patty__> drum roll