uPortal IRC Logs-2012-12-18

Owned by Apereo Infrastructure
Last updated: Dec 18, 2012

[16:34:41 CST(-0600)] <jwennmacher> EricDalquist: I just submitted https://github.com/Jasig/uPortal/pull/100 for the Tab Render report.

[16:35:05 CST(-0600)] <EricDalquist> awesome

[16:35:07 CST(-0600)] <EricDalquist> just saw that

[16:35:17 CST(-0600)] <EricDalquist> it will probably take a day or two for me to fully review it

[16:35:28 CST(-0600)] <EricDalquist> we're interviewing right now so thats a big chunk of time gone (tongue)

[16:36:59 CST(-0600)] <jwennmacher> I understand completely. I might have time to look into doing a portlet execution report before I head out on vacation, though it would build upon pull 100 so I'm hesitant to do it now in case you have a few thoughts on the implementation of the Tab Render report.

[16:37:11 CST(-0600)] <EricDalquist> ok

[16:37:28 CST(-0600)] <EricDalquist> I'll do my best to get you feedback tomorrow afternoon (smile)

[16:37:44 CST(-0600)] <jwennmacher> No worries (smile). I have some other work I can do right now so I'll focus on that for a while.

[16:37:50 CST(-0600)] <EricDalquist> sounds good

[16:47:08 CST(-0600)] <jwennmacher> I held off on getting translating the strings in AggregatedTabMapping (e.g. CATCH_ALL_PERSONAL_TAB_OWNER, etc.) from values in message.properties.

[16:47:21 CST(-0600)] <jwennmacher> I had a solution that sort of worked (add a static MessageSource property to AggregatedTabMappingImpl so its getDisplayName method could return alternate values for the static strings), but you didn't have access to the Locale (breaks internationalization) and required creating a 'junk' AggregatedTabMappingImpl bean just to set the static MessageSource property. If there is a better way I'm open to considering it.

[16:48:23 CST(-0600)] <jwennmacher> I didn't like having the TabRenderStatisticsController massaging the strings to display.

[16:48:52 CST(-0600)] <jwennmacher> I think obtaining the values from message.properties is pretty minor.