Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 51 Next »

[07:59:10 CDT(-0500)] <TonyUnicon> have not been able to launch ssp since I pulled down this morning

[10:25:49 CDT(-0500)] <dmccallum54> TonyUnicon still blowing up on you?

[10:25:51 CDT(-0500)] <dmccallum54> blows up for me

[10:26:10 CDT(-0500)] <dmccallum54> think it's b/c SemesterPanelViewController.js actually defines Ssp.controller.tool.map.MAPViewController

[10:27:19 CDT(-0500)] <TonyUnicon> yeah

[10:27:22 CDT(-0500)] <TonyUnicon> working with Jim

[10:27:40 CDT(-0500)] <dmccallum54> k

[10:27:42 CDT(-0500)] <TonyUnicon> i rolled back to a previous commit and I was fine once I realized what it was

[10:27:44 CDT(-0500)] <dmccallum54> i have a patch

[10:27:55 CDT(-0500)] <dmccallum54> you guys want it or you found bigger issues?

[10:27:59 CDT(-0500)] <TonyUnicon> I think Jim is testing his, you guys can duke it out

[10:28:03 CDT(-0500)] <dmccallum54> sweet

[10:28:09 CDT(-0500)] <dmccallum54> js70 i have a one liner.

[10:28:31 CDT(-0500)] <dmccallum54> i'll defer to you if you've founder bigger issues

[10:31:48 CDT(-0500)] <js70> k

[10:31:54 CDT(-0500)] <js70> I'm listening

[10:32:18 CDT(-0500)] <TonyUnicon> -Ext.define('Ssp.controller.tool.map.SemesterPanelViewController', {

[10:32:18 CDT(-0500)] <TonyUnicon> +Ext.define('Ssp.controller.tool.map.MAPViewController', {

[10:32:22 CDT(-0500)] <dmccallum54> yep

[10:32:26 CDT(-0500)] <TonyUnicon> in SemesterPanelViewController.js

[10:32:28 CDT(-0500)] <TonyUnicon> is the cause

[10:32:38 CDT(-0500)] <js70> thats hilarious.

[10:33:01 CDT(-0500)] <dmccallum54> well

[10:33:03 CDT(-0500)] <dmccallum54> actually

[10:33:06 CDT(-0500)] <js70> how does it even work?

[10:33:06 CDT(-0500)] <dmccallum54> i have that the other way around

[10:33:14 CDT(-0500)] <TonyUnicon> well that is the change

[10:33:18 CDT(-0500)] <TonyUnicon> that caused it

[10:33:20 CDT(-0500)] <TonyUnicon> not the solution

[10:33:23 CDT(-0500)] <TonyUnicon> the solution is the reverse

[10:33:26 CDT(-0500)] <dmccallum54> ah. yeha. right right

[10:33:29 CDT(-0500)] <dmccallum54> alright

[10:33:30 CDT(-0500)] <dmccallum54> pushing

[10:33:58 CDT(-0500)] <TonyUnicon> Dan do you have an opinion on the color coding stuff?

[10:36:46 CDT(-0500)] <dmccallum54> i looked at the screenshot

[10:36:50 CDT(-0500)] <dmccallum54> actually looked pretty nice to me

[10:38:01 CDT(-0500)] <TonyUnicon> yeah it's not bad, they just aren't squares

[10:39:43 CDT(-0500)] <TonyUnicon> an alternative I thought of was having a jpeg that was all 'alpha channel' that was a square and set the icon's background color but I have no idea if that will work

[10:41:14 CDT(-0500)] <dmccallum54> heh

[10:41:22 CDT(-0500)] <dmccallum54> my thought process was exactly the same (wink)

[10:41:45 CDT(-0500)] <dmccallum54> i'm definitely not married to "squares" per se

[10:42:05 CDT(-0500)] <TonyUnicon> ok

[10:42:09 CDT(-0500)] <dmccallum54> semantically i think we're accomplishing what the design was trying to do

[10:42:38 CDT(-0500)] <TonyUnicon> yes and I think squares might even take away from the visual cue

[10:44:58 CDT(-0500)] <js70> do have room on the ui to widen the gird, its going to get pretty crowded in there. How are you handling giving feed back is to what each column of colors is representing?

[10:45:18 CDT(-0500)] <js70> might be nice as a rollover time for the panel itself.

[10:46:01 CDT(-0500)] <TonyUnicon> I have custom column renders where I override the css meta data of the cell

[10:46:18 CDT(-0500)] <TonyUnicon> it is crowded and will be an issue with courses with long names

[10:46:29 CDT(-0500)] <TonyUnicon> widening the semester panels is of course possible

[10:46:42 CDT(-0500)] <TonyUnicon> but we might run into a horizontal real estate issue

[10:46:58 CDT(-0500)] <TonyUnicon> if a school has 4+ terms per school year

[10:47:13 CDT(-0500)] <TonyUnicon> but that might be more acceptable than clipping the course name

[10:48:48 CDT(-0500)] <TonyUnicon> we can also just show the course code rather than the formatted course value

[10:49:08 CDT(-0500)] <TonyUnicon> than we can get a relative guarantee that the string will be short

[10:49:59 CDT(-0500)] <TonyUnicon> feedback as to what they represent would be a tooltip I'm guessing

[10:51:36 CDT(-0500)] <dmccallum54> i had assumed tooltips for the "legend", yeah

[10:53:51 CDT(-0500)] <JasonElwood> I think I'm joining in on the color discussion

[10:54:05 CDT(-0500)] <TonyUnicon> yeah

[10:54:12 CDT(-0500)] <TonyUnicon> your feedback is appreciated

[10:54:22 CDT(-0500)] <JasonElwood> on the planned courses, we want to show formatted course, not course code. they may be different, and the course code may be human unreadable

[10:54:36 CDT(-0500)] <JasonElwood> I am good with the color rendering and a tooltip explanation

[10:55:03 CDT(-0500)] <JasonElwood> my only question was about order. would there be a set order by column with meaning, or do they render left to right based on what is available?

[10:55:19 CDT(-0500)] <TonyUnicon> I think the positions of the colors should be static

[10:55:27 CDT(-0500)] <JasonElwood> good

[10:55:27 CDT(-0500)] <TonyUnicon> and if they are unavailable they would just have no color

[10:55:34 CDT(-0500)] <JasonElwood> perfect

[10:55:40 CDT(-0500)] <TonyUnicon> so the question is

[10:55:51 CDT(-0500)] <TonyUnicon> if it ok to widen the term panels

[10:56:05 CDT(-0500)] <TonyUnicon> and risk a situation

[10:56:22 CDT(-0500)] <TonyUnicon> where we run out of horizontal space

[10:56:31 CDT(-0500)] <TonyUnicon> and that big panel than has a scroll bar (bonus!)

[10:56:44 CDT(-0500)] <TonyUnicon> but than we would have more room

[10:56:47 CDT(-0500)] <TonyUnicon> to render formatted course

[10:57:03 CDT(-0500)] <TonyUnicon> than=then

[10:57:10 CDT(-0500)] <JasonElwood> if we can get a scroll bar under the colors and the horizontal, that would be ideal

[10:57:50 CDT(-0500)] <TonyUnicon> do you mean the term panels? a horizontal scroll back on that?

[10:57:51 CDT(-0500)] <dmccallum54> it's a wasted day for doug if he can't open at least one 'too many scrollbars' ticket

[10:58:21 CDT(-0500)] <TonyUnicon> I think that would result in a less clean look

[10:58:39 CDT(-0500)] <TonyUnicon> because

[10:58:53 CDT(-0500)] <JasonElwood> it's like he has the issue description in the clipboard ready to paste

[10:59:02 CDT(-0500)] <JasonElwood> I was messing. no more scroll bars

[10:59:02 CDT(-0500)] <TonyUnicon> you have the possibility of a very different presentation depending on terms rendering courses with long names

[11:00:00 CDT(-0500)] <JasonElwood> if the column color approach works, would the elective code not be rendered and only viewable through the tooltip/color display?

[11:00:33 CDT(-0500)] <TonyUnicon> not if I make the elective code a dedicated column, it won't get clipped

[11:00:43 CDT(-0500)] <TonyUnicon> if I included it as part of the formatted course display than it can get clipped

[11:00:51 CDT(-0500)] <TonyUnicon> but as a dedicated column

[11:01:01 CDT(-0500)] <TonyUnicon> it leaves less room for the formatted course name

[11:01:43 CDT(-0500)] <JasonElwood> I'm ok not showing the code, just asking to see how much room we might have left

[11:02:45 CDT(-0500)] <TonyUnicon> not much, one thing we can do is maybe move the 'details' functionality as a double click on the row

[11:03:02 CDT(-0500)] <TonyUnicon> and find some other way to allow them to remove courses from the panel

[11:03:12 CDT(-0500)] <TonyUnicon> get those noisey action icons out of the rows

[11:06:58 CDT(-0500)] <JasonElwood> I think the only other place we double click to open is available courses

[11:08:02 CDT(-0500)] <dmccallum54> there's a few other places elsewhere in the app

[11:08:16 CDT(-0500)] <dmccallum54> i think that's how you see EA response details?

[11:08:29 CDT(-0500)] <JasonElwood> I could go for double click to edit. could you drag out to delete?

[11:08:43 CDT(-0500)] <JasonElwood> or on edit

[11:09:11 CDT(-0500)] <dmccallum54> drag out seems like a pain

[11:09:22 CDT(-0500)] <dmccallum54> flyout menus!

[11:10:09 CDT(-0500)] <JasonElwood> if we have to make a decision about what stays, the color rendering is more important to see and would be used more than the edit and delete buttons

[11:10:19 CDT(-0500)] <TonyUnicon> a button on the top bar

[11:10:27 CDT(-0500)] <TonyUnicon> on term panel

[11:10:41 CDT(-0500)] <TonyUnicon> that will delete selected record in the term

[11:11:57 CDT(-0500)] <JasonElwood> what color would the button be?

[11:12:33 CDT(-0500)] <JasonElwood> I would be good with the double-click approach

[11:12:47 CDT(-0500)] <TonyUnicon> we can use the same red X icon

[11:12:59 CDT(-0500)] <TonyUnicon> or a simple a button that says 'Delete'

[11:13:24 CDT(-0500)] <js70> May be a bit confusing since we have term notes icon up there as well. implies you will be deleting the whole panel?

[11:13:57 CDT(-0500)] <TonyUnicon> it may be confusing the first time you use it

[11:14:07 CDT(-0500)] <JasonElwood> agreed. let's stick with double clicking. that follows the behavior of available courses

[11:14:20 CDT(-0500)] <TonyUnicon> for edit

[11:14:30 CDT(-0500)] <JasonElwood> for both

[11:14:30 CDT(-0500)] <TonyUnicon> and for delete?

[11:14:42 CDT(-0500)] <js70> Personally, I like the double click because we are seeing some consistency in the ui.

[11:15:26 CDT(-0500)] <js70> Good point tony

[11:15:31 CDT(-0500)] <TonyUnicon> where else do we double click to delete?

[11:15:39 CDT(-0500)] <js70> we are trying to do a lot in a little space.

[11:16:14 CDT(-0500)] <JasonElwood> double click to show details. editing the hours and elective along with a button(your choice on color) to remove the course

[11:16:59 CDT(-0500)] <TonyUnicon> right, but do we do that elsewhere?

[11:17:20 CDT(-0500)] <TonyUnicon> we do have delete buttons for removing selections elwhere

[11:18:39 CDT(-0500)] <JasonElwood> I'm all for consistency, probably OCD about it. but I think we have buttons to delete inside the details of a particular record or a list. in this case, we show that button for each record. and it's clutter

[11:19:07 CDT(-0500)] <TonyUnicon> I ask because it may be difficult to actually do that from a 'details' context

[11:19:18 CDT(-0500)] <TonyUnicon> and if we have an example of that somewhere

[11:19:35 CDT(-0500)] <TonyUnicon> it would ease my anxiety about actually doing that

[11:19:44 CDT(-0500)] <JasonElwood> I don't think we do

[11:19:55 CDT(-0500)] <JasonElwood> just the select a record in a list to delete

[11:20:02 CDT(-0500)] <TonyUnicon> yeah

[11:21:00 CDT(-0500)] <TonyUnicon> in which case a delete button at the top if consistent with what we have an easier to implement, it maybe slightly confusing at first but nothing a tooltip and some training can't fix

[11:21:04 CDT(-0500)] <TonyUnicon> if=is

[11:21:07 CDT(-0500)] <JasonElwood> if we took that approach, it could be a remove course button that is actually text

[11:21:22 CDT(-0500)] <TonyUnicon> right

[11:22:03 CDT(-0500)] <JasonElwood> maybe the pencil icon could be render right after the term name to show more of an association

[11:22:14 CDT(-0500)] <JasonElwood> then to the far right the remove course "button"

[11:22:59 CDT(-0500)] <TonyUnicon> yeah

[11:23:19 CDT(-0500)] <JasonElwood> and still double click to edit

[11:23:24 CDT(-0500)] <TonyUnicon> right

[11:23:43 CDT(-0500)] <JasonElwood> that is more consistent and a better design

[11:23:53 CDT(-0500)] <TonyUnicon> yep less visual noise

[11:25:10 CDT(-0500)] <TonyUnicon> I'll start to head in that direction then

[11:25:13 CDT(-0500)] <JasonElwood> Full agreement?

[11:25:26 CDT(-0500)] <TonyUnicon> aye

[11:26:02 CDT(-0500)] <JasonElwood> two is enough for me

[11:26:13 CDT(-0500)] <JasonElwood> good ideas everyone

[11:47:21 CDT(-0500)] <TonyUnicon> silly question

[11:47:47 CDT(-0500)] <TonyUnicon> how are course/elective associations stored?

[11:47:55 CDT(-0500)] <TonyUnicon> Are those associations internal or external data

[11:48:13 CDT(-0500)] <JasonElwood> internal

[11:48:40 CDT(-0500)] <TonyUnicon> what table? do you know

[11:48:53 CDT(-0500)] <dmccallum54> it's 1 to many right?

[11:49:07 CDT(-0500)] <dmccallum54> elective -> course

[11:49:21 CDT(-0500)] <dmccallum54> so would be a pointer from course to elective

[11:49:32 CDT(-0500)] <dmccallum54> map_plan_course, i mean

[11:49:39 CDT(-0500)] <TonyUnicon> yes for a map instance that is clear

[11:49:48 CDT(-0500)] <TonyUnicon> but the reference data that is suppose to populate that

[11:49:52 CDT(-0500)] <TonyUnicon> does not seem to exist

[11:50:04 CDT(-0500)] <JasonElwood> not for electives

[11:50:08 CDT(-0500)] <dmccallum54> dont think we have any default elective data

[11:50:22 CDT(-0500)] <JasonElwood> reference data is defined for tags, requisites and terms offered

[11:50:43 CDT(-0500)] <js70> tyler's lastest has reference data for electives

[11:50:49 CDT(-0500)] <TonyUnicon> the implementation details for elective reference data is murky

[11:51:01 CDT(-0500)] <TonyUnicon> as far as course/electives associations go

[11:52:23 CDT(-0500)] <TonyUnicon> oh never mind

[11:52:32 CDT(-0500)] <TonyUnicon> its selected in the details

[11:53:00 CDT(-0500)] <js70> yep

[11:53:09 CDT(-0500)] <js70> that's implemented as well

[11:53:38 CDT(-0500)] <TonyUnicon> sorry, i had the assumption that course - elective data was also populated from reference data

[11:55:01 CDT(-0500)] <TonyUnicon> in otherwords I thought the external data model might have had notion of these associations

[11:55:19 CDT(-0500)] <dmccallum54> ah. nope, not as far as i know

[11:56:20 CDT(-0500)] <TonyUnicon> meaning for new courses dropped there will never be an elective associated with it unless explicitly set

[11:56:44 CDT(-0500)] <TonyUnicon> will never have*

[11:57:17 CDT(-0500)] <dmccallum54> i think they mainly come into play when starting from a template

[11:57:39 CDT(-0500)] <TonyUnicon> ok

[11:57:46 CDT(-0500)] <TonyUnicon> sorry for the confusion

  • No labels