[08:32:34 CDT(-0500)] <TonyUnicon> Patty do you happen to have a login that works on the Win CI environment ?
[13:23:59 CDT(-0500)] <pspaude> Dan for file upload, does it block .exe.XXX for example? So users that hide executables? Or are we letting anything go. I can't remember from the previous discussion.
[13:24:32 CDT(-0500)] <dmccallum54> it does not block .exe.XXX
[13:25:06 CDT(-0500)] <pspaude> Ok cool. Thanks.
[13:25:08 CDT(-0500)] <dmccallum54> this is a bare minimum effort
[13:26:40 CDT(-0500)] <pspaude> Yeah technically the users are authenticated so its more of a org policy issue anyways.
[13:27:09 CDT(-0500)] <dmccallum54> checking file names would be a craptastic way to implement anything serious
[13:34:59 CDT(-0500)] <dmccallum54> actually, i wouldn't know where to even start on a wins box
[13:35:12 CDT(-0500)] <dmccallum54> i'm sure there's some sort of cross platform lib
[13:35:25 CDT(-0500)] <dmccallum54> but on *nix i think you'd just call out to 'file' on the shell
[14:14:21 CDT(-0500)] <dmccallum54> pspaude whatcha working on now?
[14:56:00 CDT(-0500)] <pspaude> Oops sorry didn't see that. Finishing up SSP-504 and finishing testing of SSP-1491 got a 404 in IE, but haven't seen it come back.
[14:56:13 CDT(-0500)] <pspaude> Saw the new issue 1688 looks pretty simple... hopefully
[17:44:24 CDT(-0500)] <dmccallum54> rebuilding linux ci to pick up the latest gps fix
[17:44:34 CDT(-0500)] <dmccallum54> will then bring it down again to add a backdoor to trigger sync
[17:46:03 CDT(-0500)] <JasonElwood> cool
[17:50:51 CDT(-0500)] <dmccallum54> which user shall we be testing with?
[17:51:01 CDT(-0500)] <dmccallum54> the GPS veteran status problem, i mean
[17:51:24 CDT(-0500)] <dmccallum54> how about… tmartin1944t
[17:51:30 CDT(-0500)] <JasonElwood> not sure. I never re-produced the problem
[17:52:41 CDT(-0500)] <JasonElwood> you just need a student with demo in external?
[17:52:51 CDT(-0500)] <dmccallum54> he's got demo data in external
[17:52:56 CDT(-0500)] <dmccallum54> he's who i reproduced with locally
[17:53:06 CDT(-0500)] <dmccallum54> he's out there in linux ci db too, i see
[17:53:23 CDT(-0500)] <dmccallum54> still starting up
[17:53:30 CDT(-0500)] <dmccallum54> will try with that user when it's all the way back
[17:54:47 CDT(-0500)] <JasonElwood> while we wait, have any opinion on pushing the release?
[17:54:55 CDT(-0500)] <dmccallum54> ugh
[17:55:16 CDT(-0500)] <dmccallum54> we kinda have to, eh
[17:55:25 CDT(-0500)] <JasonElwood> yep
[18:00:02 CDT(-0500)] <TonyUnicon> fingers crossed!
[18:00:03 CDT(-0500)] <TonyUnicon> 
[18:05:22 CDT(-0500)] <dmccallum54> ok. trying jwhite622t instead
[18:06:49 CDT(-0500)] <dmccallum54> aaaand… he has no intake task
[18:06:51 CDT(-0500)] <dmccallum54> sigh
[18:07:07 CDT(-0500)] <dmccallum54> because of course… impersonate failed
[18:08:05 CDT(-0500)] <JasonElwood> impersonate for students has never worked to my knowledge. I always log in directly.
[18:08:19 CDT(-0500)] <dmccallum54> k
[18:08:21 CDT(-0500)] <dmccallum54> worked locally
[18:08:26 CDT(-0500)] <JasonElwood> really
[18:08:27 CDT(-0500)] <dmccallum54> i'll try logging in directly
[18:08:48 CDT(-0500)] <dmccallum54> wow
[18:08:51 CDT(-0500)] <dmccallum54> that does not work at all
[18:09:01 CDT(-0500)] <dmccallum54> just entered the student creds and it logged me in as admin
[18:09:13 CDT(-0500)] <JasonElwood> um
[18:09:26 CDT(-0500)] <dmccallum54> what's the student password
[18:09:30 CDT(-0500)] <TonyUnicon> i promise my fix did not cause that
[18:09:35 CDT(-0500)] <TonyUnicon> advisor0 most likely
[18:09:59 CDT(-0500)] <dmccallum54> tried that
[18:13:23 CDT(-0500)] <dmccallum54> ok. well.
[18:13:30 CDT(-0500)] <dmccallum54> student type save is definitely not working
[18:13:31 CDT(-0500)] <dmccallum54> try rtaylor514
[18:13:36 CDT(-0500)] <dmccallum54> anyway
[18:14:47 CDT(-0500)] <JasonElwood> um, I can't search for that user
[18:14:55 CDT(-0500)] <dmccallum54> right
[18:14:59 CDT(-0500)] <dmccallum54> b/c he has no student type
[18:15:05 CDT(-0500)] <JasonElwood> ah yeah
[18:15:05 CDT(-0500)] <dmccallum54> so go into CA, find him that way
[18:15:09 CDT(-0500)] <dmccallum54> and try to save a student type
[18:15:24 CDT(-0500)] <JasonElwood> which coach?
[18:15:38 CDT(-0500)] <JasonElwood> I changed student type on users several times just now
[18:15:52 CDT(-0500)] <dmccallum54> i didnt touch coach
[18:16:03 CDT(-0500)] <dmccallum54> let me know if you save that guy's record
[18:16:06 CDT(-0500)] <dmccallum54> about to try GPS with him
[18:16:26 CDT(-0500)] <JasonElwood> which coach is rtaylor514 assigned to?
[18:17:10 CDT(-0500)] <dmccallum54> mtayloradv5
[18:18:35 CDT(-0500)] <dmccallum54> you working on him or can i go ahead with GPS?
[18:18:57 CDT(-0500)] <JasonElwood> didn't save. go ahead
[18:19:39 CDT(-0500)] <JasonElwood> students with an existing type seem to save
[18:21:12 CDT(-0500)] <dmccallum54> GPS fix worked
[18:21:16 CDT(-0500)] <dmccallum54> here's what i did to test it
[18:21:36 CDT(-0500)] <dmccallum54> i went in to SSP as admin and created the intake task via CA for rtaylor514
[18:21:42 CDT(-0500)] <dmccallum54> logged out
[18:21:45 CDT(-0500)] <dmccallum54> logged back in as rtaylor514
[18:22:05 CDT(-0500)] <dmccallum54> hit this url:
[18:22:13 CDT(-0500)] <dmccallum54> http://ssp-ci/ssp/api/1/foo?id=ba16b12f-c556-41bd-b68c-50087ff89118
[18:22:27 CDT(-0500)] <dmccallum54> verified in the database that that added a person_demographics record
[18:22:34 CDT(-0500)] <dmccallum54> select id from person_demographics where id = (select person_demographics_id from person where id = 'ba16b12f-c556-41bd-b68c-50087ff89118');
[18:22:42 CDT(-0500)] <dmccallum54> completed intake in GPS
[18:22:44 CDT(-0500)] <dmccallum54> no error
[18:23:04 CDT(-0500)] <JasonElwood> very sweet
[18:23:25 CDT(-0500)] <TonyUnicon> yay
[18:23:30 CDT(-0500)] <TonyUnicon> thanks for your help dan
[18:23:37 CDT(-0500)] <JasonElwood> I don't see anything in the log for the student type save
[18:23:48 CDT(-0500)] <dmccallum54> seems like it's just being skipped
[18:23:55 CDT(-0500)] <dmccallum54> on the GPS thing...
[18:24:03 CDT(-0500)] <dmccallum54> i did not pick a veteran status in the UI
[18:24:07 CDT(-0500)] <dmccallum54> his veteran status is now...
[18:24:14 CDT(-0500)] <dmccallum54> 5c584fdb-dcc8-44ff-a30d-8c3e0a2d8206
[18:24:38 CDT(-0500)] <dmccallum54> which is "Not applicable'
[18:24:39 CDT(-0500)] <TonyUnicon> which is N/A
[18:24:44 CDT(-0500)] <TonyUnicon> yeah
[18:25:25 CDT(-0500)] <dmccallum54> k
[18:25:31 CDT(-0500)] <TonyUnicon> that is expected
[18:25:37 CDT(-0500)] <TonyUnicon> and a bunch of fields work like that
[18:25:54 CDT(-0500)] <TonyUnicon> its not that awesome
[18:25:56 CDT(-0500)] <TonyUnicon> but expected
[18:26:20 CDT(-0500)] <dmccallum54> ok
[18:26:24 CDT(-0500)] <dmccallum54> JasonElwood
[18:26:37 CDT(-0500)] <dmccallum54> i'm no longer getting the JournalEntry error
[18:26:43 CDT(-0500)] <dmccallum54> here's what i did to test it
[18:27:41 CDT(-0500)] <dmccallum54> curl 'http://my-client:st4nd4rds!@ssp-ci/ssp/api/1/oauth2/token' -d grant_type=client_credentials -w "\n"
[18:27:47 CDT(-0500)] <dmccallum54> that should return something like
[18:27:53 CDT(-0500)] <dmccallum54>
[18:28:14 CDT(-0500)] <dmccallum54> then i have a file with the JSON payload that would bomb out when PUT to the server
[18:28:35 CDT(-0500)] <dmccallum54> https://gist.github.com/dmccallum/6384665
[18:28:39 CDT(-0500)] <dmccallum54> then i run this
[18:28:56 CDT(-0500)] <dmccallum54> curl -X PUT -H "Content-Type: application/json" --header "Authorization: Bearer b0f12c86-83c9-4aa0-a859-b80b74bdf968" 'http://ssp-ci/ssp/api/1/person/0a90940a-3fbd-1217-813f-bf3f208a0004/journalEntry/0a90940a-4016-1d02-8140-16f5b7f60002' --data-binary @/Users/dmccallum/Desktop/journal-entry.json -w "\n"
[18:29:18 CDT(-0500)] <dmccallum54> the value of the Bearer token is the access_token from the previous request
[18:29:33 CDT(-0500)] <dmccallum54> and of course the file path for journal-entry.json is env specific
[18:29:36 CDT(-0500)] <dmccallum54> previously i got this:
[18:29:42 CDT(-0500)] <dmccallum54> dmccallum@dmccallum-mbp:~/dev1/ssp/src/clc-ssp (clc-ssp)$ curl -X PUT -H "Content-Type: application/json" 'http://ssp-ci/ssp/api/1/person/0a90940a-3fbd-1217-813f-bf3f208a0004/journalEntry/0a90940a-4016-1d02-8140-16f5b7f60002' --data-binary @/Users/dmccallum/Desktop/journal-entry.json -w "\n"
[18:29:43 CDT(-0500)] <dmccallum54>
[18:29:45 CDT(-0500)] <dmccallum54> now i get...
[18:30:05 CDT(-0500)] <dmccallum54> dmccallum@dmccallum-mbp:~/dev1/ssp/src/clc-ssp (clc-ssp)$ curl -X PUT -H "Content-Type: application/json" --header "Authorization: Bearer b0f12c86-83c9-4aa0-a859-b80b74bdf968" 'http://ssp-ci/ssp/api/1/person/0a90940a-3fbd-1217-813f-bf3f208a0004/journalEntry/0a90940a-4016-1d02-8140-16f5b7f60002' --data-binary @/Users/dmccallum/Desktop/journal-entry.json -w "\n"
[18:30:06 CDT(-0500)] <dmccallum54> {"id":"0a90940a-4016-1d02-8140-16f5b7f60002","createdDate":1374774736887,"createdBy":{"id":"0a90940a-3efc-175f-813e-fc1ac581000b"… (snip)
[18:30:23 CDT(-0500)] <dmccallum54> ugh
[18:30:33 CDT(-0500)] <dmccallum54> the previous error copy/paste was wrong
[18:30:37 CDT(-0500)] <dmccallum54> here's the right one...
[18:30:46 CDT(-0500)] <dmccallum54> dmccallum@dmccallum-mbp:~/dev1/ssp/src/clc-ssp (clc-ssp)$ curl -X PUT -H "Content-Type: application/json" --header "Authorization: Bearer 537dd776-fb93-44c2-818b-ecea7daf23bd" 'http://ssp-ci/ssp/api/1/person/0a90940a-3fbd-1217-813f-bf3f208a0004/journalEntry/0a90940a-4016-1d02-8140-16f5b7f60002' --data-binary @/Users/dmccallum/Desktop/journal-entry.json -w "\n"
[18:30:48 CDT(-0500)] <dmccallum54>
[18:35:08 CDT(-0500)] <JasonElwood> can't duplicate it so far
[18:35:24 CDT(-0500)] <dmccallum54> there's definitely going to be a performance hit
[18:35:28 CDT(-0500)] <dmccallum54> but hopefully no errors
[18:36:09 CDT(-0500)] <JasonElwood> appears to be fixed
[18:36:49 CDT(-0500)] <JasonElwood> so that leaves 1660, student type issue and 1687 right now
[18:38:45 CDT(-0500)] <dmccallum54> created 1695 for student type
[18:40:57 CDT(-0500)] <pspaude> I can close 1660 if you want. I cleaned taht up days ago. Just left it open so I could revisit and see anything popup.
[18:41:08 CDT(-0500)] <JasonElwood> sweet
[18:41:21 CDT(-0500)] <dmccallum54> 87 is minor
[18:41:36 CDT(-0500)] <JasonElwood> very
[18:41:42 CDT(-0500)] <dmccallum54> pspaude can you pls take a look at 1695
[18:41:47 CDT(-0500)] <dmccallum54> or are you working on something else?
[18:41:55 CDT(-0500)] <JasonElwood> 87 is moved
[18:42:51 CDT(-0500)] <pspaude> Already taking a look at 1695 setting up to try and reproduce locally. I'm assuming its with a added external student becuase you can't search for reg students without student type
[18:43:13 CDT(-0500)] <dmccallum54> you can always find anybody via caseload assignment
[18:43:24 CDT(-0500)] <TonyUnicon> what can I do?
[18:43:34 CDT(-0500)] <dmccallum54> so just like add someone by school_id who doesn't have a student_type_id
[18:43:45 CDT(-0500)] <JasonElwood> Tony- do you have anything to add to 1689? it checked out ok
[18:44:04 CDT(-0500)] <TonyUnicon> no, i think we're good
[18:44:15 CDT(-0500)] <TonyUnicon> thanks again Dan
[18:44:18 CDT(-0500)] <dmccallum54> np
[18:44:21 CDT(-0500)] <dmccallum54> you did the hard stuff
[18:44:27 CDT(-0500)] <dmccallum54> i just sat here cursing at uportal
[18:44:31 CDT(-0500)] <pspaude> Right, just making sure I understood when the error would occur. I do have a user all setup from my prev issues. Checking it out now.
[18:44:33 CDT(-0500)] <dmccallum54> as i am wont
[18:44:38 CDT(-0500)] <TonyUnicon> lol
[18:44:54 CDT(-0500)] <TonyUnicon> are you asking me Jason?
[18:45:07 CDT(-0500)] <dmccallum54> TonyUnicon i think 1695 is the last functional issue we're aware of
[18:45:15 CDT(-0500)] <dmccallum54> the difficulty impersonating a student has me worried
[18:45:19 CDT(-0500)] <JasonElwood> I closed it. thanks
[18:45:28 CDT(-0500)] <TonyUnicon> anyone take it?
[18:45:47 CDT(-0500)] <JasonElwood> haven't created an issue yet
[18:45:49 CDT(-0500)] <dmccallum54> also has me worried that when i try impersonating a student and GPS then thinks i'm anonymous and i then submit my student creds i turn into the admin
[18:46:03 CDT(-0500)] <JasonElwood> cookies?
[18:46:08 CDT(-0500)] <dmccallum54> well
[18:46:14 CDT(-0500)] <dmccallum54> that one kinda sort makes sense
[18:46:20 CDT(-0500)] <dmccallum54> b/c you do actually have a uP session already
[18:46:29 CDT(-0500)] <dmccallum54> the underlying impersonator session
[18:46:32 CDT(-0500)] <JasonElwood> I've seen some weird crap until I kill the session or close the browser
[18:46:56 CDT(-0500)] <dmccallum54> so what makes me more concerned actually is that impersonate doesnt work
[18:47:03 CDT(-0500)] <dmccallum54> suggests something is just flat borked
[18:47:05 CDT(-0500)] <TonyUnicon> Paul you have a handle on 1695 or do you want me to take a look at it?
[18:47:41 CDT(-0500)] <JasonElwood> Paul- it seems adding a student type to a student without fails. changing a type for a student that already has a type works ok.
[18:47:51 CDT(-0500)] <JasonElwood> no errors in the log or client side
[18:48:01 CDT(-0500)] <dmccallum54> so TonyUnicon unless paul does end up wanting another pair of eyes on 1695 i was hoping another pair of eyes on uP impersonation would be available (yours)
[18:48:34 CDT(-0500)] <dmccallum54> mainly around 'why does student impersonation into GPS not work in Linux CI'
[18:49:10 CDT(-0500)] <dmccallum54> thinking the impersonation stuff can bleed into tomorrow if needed
[18:49:20 CDT(-0500)] <dmccallum54> would be nice to get the functional stuff wrapped up today before we lose jason tho
[18:49:23 CDT(-0500)] <TonyUnicon> so
[18:49:32 CDT(-0500)] <dmccallum54> so 1695 is definitely the priority, i'd say. jason?
[18:49:36 CDT(-0500)] <TonyUnicon> this is the first time ive heard the term student impersonation
[18:49:37 CDT(-0500)] <JasonElwood> yes
[18:49:41 CDT(-0500)] <JasonElwood> definitely
[18:49:43 CDT(-0500)] <TonyUnicon> how does it work?
[18:50:10 CDT(-0500)] <TonyUnicon> i have dug into the spring security stuff enough
[18:50:10 CDT(-0500)] <TonyUnicon> that
[18:50:12 CDT(-0500)] <TonyUnicon> I may be useful
[18:50:20 CDT(-0500)] <dmccallum54> in uportal go to the Manage Users fragment
[18:50:38 CDT(-0500)] <dmccallum54> search for the user you want to impersonate, click on their name, and then press the Impersonate button
[18:51:27 CDT(-0500)] <pspaude> Update on 1695 looks like client-side, sending null to server even if valid item in combo is selected. Hopefully this will be quick...
[18:51:35 CDT(-0500)] <TonyUnicon> ok, i will have a look at that
[18:52:02 CDT(-0500)] <dmccallum54> thx
[18:52:14 CDT(-0500)] <JasonElwood> Paul- curious on that one. regression?
[18:52:54 CDT(-0500)] <pspaude> Hmm I don't know I was in there earlier but didn't touch that part. Figuring out what it is doing now.
[18:53:11 CDT(-0500)] <dmccallum54> TonyUnicon of course after making a big deal about impersonation not working, it magically does work for rtaylor514 now
[18:54:38 CDT(-0500)] <dmccallum54> wondering if something got borked in the uP demo data out there
[18:54:40 CDT(-0500)] <dmccallum54> locally:
[18:54:44 CDT(-0500)] <dmccallum54> select count
from up_user
[18:54:46 CDT(-0500)] <dmccallum54> 1049
[18:54:50 CDT(-0500)] <dmccallum54> in linux ci:
[18:54:58 CDT(-0500)] <dmccallum54> ssp=# select count from up_user;
[18:54:58 CDT(-0500)] <dmccallum54> count
[18:54:58 CDT(-0500)] <dmccallum54> -------
[18:54:58 CDT(-0500)] <dmccallum54> 254
[18:54:58 CDT(-0500)] <dmccallum54> (1 row)
[18:56:17 CDT(-0500)] <dmccallum54> oh nice. and now the uportal user search is blowing JS stacks
[18:58:11 CDT(-0500)] <TonyUnicon> 
[18:59:50 CDT(-0500)] <TonyUnicon> what would break when you impersonate ?
[18:59:58 CDT(-0500)] <TonyUnicon> seems to work for me
[19:00:18 CDT(-0500)] <dmccallum54> usually it would be some sort of failure to find or lazily create your SSP person record
[19:00:59 CDT(-0500)] <TonyUnicon> perhaps fixed by the first time login issue?
[19:01:06 CDT(-0500)] <TonyUnicon> or fixed by the same fix rather
[19:02:31 CDT(-0500)] <dmccallum54> seeing a bunch of these in the logs
[19:02:53 CDT(-0500)] <dmccallum54> https://gist.github.com/dmccallum/6384858
[19:03:26 CDT(-0500)] <dmccallum54> seeing some duplicate records in the uP person search API
[19:03:49 CDT(-0500)] <dmccallum54> http://ssp-ci/ssp-platform/api/people.json?searchTerms%5B%5D=givenName&givenName=John
[19:04:16 CDT(-0500)] <dmccallum54> or more helpfully
[19:04:17 CDT(-0500)] <dmccallum54> http://ec2-23-20-222-7.compute-1.amazonaws.com/ssp-platform/api/people.json?searchTerms%5B%5D=givenName&givenName=John
[19:04:35 CDT(-0500)] <dmccallum54> anyway… upshot being that there still seems to be something wrong in the uP user data
[19:05:00 CDT(-0500)] <dmccallum54> JasonElwood what would happen if we ran a initportal on this thing again
[19:05:24 CDT(-0500)] <dmccallum54> and reload the uP demo data
[19:05:38 CDT(-0500)] <dmccallum54> would probably want to wait until after paul's student type patch
[19:05:42 CDT(-0500)] <JasonElwood> oooh
[19:05:44 CDT(-0500)] <dmccallum54> but might be wasting time on bad data herew
[19:06:23 CDT(-0500)] <JasonElwood> we'd lose quite a bit of testing data
[19:06:41 CDT(-0500)] <dmccallum54> k
[19:06:51 CDT(-0500)] <dmccallum54> in uportal?
[19:06:56 CDT(-0500)] <JasonElwood> if that's what it takes, I'll deal with it
[19:07:12 CDT(-0500)] <JasonElwood> well, no I guess. just ssp data
[19:07:19 CDT(-0500)] <dmccallum54> initportal just nukes uP tables
[19:07:30 CDT(-0500)] <dmccallum54> or i could try just reloading the uP demo data to see what happens
[19:07:38 CDT(-0500)] <dmccallum54> should be non-destructive
[19:08:00 CDT(-0500)] <JasonElwood> whatever is easiest for you is fine
[19:15:22 CDT(-0500)] <dmccallum54> ok. nm. i think i can reproduce
[19:17:13 CDT(-0500)] <dmccallum54> or maybe not
[19:17:16 CDT(-0500)] <dmccallum54> man this is great stuff
[19:17:32 CDT(-0500)] <TonyUnicon> ?
[19:18:13 CDT(-0500)] <dmccallum54> so the theory was that SSP was blowing up trying to create a person record for a uP user it hasn't seen before
[19:18:31 CDT(-0500)] <dmccallum54> so ran this query
[19:18:32 CDT(-0500)] <dmccallum54> select user_name from up_person_dir where user_name not in (select username from person);
[19:18:39 CDT(-0500)] <dmccallum54> and grabbed a user at random
[19:19:16 CDT(-0500)] <dmccallum54> sure enough. blows up.
[19:20:10 CDT(-0500)] <dmccallum54> tried a few others. no such problem
[19:20:57 CDT(-0500)] <TonyUnicon> where does it blow up?
[19:21:01 CDT(-0500)] <dmccallum54> https://gist.github.com/dmccallum/6384976
[19:22:02 CDT(-0500)] <TonyUnicon> so it happens once and thats it?
[19:22:45 CDT(-0500)] <dmccallum54> seems to
[19:23:47 CDT(-0500)] <dmccallum54> these are the users i tried, in reverse order (most recent on top):
[19:23:48 CDT(-0500)] <dmccallum54> mwhite315
[19:23:49 CDT(-0500)] <dmccallum54> jgarcia35
[19:23:49 CDT(-0500)] <dmccallum54> mwhite113
[19:23:49 CDT(-0500)] <dmccallum54> mdavis340
[19:23:56 CDT(-0500)] <dmccallum54> only mdavis340 errored out
[19:24:37 CDT(-0500)] <dmccallum54> now she works fine
[19:24:39 CDT(-0500)] <dmccallum54> so...
[19:24:53 CDT(-0500)] <dmccallum54> looks like more race conditions on first-time "login" perhaps
[19:26:01 CDT(-0500)] <dmccallum54> i'm gunna have to run in 5m
[19:26:10 CDT(-0500)] <dmccallum54> may need to pick this up late tonight or tomorrow
[19:26:39 CDT(-0500)] <TonyUnicon> ill have a crack at it
[19:27:16 CDT(-0500)] <dmccallum54> thx
[19:28:46 CDT(-0500)] <dmccallum54> you able to shell into that box?
[19:29:31 CDT(-0500)] <dmccallum54> if you haven't done it before the keys and all that are here: https://wiki.jasig.org/display/SSP/SSP+CI+Server+Notes
[19:29:42 CDT(-0500)] <dmccallum54> to get into postgres CLI
[19:29:52 CDT(-0500)] <dmccallum54> psql -d ssp -U sspadmin
[19:30:18 CDT(-0500)] <JasonElwood> I may need to open the ip
[19:30:48 CDT(-0500)] <dmccallum54> i've not had problems ssh-ing in from various coffee shops
[19:30:53 CDT(-0500)] <dmccallum54> so that port might be wide open
[19:30:57 CDT(-0500)] <JasonElwood> sweet then
[19:31:18 CDT(-0500)] <dmccallum54> alright. sorry guys. i gotta run. will try to check in later tonight. thx for all the help.
[19:31:25 CDT(-0500)] <pspaude> Dan offhand do you know why there is a guard condition in the Person model for coachID and studenttypeID if they are null don't set it with a current valid value?
[19:31:29 CDT(-0500)] <pspaude> That is the problem for 1695. I'm just worried as to side effects all though so far I don't see any.
[19:31:45 CDT(-0500)] <dmccallum54> i dont know. TonyUnicon?
[19:32:04 CDT(-0500)] <pspaude> Nevermind take off, I think its ok, I'll go ahead and commit. Just tried different test cases and it seems ok.
[19:32:30 CDT(-0500)] <TonyUnicon> hold on
[19:32:40 CDT(-0500)] <dmccallum54> check and make sure saving intake doesn't blow it away or something like that?
[19:32:45 CDT(-0500)] <TonyUnicon> i think there was a ticket that explicitly says that
[19:33:06 CDT(-0500)] <pspaude> Good idea I'll check right now.
[19:33:07 CDT(-0500)] <TonyUnicon> let me find it
[19:34:05 CDT(-0500)] <TonyUnicon> https://issues.jasig.org/browse/SSP-1490
[19:34:21 CDT(-0500)] <pspaude> intake works with the guard removed, let me play git blame and see the issue
[19:34:42 CDT(-0500)] <pspaude> *rather it doesn't blow things to pieces
[19:34:50 CDT(-0500)] <TonyUnicon> Rule: leave the data in SSP alone if there is no coach or student_type in external_person.
[19:35:29 CDT(-0500)] <TonyUnicon> its a business rule
[19:37:05 CDT(-0500)] <TonyUnicon> the file/line are you speaking about specifically
[19:37:51 CDT(-0500)] <pspaude> Person.js line 108 and line 162
[19:38:32 CDT(-0500)] <pspaude> Pretty much makes SSP-1695 and the whole its ok if the values are null thing stop dead in the water.
[19:39:35 CDT(-0500)] <TonyUnicon> this is a very sensitive part of the code
[19:39:41 CDT(-0500)] <TonyUnicon> not a great 11th hour fix
[19:39:49 CDT(-0500)] <pspaude> Yes I know. That is why I was worried.
[19:40:13 CDT(-0500)] <pspaude> This is the direct block to 1695 and coachID null too! (Which I think was a previous issue)
[19:40:18 CDT(-0500)] <TonyUnicon> that method it used in a bunch of places
[19:40:35 CDT(-0500)] <TonyUnicon> i do not recommend changing it
[19:40:44 CDT(-0500)] <TonyUnicon> let me look at the ticket
[19:41:41 CDT(-0500)] <TonyUnicon> although
[19:41:46 CDT(-0500)] <TonyUnicon> that is pretty bizzare behavior
[19:42:21 CDT(-0500)] <pspaude> Hmm those lines were in there originally from when value could be dual.
[19:42:52 CDT(-0500)] <pspaude> Yeah I agree it is bizarre that is why I was scratching my head, I thought at first it was a conditional logic mistake, but two different people implemented it one for coachId and one for studentType id.
[19:43:17 CDT(-0500)] <pspaude> Originally : if ( this.get('coach') != null)
[19:43:20 CDT(-0500)] <pspaude> + {
[19:43:22 CDT(-0500)] <pspaude> + this.get('coach').id = value;
[19:43:24 CDT(-0500)] <pspaude> + }else{
[19:43:26 CDT(-0500)] <pspaude> + this.set('coach', );
[19:43:28 CDT(-0500)] <pspaude> + }
[19:43:40 CDT(-0500)] <pspaude> So someone removed the bottom half.
[19:43:52 CDT(-0500)] <TonyUnicon> but that stuff has been in there for over a year
[19:43:57 CDT(-0500)] <TonyUnicon> and it is used in multiple places
[19:44:07 CDT(-0500)] <TonyUnicon> a change in that code needs to soak IMO
[19:44:23 CDT(-0500)] <pspaude> Yeah that is my opinion as well.
[19:44:44 CDT(-0500)] <TonyUnicon> see if you can code around it
[19:44:50 CDT(-0500)] <TonyUnicon> so that it's only isolated to the bug your fixing
[19:45:11 CDT(-0500)] <TonyUnicon> try to modify the value directly
[19:45:31 CDT(-0500)] <TonyUnicon> and write up for future consumption
[19:45:37 CDT(-0500)] <TonyUnicon> we can do it first thing next iteration and let it sit
[19:45:49 CDT(-0500)] <pspaude> I'm trying modifying the JSON data before its sent but that adds some other peculiarites.
[19:46:02 CDT(-0500)] <TonyUnicon> like what?
[19:46:49 CDT(-0500)] <pspaude> I think it can be done. Student type has to be null if empty, so if we have a valid value I dont' think it will matter.
[19:47:38 CDT(-0500)] <TonyUnicon> yeah I dont think we have a choice, id be really hard pressed to make a change to the model code proper
[19:47:47 CDT(-0500)] <TonyUnicon> as we just dont have the time to asses the impact
[19:47:55 CDT(-0500)] <pspaude> No I agree and the json method is ok I think.
[19:48:18 CDT(-0500)] <TonyUnicon> id write a ticket up
[19:48:26 CDT(-0500)] <TonyUnicon> for we can address it soon
[19:48:29 CDT(-0500)] <pspaude> But, yeah we have to let it soak. I think the model might need tobe changed since we changed the idea of allowing those values to be null late in the game, namely this iteration.
[19:48:32 CDT(-0500)] <TonyUnicon> because I have never seen a setter do that
[19:48:34 CDT(-0500)] <TonyUnicon> ever
[19:48:54 CDT(-0500)] <pspaude> Yeah I'll put it in the ticket and then see if Jason wants another ticket.
[19:49:06 CDT(-0500)] <pspaude> I've never seen one do that either, its always the opposite.
[19:49:41 CDT(-0500)] <JasonElwood> we should split out anything we aren't comfortable doing for 2.0.0
[20:39:27 CDT(-0500)] <dmccallum54> back momentarily
[20:39:59 CDT(-0500)] <JasonElwood> created 1696 for impersonation issue. not sure how much we want to describe in the issue
[20:40:07 CDT(-0500)] <JasonElwood> Tony is working on it though
[20:40:45 CDT(-0500)] <TonyUnicon> i dont think its an impersonation issue anymore
[20:40:46 CDT(-0500)] <JasonElwood> Paul is working on a fix for 1695, trying to keep it isolated as possible
[20:40:50 CDT(-0500)] <TonyUnicon> its a race condition
[20:41:02 CDT(-0500)] <TonyUnicon> and ive my swipes at it
[20:41:09 CDT(-0500)] <dmccallum54> yeah. i just got it to happen locally again, but it's erratic
[20:41:15 CDT(-0500)] <TonyUnicon> i get it
[20:41:31 CDT(-0500)] <TonyUnicon> but the UI doesn't degrade, it just blows stack
[20:41:43 CDT(-0500)] <dmccallum54> when i got it just now ssp wouldnt' render
[20:41:44 CDT(-0500)] <TonyUnicon> but I did try a few things that didnt work
[20:41:49 CDT(-0500)] <TonyUnicon> spawning a new transaction being one of them
[20:42:35 CDT(-0500)] <TonyUnicon> really? I got the stack but mygps loaded
[20:42:39 CDT(-0500)] <TonyUnicon> maybe i did not pay close enough attention
[20:42:51 CDT(-0500)] <TonyUnicon> could have been in anonymous mode
[20:42:55 CDT(-0500)] <dmccallum54> GPS will load but behave as if the user is anonymous
[20:42:58 CDT(-0500)] <dmccallum54> SSP will not
[20:43:11 CDT(-0500)] <dmccallum54> Ext throws a fit about the empty response from getAuthenticatedUser
[20:46:17 CDT(-0500)] <TonyUnicon> i also have to step away as eating is apparently a requirement
[20:46:50 CDT(-0500)] <TonyUnicon> be back in ~30 minutes
[20:51:56 CDT(-0500)] <pspaude> Finished SSP-1695. Am leaving for home. Will come back after I'm home and make sure everything is going good.
[20:52:57 CDT(-0500)] <JasonElwood> I'm going to build linux CI to test 1695 while everybody is away
[20:53:05 CDT(-0500)] <pspaude> Cool go ahead.
[20:56:04 CDT(-0500)] <dmccallum54> gunna have to check out again in 5m
[20:56:17 CDT(-0500)] <dmccallum54> but think i have a bead on the impersonation/1st-time login race
[20:56:20 CDT(-0500)] <dmccallum54> famous last words
[20:56:35 CDT(-0500)] <JasonElwood> that would be awesome
[20:58:29 CDT(-0500)] <dmccallum54> ugh gotta run
[21:07:28 CDT(-0500)] <dmccallum54> k. back momentarily think i've got irt
[21:07:36 CDT(-0500)] <dmccallum54> going to go ahead and check it in
[21:08:56 CDT(-0500)] <dmccallum54> pushed
[21:09:07 CDT(-0500)] <JasonElwood> uportal check-in?