[11:45:06 CDT(-0500)] <JasonElwood> Dan- remind me of the root cause for a sync error, query did not return a unique result
[11:45:15 CDT(-0500)] <JasonElwood> person sync
[11:45:20 CDT(-0500)] <dmccallum54> um
[11:45:21 CDT(-0500)] <dmccallum54> depends
[11:45:34 CDT(-0500)] <dmccallum54> mostly likely a problem with overlapping term date ranges
[11:45:36 CDT(-0500)] <JasonElwood> I tried to load more data into the linux CI
[11:45:52 CDT(-0500)] <JasonElwood> for the external_person to person sync?
[11:46:10 CDT(-0500)] <dmccallum54> yes. i believe it attempts to look up the person's current registration status, which involves lookup up the current term
[11:46:32 CDT(-0500)] <dmccallum54> do you have the stack trace handy? gist it?
[11:48:00 CDT(-0500)] <dmccallum54> 289 terms. wow.
[11:48:05 CDT(-0500)] <JasonElwood> I think I found it
[11:48:28 CDT(-0500)] <JasonElwood> thanks
[11:48:47 CDT(-0500)] <dmccallum54> you load a bunch of terms?
[11:51:20 CDT(-0500)] <dmccallum54> also… fwiw… remember that as of SSP-1002, the app's gunna interpret term start_date and end_date as UTC times by default. shouldn't be an issue in most cases, but near term boundaries you might get unexpected results for the "current term" for a few hours if you're loading 00:00:00 as the time component but you don't actually mean "midnight UTC"
[11:51:55 CDT(-0500)] <dmccallum54> a commit last night for SSP-1076 will automatically convert existing term start and end dates
[11:52:10 CDT(-0500)] <dmccallum54> but if you load more of 'em out of band it's on you to use UTC time
[11:52:50 CDT(-0500)] <dmccallum54> (this will obviously need to be reflected in 2.0 doco. i've started listing out these considerations in the date/time doc i put in the dev confluence docs)
[11:53:49 CDT(-0500)] <JasonElwood> best to just remove the time then
[11:54:43 CDT(-0500)] <dmccallum54> well. that just shifts the problem around a bit
[11:55:55 CDT(-0500)] <dmccallum54> b/c then the app needs to figure out what day it is in whatever timezone the school wants those particular fields to be evaluated in
[11:56:24 CDT(-0500)] <dmccallum54> we can do that if that's what you'd like to see. but it's definitely not like just chopping off the time components sends the work to be done to zero
[11:57:03 CDT(-0500)] <dmccallum54> i.e. you have to make the time component explicit somewhere… either in the db or in the app
[11:57:25 CDT(-0500)] <dmccallum54> this is a little different than our usage of birth dates, for example, where the time component truly doesn't matter
[11:57:48 CDT(-0500)] <dmccallum54> (that doesn't go for all apps, of course. e.g. we had another one that was keenly interested in knowing exactly how old people were.)
[11:59:13 CDT(-0500)] <JasonElwood> cool
[11:59:19 CDT(-0500)] <dmccallum54> "cool"
[12:00:23 CDT(-0500)] <TonyUnicon> !"cool"
[12:00:54 CDT(-0500)] <dmccallum54> i'm fucking dreaming about timestamps. every. fucking. night.
[12:01:07 CDT(-0500)] <dmccallum54> oh no! the offset monster!
[12:01:18 CDT(-0500)] <TonyUnicon> sounds like an old twilight zone episode
[12:01:58 CDT(-0500)] <JasonElwood> dude that's serious
[12:50:02 CDT(-0500)] <JasonElwood> Status Error: 500 - Internal Server Error object references an unsaved transient instance - save the transient instance before flushing: org.jasig.ssp.model.Plan
[12:50:12 CDT(-0500)] <TonyUnicon> update
[12:50:25 CDT(-0500)] <JasonElwood> cool
[12:50:29 CDT(-0500)] <TonyUnicon> that still was in a bit of flux right before the standup
[12:50:35 CDT(-0500)] <TonyUnicon> should be all checked in and fix, sorry about that
[12:50:45 CDT(-0500)] <JasonElwood> no worries
[12:51:19 CDT(-0500)] <TonyUnicon> that is something new since hibernate 3
[13:55:11 CDT(-0500)] <JasonElwood> Didn't we agree that if an advisor edits a MAP that they didn't create that a copy of the plan would be created? Or did we agree to update the MAP accordingly and save the latest details?
[13:58:46 CDT(-0500)] <dmccallum54> i believe a copy is created in two cases: 1) a MAP is saved where the current user is not the same as the recorded owner of the MAP and 2) end user selects 'save as'
[13:59:44 CDT(-0500)] <JasonElwood> right cool.
[14:13:05 CDT(-0500)] <JasonElwood> I'll be away for 1-2 hours. All the resolved MAP and Main issues were re-opened or closed.
[17:01:40 CDT(-0500)] <js70> we conferring?
[17:04:19 CDT(-0500)] <dmccallum54> 13 unresolved issues
[17:07:02 CDT(-0500)] <dmccallum54> i still think i can wrap up 1077 by COB
[17:07:32 CDT(-0500)] <dmccallum54> i doubt i'm going to get the permissions stuff done, but doubt that's a deal killer for b1
[17:07:43 CDT(-0500)] <dmccallum54> 1077 definitely needs to be done tho
[17:07:48 CDT(-0500)] <js70> https://issues.jasig.org/browse/SSP-713 should not be an issue as we have everything working.
[17:08:03 CDT(-0500)] <js70> SSP-795 (print) should be done in next hour.
[17:08:27 CDT(-0500)] <js70> https://issues.jasig.org/browse/SSP-1065 not-null constraint can be deferred?
[17:08:37 CDT(-0500)] <dmccallum54> anybody working on anything that, if not finished, would either a) make the app unusable or b) compromise north carolina's efforts to start developing against the external tables
[17:09:06 CDT(-0500)] <js70> whats your opinion on SSP-1065 dan?
[17:09:46 CDT(-0500)] <dmccallum54> 1065 would be nice b/c it affects external data. but if 1077 gets done and 1065 is the only outstanding external data item, we can probably postpone and let nc know what's going on
[17:11:22 CDT(-0500)] <js70> if we have to print to pdf, not going to get done. my estimate.:'(
[17:12:18 CDT(-0500)] <dmccallum54> yeah. doesn't cripple the app tho.
[17:12:34 CDT(-0500)] <dmccallum54> so not a blocker, imho.
[17:13:26 CDT(-0500)] <dmccallum54> ok. i'm going to plan on creating a release branch before i knock off for the day
[17:14:14 CDT(-0500)] <dmccallum54> so that just means…. please try not to commit anything "partial solutions" to master.
[17:14:22 CDT(-0500)] <js70> k
[17:14:33 CDT(-0500)] <TonyUnicon> 
[17:14:34 CDT(-0500)] <dmccallum54> i.e. if it's a stop-gap fix for whatever you're working on that leaves things usable, great
[17:14:48 CDT(-0500)] <dmccallum54> uhoh. tony's sad
[17:14:54 CDT(-0500)] <TonyUnicon> no its fine
[17:14:58 CDT(-0500)] <TonyUnicon> I wanted to check in partial solutions
[17:15:02 CDT(-0500)] <TonyUnicon> but I guess it will have to wait
[17:15:12 CDT(-0500)] <TonyUnicon> im joking
[17:15:32 CDT(-0500)] <TonyUnicon> source control jokes never seem to pan out though
[17:16:03 CDT(-0500)] <dmccallum54> when's the last time you got even a whiff of a sense of humor from git?
[17:16:19 CDT(-0500)] <GregElliott> yeah, takes like a Jerry Seinfeld to pull one of those off.
[17:16:32 CDT(-0500)] <TonyUnicon> when I read some thread you posted on yammer about goosestepping dba's
[17:16:46 CDT(-0500)] <TonyUnicon> that was pretty funny
[17:16:46 CDT(-0500)] <GregElliott> DBA (Don't bother asking)
[17:17:38 CDT(-0500)] <TonyUnicon> the only trade in IT that operates like a medieval guild
[17:18:10 CDT(-0500)] <dmccallum54> oh that's right. totally forgotten about that. https://www.yammer.com/unicon.net/#/Threads/show?threadId=238940146
[17:18:27 CDT(-0500)] <dmccallum54> aaaallll right. back to my first love: liquibase
[17:52:39 CDT(-0500)] <js70> checked in stuff for filling out terms 4 years into the future. Don't know if you are waiting for it.
[17:52:47 CDT(-0500)] <js70> on to print out
[17:53:53 CDT(-0500)] <JasonElwood> I'll check it out. thanks
[17:54:41 CDT(-0500)] <js70> you stay away from my code Jason, all you ever to is complain.:|
[17:55:27 CDT(-0500)] <JasonElwood> no Jim. Its great code; it just doesn't work
[17:55:56 CDT(-0500)] <JasonElwood> I don't do emoticons
[17:56:48 CDT(-0500)] <dmccallum54> brutal
[17:57:17 CDT(-0500)] <JasonElwood> great code is a compliment
[17:59:29 CDT(-0500)] <js70> the way YOU want. works fine for me.
[18:01:50 CDT(-0500)] <JasonElwood> I am still having a problem with the Schedule tab. not sure where to go with that.
[18:02:20 CDT(-0500)] <js70> just so you know, I may have checked in code previous that caused the save not to store the termCode(about 4 hours ago). Its fixed now.
[18:02:28 CDT(-0500)] <js70> not showing the schedule?
[18:02:34 CDT(-0500)] <JasonElwood> right
[18:03:38 CDT(-0500)] <JasonElwood> just found something. the first time you hit it, 404 not found error. checking the log
[18:09:12 CDT(-0500)] <JasonElwood> DEV: 23:06:00.831 [http-8081-6] ERROR o.j.s.web.api.tool.IntakeController - Error:
[18:09:12 CDT(-0500)] <JasonElwood> org.jasig.ssp.service.ObjectNotFoundException: 0376367
[18:09:13 CDT(-0500)] <JasonElwood> at org.jasig.ssp.dao.external.ExternalPersonDao.getBySchoolId(ExternalPersonDao.java:66) ~[ExternalPersonDao.class:na]
[18:09:20 CDT(-0500)] <JasonElwood> Can I assume the, 0376367, is a school_id?
[18:12:40 CDT(-0500)] <js70> that sounds right
[18:13:08 CDT(-0500)] <JasonElwood> ugh. That school_id doesn't exist in external_person or external_student_transcript_course
[18:13:47 CDT(-0500)] <js70> so student was created through SSP?
[18:14:34 CDT(-0500)] <JasonElwood> nope. student doesn't exist in person either
[18:15:59 CDT(-0500)] <js70> did we finally find an honest to god extra terrestrial?
[18:16:35 CDT(-0500)] <JasonElwood> maybe. its in the linux CI env.
[18:16:53 CDT(-0500)] <js70> they're all extra terrestrials!
[18:23:39 CDT(-0500)] <js70> I think our expected graduation date calculated from map depends on an accurate map. hope thats ok.
[18:23:55 CDT(-0500)] <js70> maybe change to last map term or something.
[18:25:39 CDT(-0500)] <JasonElwood> we are just guessing right now based on the map anyway
[18:26:33 CDT(-0500)] <js70> I think its worth knowing the last term the map is filled to but it's somewhat missleading...
[18:27:01 CDT(-0500)] <js70> I'm ok leaving it, just wanted to note it.
[18:34:58 CDT(-0500)] <JasonElwood> Jim- if that number in the exception is a school_id, then it must be hard-coded somewhere. The same exception appears for every student selected
[18:37:36 CDT(-0500)] <js70> so that's not the school_id
[18:38:06 CDT(-0500)] <JasonElwood> it may not be, but it fails regardless of the student now
[18:38:06 CDT(-0500)] <js70> let me look at the exception.
[18:40:15 CDT(-0500)] <js70> do you see this anywhere:
[18:40:16 CDT(-0500)] <js70> "Unable to load with ID {"
[18:40:16 CDT(-0500)] <js70> + (objectId == null ? "null" : objectId.toString() + "}"
[18:40:33 CDT(-0500)] <js70> thats the message that's supposed to be generated.
[18:40:50 CDT(-0500)] <JasonElwood> not in the exception
[18:41:32 CDT(-0500)] <js70> are your users in the database as external students? and do the schoolIds in person match what is the schoolId in external_person?
[18:41:34 CDT(-0500)] <JasonElwood> that number is the API response message
[18:41:58 CDT(-0500)] <JasonElwood> they do because the transcript tab works
[18:42:19 CDT(-0500)] <JasonElwood> http://ec2-23-20-222-7.compute-1.amazonaws.com/ssp/api/1/person/0a90940a-3e47-19e6-813e-47449e010000/transcript/currentcourses
[18:42:32 CDT(-0500)] <JasonElwood> returns,
[18:42:40 CDT(-0500)] <js70> k
[18:42:50 CDT(-0500)] <JasonElwood> the uuid exists and returns the correct student via query
[18:42:56 CDT(-0500)] <js70> k
[18:44:53 CDT(-0500)] <js70> http://ec2-23-20-222-7.compute-1.amazonaws.com/ssp/api/1/person/0a90940a-3e47-19e6-813e-47449e010000/transcript/currentcoursesfull
[18:45:04 CDT(-0500)] <js70> just a sec
[18:45:23 CDT(-0500)] <js70> http://ec2-23-20-222-7.compute-1.amazonaws.com/ssp/api/1/person/0a90940a-3e47-19e6-813e-47449e010000/transcript/currentcoursesfull
[18:46:16 CDT(-0500)] <js70> http://ec2-23-20-222-7.compute-1.amazonaws.com/ssp/api/1/person/0a90940a-3e47-19e6-813e-47449e010000/transcript/full
[18:46:21 CDT(-0500)] <js70> this works?
[18:46:42 CDT(-0500)] <JasonElwood>
[18:47:00 CDT(-0500)] <JasonElwood> transcriptfull works
[18:49:12 CDT(-0500)] <js70> k.
[18:51:51 CDT(-0500)] <JasonElwood> if we aren't ready to create a new branch today, we could wait until next week when the issues are closer to being done
[18:55:31 CDT(-0500)] <dmccallum54> sounds like we've got a number if things that need to be worked out before people start in earnest on new features
[18:55:47 CDT(-0500)] <dmccallum54> s/if/of/
[18:56:35 CDT(-0500)] <js70> whats your facultySchoolId?
[18:56:39 CDT(-0500)] <JasonElwood> 16 open, 5 IP, 4 re-opened
[18:57:27 CDT(-0500)] <js70> I'm calling get person to get the name of the faculty. bet thats the issue.
[18:58:38 CDT(-0500)] <JasonElwood> that's it
[18:59:20 CDT(-0500)] <js70> so, should I catch the exception and just leave facultyName null?
[18:59:45 CDT(-0500)] <JasonElwood> makes sense
[19:00:07 CDT(-0500)] <js70> k. i can do that and check it in. give me a few.
[19:00:17 CDT(-0500)] <JasonElwood> bad data. sorry
[19:05:56 CDT(-0500)] <js70> so thats the question. do we want to allow bad data for have the exception thrown? Currently whats the policy?
[19:07:50 CDT(-0500)] <JasonElwood> technically, it's bad data in that the instructor may not exist in the table. however, in practice that may occur frequently. if the instructor is no longer employed and the table is already loaded with the instructor id but not external_person, the same scenario could happen
[19:08:15 CDT(-0500)] <JasonElwood> schools may choose to only load new data
[19:09:21 CDT(-0500)] <js70> k. got the exception in. compiling and testing.
[19:09:28 CDT(-0500)] <JasonElwood> that shouldn't happen on the schedule tab, but since we are reading just from the transcript_course table, you never know
[19:09:42 CDT(-0500)] <JasonElwood> sweet
[19:09:53 CDT(-0500)] <JasonElwood> I anticipate brilliant code that works wonderfully
[19:12:31 CDT(-0500)] <JasonElwood> Dan- do you know the background on SSP-582, protecting the EAL student type?
[19:12:55 CDT(-0500)] <JasonElwood> is it related to adding a student who receives an early alert?
[19:14:34 CDT(-0500)] <dmccallum54> one sec pls
[19:15:23 CDT(-0500)] <dmccallum54> if i understand your question correctly, https://issues.jasig.org/browse/SSP-575 is the background
[19:16:37 CDT(-0500)] <JasonElwood> cool
[19:17:01 CDT(-0500)] <JasonElwood> protected against delete. I don't think we can protect from changing the name though. Like for IRSC
[19:17:26 CDT(-0500)] <dmccallum54> name change is ok
[19:18:16 CDT(-0500)] <dmccallum54> see the first modified file here… https://github.com/Jasig/SSP/commit/f11673eba584ea87e3e7ed20cd1f68087fc93ef3 … it's dependent on the UUID, not the name
[19:18:56 CDT(-0500)] <JasonElwood> right
[19:22:12 CDT(-0500)] <js70> just checked in last 2 I'm completing for this week.
[19:25:04 CDT(-0500)] <JasonElwood> I see the comments on print. so we're not adding a scroll.
[19:25:05 CDT(-0500)] <JasonElwood> ?
[19:32:47 CDT(-0500)] <js70> scroll will mess up the print out, my window is scrolling. what are you lookng at?
[19:33:19 CDT(-0500)] <JasonElwood> using firefox. I'll try Chrome. it's just a sized window
[19:59:24 CDT(-0500)] <js70> k. I'll fix the template and check it in as the same changeset. you'll have to delete the checksum