Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 23 Next »

[10:17:30 CDT(-0500)] <Arvids> hi
[10:17:37 CDT(-0500)] <EricDalquist> hello
[10:17:54 CDT(-0500)] <Arvids> i filed a JIRA ticket and also attached a patch: https://issues.jasig.org/browse/UP-3090
[10:18:10 CDT(-0500)] <EricDalquist> oh awesome!
[10:18:17 CDT(-0500)] <EricDalquist> I'll get the patch applied in a few mintues
[10:18:24 CDT(-0500)] <EricDalquist> and you got it in just in time for RC2
[10:18:28 CDT(-0500)] <EricDalquist> which will be coming out today
[10:18:28 CDT(-0500)] <Arvids> i'm starting a work in order to improve i18n support
[10:18:34 CDT(-0500)] <EricDalquist> thanks for all the testing Arvids!
[10:18:56 CDT(-0500)] <Arvids> ahh.. i also mailed to uportal-dev regarding DB issues
[10:19:13 CDT(-0500)] <EricDalquist> yup
[10:19:15 CDT(-0500)] <EricDalquist> got that fixed
[10:19:20 CDT(-0500)] <Arvids> sweet
[10:19:30 CDT(-0500)] <Arvids> now it's time to go home (smile)
[10:19:30 CDT(-0500)] <EricDalquist> hibernate changed how long text is handled from 3.3 to 3.6
[10:19:43 CDT(-0500)] <EricDalquist> and now postgres requires an explicit TX any time we touch a clob field
[10:19:49 CDT(-0500)] <EricDalquist> which is a little annoying
[10:19:52 CDT(-0500)] <Arvids> indeed
[10:20:01 CDT(-0500)] <EricDalquist> but I had just missed that one read api
[10:20:27 CDT(-0500)] <Arvids> i'll work hard on i18n support for the rest of the summer
[10:20:34 CDT(-0500)] <EricDalquist> great
[10:20:39 CDT(-0500)] <EricDalquist> we really appreciate the help
[10:20:53 CDT(-0500)] <EricDalquist> if you're interested we could likely get you setup with commit access
[10:20:54 CDT(-0500)] <Arvids> it's nice to give something back to communitiy (smile)
[10:21:14 CDT(-0500)] <Arvids> i feel better if someone reviews the changes
[10:21:49 CDT(-0500)] <Arvids> on the other hand... there'll be a ton of text translations
[10:22:15 CDT(-0500)] <Arvids> because i've spotted a lot of hard-coded text that must be externalized to messages.properties
[10:22:24 CDT(-0500)] <Arvids> and i believe i'll see even more
[10:22:26 CDT(-0500)] <EricDalquist> yeah
[10:22:32 CDT(-0500)] <EricDalquist> there are a lot of little places that need fixing
[10:22:39 CDT(-0500)] <EricDalquist> we';re also talking about moving to github
[10:22:48 CDT(-0500)] <Arvids> that would be great
[10:22:50 CDT(-0500)] <EricDalquist> so that would make it easier to do direct contributions as well
[10:23:08 CDT(-0500)] <EricDalquist> once 4.0 GA is out we'll probably make that switch
[10:23:17 CDT(-0500)] <Arvids> ok
[10:23:18 CDT(-0500)] <EricDalquist> this patch looks great btw
[10:23:46 CDT(-0500)] <Arvids> nice
[10:23:57 CDT(-0500)] <EricDalquist> just got it applied
[10:24:03 CDT(-0500)] <EricDalquist> RC2 should be out this afternoon
[10:24:10 CDT(-0500)] <EricDalquist> and then more testing
[10:24:20 CDT(-0500)] <EricDalquist> and hopefully a GA in two weeks
[10:24:44 CDT(-0500)] <EricDalquist> I have to run for a bit as well. back in ~ 90 minutes
[10:24:55 CDT(-0500)] <Arvids> ok
[10:25:05 CDT(-0500)] <Arvids> see you on monday with new patches (smile)
[12:23:38 CDT(-0500)] <EricDalquist> athena: you actually around?
[13:00:12 CDT(-0500)] <athena> heh, just woke up
[13:00:19 CDT(-0500)] <athena> going to run to the grocery store - nothing to eat here
[13:00:20 CDT(-0500)] <EricDalquist> (smile)
[13:00:27 CDT(-0500)] <athena> but will be back in a half hour or so to check in
[13:00:27 CDT(-0500)] <EricDalquist> working on rc2 right now
[13:00:31 CDT(-0500)] <athena> any issues?
[13:00:39 CDT(-0500)] <EricDalquist> just wanted to double check if there was anything I need to wait for from you
[13:00:58 CDT(-0500)] <athena> i need to check in a permissions portlet update
[13:01:01 CDT(-0500)] <athena> can do that when i get back
[13:01:04 CDT(-0500)] <athena> think that's it from me though
[13:01:04 CDT(-0500)] <EricDalquist> sounds good
[13:01:11 CDT(-0500)] <EricDalquist> I'm cutting a resource server release right now
[13:01:19 CDT(-0500)] <athena> cool (smile)
[13:01:30 CDT(-0500)] <athena> jeff and gary found some issue w/ css conditional includes in the skin plugin
[13:01:36 CDT(-0500)] <athena> told jeff to log into IRC to discuss
[13:01:42 CDT(-0500)] <EricDalquist> oh ...
[13:01:45 CDT(-0500)] <athena> but if we aren't able to connect i'll have him email the list
[13:01:45 CDT(-0500)] <EricDalquist> hrm
[13:01:51 CDT(-0500)] <EricDalquist> be nice to get them in there for this
[13:01:55 CDT(-0500)] <athena> basically just the "if IE 6" thing only works for IE6
[13:01:56 CDT(-0500)] <athena> yeah
[13:01:58 CDT(-0500)] <EricDalquist> ah
[13:02:03 CDT(-0500)] <athena> think he'll probably log in at some point
[13:02:07 CDT(-0500)] <EricDalquist> ok
[13:02:14 CDT(-0500)] <athena> anyway, not an RC blocker, just wanted to give you a heads up
[13:02:18 CDT(-0500)] <athena> ok, back soonish . . .
[13:02:21 CDT(-0500)] <EricDalquist> yup
[13:53:19 CDT(-0500)] <athena> ok, checked in (smile)
[13:53:22 CDT(-0500)] <athena> anything else you need from me?
[13:53:29 CDT(-0500)] <athena> are we ready for the RC or still more stuff to go?
[13:53:30 CDT(-0500)] <EricDalquist> I don't think so
[13:53:41 CDT(-0500)] <EricDalquist> just about to do the resource server release
[13:53:44 CDT(-0500)] <athena> nice (smile)
[13:53:48 CDT(-0500)] <EricDalquist> and then I can do the uportal release
[13:53:51 CDT(-0500)] <athena> sweet!
[13:53:53 CDT(-0500)] <athena> that's great news (smile)
[13:54:00 CDT(-0500)] <athena> super exciting
[13:54:06 CDT(-0500)] <EricDalquist> yup
[15:03:10 CDT(-0500)] <jeffbcross> register 66HL4LUE6W middlefloor@gmail.com
[15:32:35 CDT(-0500)] <jeffbcross> @EricDalquist, have you has any experience trying to incroporate xsl:comment into the transformation process?
[15:32:54 CDT(-0500)] <EricDalquist> hrm, not in recent memory
[15:33:10 CDT(-0500)] <EricDalquist> are you trying to get a comment appear in the final markup?
[15:33:20 CDT(-0500)] <jeffbcross> I was attempting to do that yesterday to get Internet Explorer CSS implemented
[15:33:26 CDT(-0500)] <jeffbcross> so, yes, in the final markup
[15:33:36 CDT(-0500)] <jeffbcross> such as:
[15:33:36 CDT(-0500)] <jeffbcross> <xsl:comment><![CDATA[[if IE]>
[15:33:36 CDT(-0500)] <jeffbcross>            <style type="text/css">
[15:33:36 CDT(-0500)]

<jeffbcross>                div#portalPageBodyColumns .fl-container-flex50

Unknown macro: { width}

[15:33:36 CDT(-0500)]

<jeffbcross>                div#portalPageBodyColumns .fl-container-flex25

Unknown macro: { width}

[15:33:37 CDT(-0500)] <jeffbcross>               </style>
[15:33:37 CDT(-0500)] <jeffbcross>        <![endif]]]></xsl:comment>
[15:34:03 CDT(-0500)] <EricDalquist> and this is in the theme xsl?
[15:34:25 CDT(-0500)] <jeffbcross> it was in page.xsl of the theme
[15:35:06 CDT(-0500)] <jeffbcross> I was able to make static changes, and see them reflected
[15:35:19 CDT(-0500)] <jeffbcross> but the comment wouldn't render
[15:35:45 CDT(-0500)] <jeffbcross> also tested the xsl:comment successfully with static xslt
[15:36:11 CDT(-0500)] <EricDalquist> what do you mean "static xslt"?
[15:36:30 CDT(-0500)] <jeffbcross> just a static xml and static xslt on my computer in the browser, outside of uPortal
[15:36:33 CDT(-0500)] <EricDalquist> ah ok
[15:37:26 CDT(-0500)] <EricDalquist> also athena mentioned an issue with conditionals in the resource server?
[15:37:34 CDT(-0500)] <EricDalquist> so for additional testing
[15:37:36 CDT(-0500)] <EricDalquist> in uportal-war/src/main/webapp/WEB-INF/log4j.properties
[15:37:47 CDT(-0500)] <EricDalquist> add:
[15:37:47 CDT(-0500)] <EricDalquist> log4j.logger.org.jasig.portal.rendering.LoggingStAXComponent.POST_THEME=DEBUG, R
[15:37:47 CDT(-0500)] <EricDalquist> log4j.additivity.org.jasig.portal.rendering.LoggingStAXComponent.POST_THEME=false
[15:37:55 CDT(-0500)] <EricDalquist> that will log the XML that comes out of the theme transform
[15:38:04 CDT(-0500)] <EricDalquist> and check to see if the comments are included in that output
[15:38:11 CDT(-0500)] <jeffbcross> okay
[15:38:14 CDT(-0500)] <EricDalquist> it could be an issue with the transformer config
[15:38:35 CDT(-0500)] <jeffbcross> yes, I tried conditionals in site.xml <css conditional="if IE">ie.css</css>
[15:39:04 CDT(-0500)] <EricDalquist> what was the problem there? we should make sure to get whatever it was fixed
[15:41:00 CDT(-0500)] <jeffbcross> not sure the problem, athena's theory was that it had only been keyed for ie6
[15:41:24 CDT(-0500)] <EricDalquist> hrm

  • No labels