[07:57:11 CST(-0600)] <Arvids> EricDalquist, are you here?
[07:57:21 CST(-0600)] <EricDalquist> yes
[07:57:22 CST(-0600)] <EricDalquist> kinda
[07:57:31 CST(-0600)] <EricDalquist> have the day off today
[07:57:42 CST(-0600)] <EricDalquist> but I figured I'd come and lurk since I knew you were working
[07:57:48 CST(-0600)] <Arvids> i saw your commit regarding @RequestCache
[07:58:06 CST(-0600)] <EricDalquist> yeah, it doesn't solve the xpath problem but it does mitigate it a bit
[07:58:24 CST(-0600)] <EricDalquist> on those xpath related methods it has about a 65% hit rate
[07:58:34 CST(-0600)] <EricDalquist> could be useful other places as well
[07:58:39 CST(-0600)] <Arvids> ahh... ok... i was wondering - maybe I should define some kinde of interface whose implementations could mimic the XPath expressions
[07:59:15 CST(-0600)] <Arvids> and use those implementations instead of my currently offered code
[07:59:21 CST(-0600)] <EricDalquist> well I'd be interested if you re-test to see how much time that xpath work is still taking
[07:59:24 CST(-0600)] <EricDalquist> right
[07:59:35 CST(-0600)] <EricDalquist> the other thing would be just to move that logic you have into the single tab helper class
[07:59:48 CST(-0600)] <EricDalquist> get the layout DOM from the user layout manager
[07:59:56 CST(-0600)] <EricDalquist> and do the traversal
[08:00:06 CST(-0600)] <Arvids> that one particular helper could be an implementation of that interface
[08:00:29 CST(-0600)] <EricDalquist> yeah, that seems reasonable
[08:00:43 CST(-0600)] <Arvids> I´ll now do another pull request
[08:00:49 CST(-0600)] <Arvids> please, review the code
[08:01:00 CST(-0600)] <EricDalquist> really your previous patch was functionally good it just needed to be redistributed a bit so that the functionality was correctly plugable
[08:01:24 CST(-0600)] <EricDalquist> will do 
[08:02:12 CST(-0600)] <Arvids> https://github.com/agrabovskis/uPortal/commit/666d1c6549d739e006b2429943be6c8a416fa3f7
[08:02:52 CST(-0600)] <Arvids> hmm... github says that master branch is already up-to-date
[08:03:27 CST(-0600)] <EricDalquist> when trying to do a pull?
[08:03:59 CST(-0600)] <Arvids> lol - it incorporated the second commit although I pushed it after pull request... didn´t know such behaviour
[08:04:09 CST(-0600)] <EricDalquist> weird
[08:04:22 CST(-0600)] <EricDalquist> either did I