[11:15:49 CDT(-0500)] <EricDalquist> athena / drewwills which one of you cut web proxy 1.1.7?
[11:16:09 CDT(-0500)] <drewwills> hmm... let me look
[11:20:12 CDT(-0500)] <drewwills> well, i thought it might be me... but it doesn't look that way: https://github.com/Jasig/WebproxyPortlet/commits/master
[11:20:22 CDT(-0500)] <EricDalquist> ah ok
[11:20:44 CDT(-0500)] <EricDalquist> athena: when you're around I think you need to push the webproxy 1.1.7 tag to github
[11:32:07 CDT(-0500)] <athena> oh!
[11:32:18 CDT(-0500)] <athena> i guess i just pushed the commit, not the tag?
[11:33:07 CDT(-0500)] <athena> sorry about that
[11:33:11 CDT(-0500)] <EricDalquist> yeah
[11:33:12 CDT(-0500)] <athena> i need to write myself a checklist, i think
[11:33:15 CDT(-0500)] <EricDalquist> no problem
[11:33:22 CDT(-0500)] <EricDalquist> I think it is listed on the uportal release process?
[11:34:11 CDT(-0500)] <athena> that sounds plausible
[11:34:17 CDT(-0500)] <athena> in which case i should go find and bookmark that page
[11:34:30 CDT(-0500)] <athena> is the command i want just "git push --tags"?
[11:38:12 CDT(-0500)] <EricDalquist> yeah
[11:38:15 CDT(-0500)] <EricDalquist> that pushes all tages
[11:38:26 CDT(-0500)] <EricDalquist> or "git push upstream tagname"
[11:38:29 CDT(-0500)] <athena> ok, should be all set
[11:38:30 CDT(-0500)] <EricDalquist> to push a specific tag
[11:38:32 CDT(-0500)] <athena> sorry about that again
[11:38:33 CDT(-0500)] <athena> gotta run
[11:38:36 CDT(-0500)] <athena> will be checking email
[13:19:22 CDT(-0500)] <EricDalquist> and I just found a spring bug ...
[14:25:34 CDT(-0500)] <jwennmacher> cool ... do share
[14:25:53 CDT(-0500)] <EricDalquist> ordering of spring annotation handlers
[14:26:00 CDT(-0500)] <EricDalquist> their compare impl is broken
[14:26:15 CDT(-0500)] <EricDalquist> in this case a portlet has 6 handler methods
[14:26:18 CDT(-0500)] <EricDalquist> that end up in a list like [ren, res, ren, res, ren, res]
[14:26:23 CDT(-0500)] <EricDalquist> problem is when it compares handlers of different types is returns 0
[14:26:28 CDT(-0500)] <EricDalquist> and with them alternating the merge sort never compares handlers of the same type
[14:26:32 CDT(-0500)] <EricDalquist> so it assumes the list is in order
[14:26:41 CDT(-0500)] <EricDalquist> when the render handlers are in the wrong order
[14:26:46 CDT(-0500)] <EricDalquist> so all requests go to the least-qualified handler
[14:26:49 CDT(-0500)] <EricDalquist> instead of the most
[14:27:20 CDT(-0500)] <EricDalquist> I've verified it in spring's unit tests
[14:27:22 CDT(-0500)] <EricDalquist> writing a fix now
[14:27:27 CDT(-0500)] <EricDalquist> and submitting a pull soon
[14:27:39 CDT(-0500)] <EricDalquist> then going to see if we can figure out a local fix until they get a patch ouit