Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[10:34:54 CDT(-0500)] <EricDalquist> yes it 2k right now

[10:35:25 CDT(-0500)] <EricDalquist> and yes that should be enough

[10:36:22 CDT(-0500)] <jgribonvald> so how do you prefer that i do ?

[10:36:25 CDT(-0500)] <jgribonvald> I define a paremeter "alternativeMaximixedLink" for all portlets that will be an alternative url to open in a new browser window when the user want to render it in "MAXIMIZED" view ?

[10:36:38 CDT(-0500)] <EricDalquist> that sounds perfect

[10:36:57 CDT(-0500)] <jgribonvald> ok so i will do that in this way

[10:39:03 CDT(-0500)] <jgribonvald> I just hope that my changes in UrlSyntaxProviderImpl.java will be good, I'm not really familiar with the uses of thsi class

[10:39:10 CDT(-0500)] <jgribonvald> let see in my PR so (wink)

[10:40:36 CDT(-0500)] <EricDalquist> (smile)

[10:40:49 CDT(-0500)] <EricDalquist> well I'm getting tlev introduced to doing uPortal releases

[10:40:59 CDT(-0500)] <EricDalquist> so he and I can review them together in the next few days

[10:41:49 CDT(-0500)] <jgribonvald> ok thx

[10:42:29 CDT(-0500)] <jgribonvald> else for all my PR do you want that i create a JIRA, maybe it's better for you to follow the feature ?

[10:42:40 CDT(-0500)] <EricDalquist> well we need a jira and a PR

[10:42:45 CDT(-0500)] <EricDalquist> we can create the jira for you if you don't

[10:43:09 CDT(-0500)] <jgribonvald> ok, so i will take a look for that when i will a some time so

[10:44:53 CDT(-0500)] <jgribonvald> it's better to talk about some things, because for one feature (sidebar elements) I'm not entirely satisfied, this feature could be improved

[10:45:14 CDT(-0500)] <jgribonvald> but I don't know how to do more

[10:45:15 CDT(-0500)] <EricDalquist> ok

[10:46:04 CDT(-0500)] <jgribonvald> my PR is like a sandbox feature

[10:46:17 CDT(-0500)] <jgribonvald> but it works

[10:46:22 CDT(-0500)] <EricDalquist> good to know, we will keep that in mind when reviewing it

[10:46:42 CDT(-0500)] <jgribonvald> ok thx

[10:47:09 CDT(-0500)] <jgribonvald> don't hesitate to comment in github to talk about it (wink)

[10:47:22 CDT(-0500)] <EricDalquist> will do

[10:50:08 CDT(-0500)] <jgribonvald> my thought about this feature would be about to build an internal portlet, that could be in the middle of navigation links and bookmarks that the user/fragment-template could add in

[10:50:57 CDT(-0500)] <jgribonvald> a such thing would be great in my mind, but I don't have time and ressources to make it