Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Memory Leak in TicketGrantingTicketImpl

Description

TicketGrantingTicketImpl contains a hashmap of services (service by id). This references are used to logout from all services which have been used in case the TGT expire(s). Only in case of the expire these pairs (id, service) are released.

Problem is that the id used to store a service in the hashmap is the service ticket id. It is generated in CentralAuthenticationServiceImpl.grantServiceTicket

... final ServiceTicket serviceTicket = ticketGrantingTicket .grantServiceTicket(serviceTicketUniqueTicketIdGenerator .getNewTicketId(ServiceTicket.PREFIX), service, this.serviceTicketExpirationPolicy, credentials != null); this.serviceTicketRegistry.addTicket(serviceTicket);

That means the TGT services hashmap contains one entry per Service Ticket which was created during the live time of the TGT. With long RememberMe times this causes TGT to consume substantial memory. In our case with web page = service we end up with approx. 1MByte per TGT after 10-20days.

I propose to introduce an explicit logout url per service and use it instead of the ST id to store the service. This would allow to have one logout per service e.g. webapp in our case.

Environment

None

Activity

Show:

Misagh MoayyedJuly 15, 2014 at 7:10 AM

All Open JIRA issues are now moved to Github, and tracked under Github Issues. The migration is now complete. Please use Github issue tracking to file and track issues. JIRA issues will be closed.

The URL address for Github issues of the CAS project is:
https://github.com/Jasig/cas/issues

Proposal Declined

Details

Assignee

Reporter

Components

Affects versions

Priority

Created January 27, 2014 at 7:54 PM
Updated July 15, 2014 at 7:10 AM
Resolved July 15, 2014 at 7:10 AM

Flag notifications