[10:05:53 CDT(-0500)] <jgribonvald> hi everybody
[10:06:24 CDT(-0500)] <jgribonvald> I'm looking on https://issues.jasig.org/browse/UP-3760
[10:06:33 CDT(-0500)] <jgribonvald> and I have some questions
[10:06:48 CDT(-0500)] <jgribonvald> and maybe need some help
[10:43:36 CDT(-0500)] <EricDalquist> hi jgribonvald
[10:43:46 CDT(-0500)] <jgribonvald> hi EricDalquist
[10:44:36 CDT(-0500)] <jgribonvald> did you watch on https://issues.jasig.org/browse/UP-3760 ?
[10:44:57 CDT(-0500)] <EricDalquist> looking at it now
[10:45:04 CDT(-0500)] <jgribonvald> ok
[10:45:11 CDT(-0500)] <jgribonvald> i will wait so
[10:46:04 CDT(-0500)] <EricDalquist> I think the change looks good
[10:46:10 CDT(-0500)] <EricDalquist> but there are a lot of whitespace changes
[10:46:13 CDT(-0500)] <EricDalquist> which make it hard to read
[10:46:26 CDT(-0500)] <jgribonvald> yes i can't do things better
[10:46:45 CDT(-0500)] <jgribonvald> my development env delete all useless whitespaces
[10:46:53 CDT(-0500)] <jgribonvald> when i edit a file
[10:46:54 CDT(-0500)] <EricDalquist> ah, you can't turn that off?
[10:47:29 CDT(-0500)] <EricDalquist> I mean I agree with cleaning up whitespace issues
[10:47:38 CDT(-0500)] <EricDalquist> so one thing you could do in the future
[10:47:42 CDT(-0500)] <EricDalquist> is fix the whitespace
[10:47:43 CDT(-0500)] <EricDalquist> commit
[10:47:47 CDT(-0500)] <EricDalquist> then make the actual change
[10:47:59 CDT(-0500)] <EricDalquist> then we have two commits, one with the whitespace changes and one with the content change
[10:48:04 CDT(-0500)] <EricDalquist> that makes merging a lot easier
[10:48:28 CDT(-0500)] <jgribonvald> ok i will wtach on that for futur so
[10:48:47 CDT(-0500)] <jgribonvald> So my pull solve the "bug"
[10:48:56 CDT(-0500)] <jgribonvald> but not the user UI
[10:49:02 CDT(-0500)] <EricDalquist> ok
[10:49:08 CDT(-0500)] <jgribonvald> where some things could be done
[10:49:11 CDT(-0500)] <EricDalquist> yeah
[10:49:17 CDT(-0500)] <EricDalquist> well the UI I'm not as familiar with
[10:49:39 CDT(-0500)] <jgribonvald> my PR push a way to do things like sending message
[10:50:13 CDT(-0500)] <EricDalquist> yeah
[10:50:20 CDT(-0500)] <EricDalquist> so we can get that merged
[10:50:21 CDT(-0500)] <jgribonvald> like "portlet Added" or "can't add portlet" or "can't save layout"
[10:50:41 CDT(-0500)] <jgribonvald> but my problem now
[10:50:51 CDT(-0500)] <jgribonvald> is to show these messages to the user
[10:51:22 CDT(-0500)] <jgribonvald> and/or a way to activate/disable the Add portlet
[10:51:56 CDT(-0500)] <jgribonvald> for current tab that are locked
[10:52:24 CDT(-0500)] <jgribonvald> for messages it's not a big difficult, but what is the best ?