[10:43:02 CDT(-0500)] <athena> morning EricDalquist
[10:43:07 CDT(-0500)] <EricDalquist> morning
[10:43:10 CDT(-0500)] <athena> sounds like the google visualization ticket got resolved
[10:43:20 CDT(-0500)] <athena> though don't know if you have opinions that vs. d3
[10:44:14 CDT(-0500)] <EricDalquist> I haven't had a chance to look
[11:52:00 CDT(-0500)] <b-sure> hello uMobile devs: hello athena. I think I have the shib ecp login ready to submit the pull request on git hub. it spans more than one commit. do you know how I should submit the pull request?
[11:52:40 CDT(-0500)] <athena> that should be fine
[11:52:50 CDT(-0500)] <athena> the best thing to do is have all your commits in a single branch
[11:53:03 CDT(-0500)] <athena> should be able to follow the jasig git workflow instructions from there
[11:53:09 CDT(-0500)] <b-sure> I think they are all in my forked master branch
[11:53:29 CDT(-0500)] <athena> maybe copy them to a branch?
[11:53:57 CDT(-0500)] <athena> you can still send a pull request from your master branch, but then you'll be blocked from doing any further commits to it until we review and accept the changes into the main project
[11:54:02 CDT(-0500)] <athena> so really probably best to do the branch approach
[11:54:44 CDT(-0500)] <b-sure> ok. so I do have a local branch with all of the commits. but I'm not sure how to push that to my forked repo on github.
[11:55:56 CDT(-0500)] <b-sure> ok. i think is see it here https://wiki.jasig.org/display/UPC/Git+Workflow
[12:04:22 CDT(-0500)] <athena> yeah
[12:04:28 CDT(-0500)] <athena> those instructions are pretty helpful
[12:04:32 CDT(-0500)] <athena> but if you get stuck let me know 
[12:04:45 CDT(-0500)] <b-sure> thanks. I just submitted it.
[12:05:22 CDT(-0500)] <b-sure> So we are debugging the post authentication behavior of uMobile and are running into an issue in PortalWindowController.js