uPortal IRC Logs-2009-07-01

Owned by Apereo Infrastructure
Last updated: Jul 01, 2009Version comment
4 min read

[03:10:51 EDT(-0400)] * higmad (n=chatzill@pcit-8752.hig.se) has joined ##uportal
[08:52:48 EDT(-0400)] * jessm (n=Jess@c-71-232-1-65.hsd1.ma.comcast.net) has joined ##uportal
[08:54:47 EDT(-0400)] * athena (n=athena@99.129.100.66) has joined ##uportal
[10:18:39 EDT(-0400)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined ##uportal
[11:04:40 EDT(-0400)] * holdorph (n=holdorph@uni1.unicon.net) has joined ##uportal
[11:08:32 EDT(-0400)] * lennard1 (n=sparhk@wsip-98-174-242-39.ph.ph.cox.net) has joined ##uportal
[11:12:06 EDT(-0400)] <athena> EricDalquist: you don't happen to have any thoughts on the portal's multi-profile stuff, do you?
[11:12:33 EDT(-0400)] <EricDalquist> I haven't had a chance to look at it yet
[11:12:36 EDT(-0400)] <EricDalquist> :/
[11:15:09 EDT(-0400)] <athena> no worrie
[11:15:22 EDT(-0400)] <athena> i just wanted to make sure to check (smile)
[11:15:33 EDT(-0400)] <athena> i think dmazurek will probably do some work on that in the near future
[11:15:43 EDT(-0400)] <EricDalquist> ok
[11:16:05 EDT(-0400)] <athena> it'd be really nice if that stuff actually worked in the future
[11:16:10 EDT(-0400)] <athena> (smile)
[11:17:36 EDT(-0400)] <EricDalquist> I'm finally getting back to finishing up the chandef <-> portletdef relationship in jpa
[11:17:47 EDT(-0400)] <EricDalquist> working on the unit tests now
[11:17:54 EDT(-0400)] <athena> oh awesome
[11:18:10 EDT(-0400)] <athena> at the moment, i'm working on integrating dmazurek's patch for the portlet lifecycle stuff
[11:18:25 EDT(-0400)] <athena> so we can mark channels as set to expire at a certain date and such
[11:18:38 EDT(-0400)] <EricDalquist> neat
[11:19:00 EDT(-0400)] <athena> we'll have to talk later about how to handle channel imports and such, but i can email the list later about that
[11:19:03 EDT(-0400)] <athena> nothing urgent
[11:47:52 EDT(-0400)] * lennard1 (n=sparhk@wsip-98-174-242-39.ph.ph.cox.net) has joined ##uportal
[12:51:58 EDT(-0400)] <EricDalquist> athena: in the new portlet manager should the review screen show portlet preferences that were entered?
[12:52:05 EDT(-0400)] <athena> yes
[12:52:08 EDT(-0400)] <athena> are they not?
[12:52:24 EDT(-0400)] <EricDalquist> they are not but I think I may have broke something with my work
[12:52:28 EDT(-0400)] <athena> ok
[12:52:40 EDT(-0400)] <EricDalquist> I'm just trying to track down where they should be displaying in theJSP
[12:52:47 EDT(-0400)] <athena> how were they entered? portlet params, pre-defined portlet preferences, or arbitrary portlet prefs?
[12:52:48 EDT(-0400)] <athena> ah
[12:52:57 EDT(-0400)] <athena> are they in the edit screen?
[12:53:00 EDT(-0400)] <EricDalquist> arbitrary portlet prefs
[12:53:07 EDT(-0400)] <EricDalquist> they are there when I go to edit parameters
[12:53:11 EDT(-0400)] <EricDalquist> and they are stored correctly
[12:53:18 EDT(-0400)] <EricDalquist> just not showing up in the review screen
[12:53:23 EDT(-0400)] <athena> oh, weird
[12:53:26 EDT(-0400)] <athena> ok, i can take a look at that
[12:53:33 EDT(-0400)] <athena> that sounds like my fault, not yours (smile)
[12:53:36 EDT(-0400)] <EricDalquist> should I just commit it as is then?
[12:53:38 EDT(-0400)] <EricDalquist> well no
[12:53:40 EDT(-0400)] <athena> yeah, go ahead
[12:53:51 EDT(-0400)] <EricDalquist> I'm not sure if it did work before I made my changes
[12:53:56 EDT(-0400)] <athena> oh, did something change w/ the preference API?
[12:54:14 EDT(-0400)] <EricDalquist> so now there is IChannelDefinition.getPortletDefinition()
[12:54:18 EDT(-0400)] <EricDalquist> which then gets you to the prefs
[12:54:26 EDT(-0400)] <EricDalquist> instead of the prefs APIs right on the IChannelDefinition
[12:54:30 EDT(-0400)] <athena> oh ok
[12:54:33 EDT(-0400)] <EricDalquist> so I'm wondering if that has to do with it
[12:54:39 EDT(-0400)] <athena> yeah, probably
[12:54:44 EDT(-0400)] <athena> but hopefully shouldn't be too hard to fix
[12:54:58 EDT(-0400)] <EricDalquist> like I refactored some Java code but missed a JSP
[12:55:29 EDT(-0400)] <EricDalquist> well I have a little more to do
[12:55:35 EDT(-0400)] <EricDalquist> but if I don't figure it out I'll let you know (smile)
[12:56:52 EDT(-0400)] <athena> sure
[12:56:56 EDT(-0400)] <athena> i'll be around (smile)
[12:57:10 EDT(-0400)] <EricDalquist> sounds good
[12:57:37 EDT(-0400)] <athena> ok, i'm committing the first part of the lifecycle stuff
[12:57:40 EDT(-0400)] <athena> doesn't persist yet
[12:57:45 EDT(-0400)] <athena> but it shows up
[12:57:50 EDT(-0400)] <EricDalquist> sounds good
[13:33:38 EDT(-0400)] <EricDalquist> athena: where in uportal-war/src/main/webapp/WEB-INF/flows/edit-portlet/reviewPortlet.jsp are portlet preferences displayed?
[13:34:16 EDT(-0400)] <athena> hang on - let me take a look
[13:34:46 EDT(-0400)] <athena> hm, perhaps it doesn't!
[13:34:52 EDT(-0400)] <athena> i don't see anything there either EricDalquist
[13:35:11 EDT(-0400)] <EricDalquist> ok
[13:35:17 EDT(-0400)] <EricDalquist> so maybe I'm not crazy then (smile)
[13:35:24 EDT(-0400)] <athena> nope
[13:35:32 EDT(-0400)] <athena> there should be something iterating on the arbitrary preferences
[13:35:50 EDT(-0400)] <EricDalquist> ok
[13:35:53 EDT(-0400)] <athena> that JSP is so ugly
[13:35:59 EDT(-0400)] <EricDalquist> well I'll clean things up and commit then
[13:36:10 EDT(-0400)] <EricDalquist> and just open a jira about not reviewing arbitrary prefs
[13:36:27 EDT(-0400)] <athena> sure
[13:36:31 EDT(-0400)] <athena> i'll make sure that gets fixed
[13:36:39 EDT(-0400)] <EricDalquist> sounds good
[13:36:43 EDT(-0400)] <athena> can you add it as a sub-task of UP-2047?
[13:37:05 EDT(-0400)] <EricDalquist> sure
[13:37:06 EDT(-0400)] <athena> i think that'll make it easier for us to keep track of
[13:37:11 EDT(-0400)] <athena> and i'll make sure either drew or i fix it
[13:37:12 EDT(-0400)] <athena> thanks (smile)
[13:38:19 EDT(-0400)] <athena> looking over dmazurek's patch now for replacing ChannelRegistryManager
[13:38:20 EDT(-0400)] * athena cheers
[13:38:36 EDT(-0400)] <athena> i guess we'll probably leave it in place for now for the DLMUserPreferences channel
[13:38:41 EDT(-0400)] <athena> we can't really kill that thing, unfortunately
[13:38:46 EDT(-0400)] <EricDalquist> (sad)
[13:38:51 EDT(-0400)] <EricDalquist> at least not yet
[13:38:58 EDT(-0400)] <EricDalquist> at least mark it @Deprecated
[13:39:35 EDT(-0400)] <athena> well, we can't even do that
[13:39:49 EDT(-0400)] <athena> because we don't have any other way for fragment owners to set DLM restrictions
[13:39:55 EDT(-0400)] <athena> and tab names and such
[13:40:02 EDT(-0400)] <EricDalquist> mark ChannelRegistryManager deprecated that is
[13:40:21 EDT(-0400)] <athena> oh, gotcha (smile)
[14:10:23 EDT(-0400)] * [jlee] (n=jlee@adsl-070-148-252-002.sip.asm.bellsouth.net) has joined ##uportal
[14:18:48 EDT(-0400)] * Sememmon (n=Sememmon@uni1.unicon.net) has joined ##uportal
[15:04:21 EDT(-0400)] <EricDalquist> committing port/chan updates
[15:07:49 EDT(-0400)] <EricDalquist> ok all set
[15:08:04 EDT(-0400)] <EricDalquist> you'll need to do an initdb after updating
[15:09:16 EDT(-0400)] <EricDalquist> and created http://www.ja-sig.org/issues/browse/UP-2460
[15:12:35 EDT(-0400)] <athena> sounds great, thanks!
[15:13:05 EDT(-0400)] <EricDalquist> so I think everything jpa managed now has correct relationships
[18:48:26 EDT(-0400)] * lennard1 (n=sparhk@wsip-98-174-242-39.ph.ph.cox.net) has joined ##uportal
[20:06:14 EDT(-0400)] * lennard1 (n=sparhk@wsip-98-174-242-39.ph.ph.cox.net) has left ##uportal
[22:34:17 EDT(-0400)] * Sememmon (n=Sememmon@ip70-190-32-223.ph.ph.cox.net) has joined ##uportal
[23:20:46 EDT(-0400)] * fj4000 (n=Main@CPE0018f85ab63e-CM001692f5798c.cpe.net.cable.rogers.com) has joined ##uportal