LoginController thoughts

  protected ModelAndView processFormSubmission(final HttpServletRequest request, final HttpServletResponse response, final Object object,
        final BindException errors) throws Exception {
        final Credentials credentials = (Credentials)object;
        
        this.credentialsBinder.bind(request, credentials);

        final String ticketGrantingTicketId = this.centralAuthenticationService.createTicketGrantingTicket(credentials);
        ...

  protected ModelAndView processFormSubmission(final HttpServletRequest request, final HttpServletResponse response, final Object object,
        final BindException errors) throws Exception {
        final Credentials credentials = (Credentials)object;
        
        this.credentialsBinder.bind(request, credentials);

        final String ticketGrantingTicketId = this.centralAuthenticationService.createTicketGrantingTicket(credentials);
        ...

/**
 * Interface for a class that can bind items stored in the request to a particular
 * credentials implementation.  This allows for binding beyond the basic
 * JavaBean/Request parameter binding that is handled by Spring automatically.
 */
public interface CredentialsBinder {
    /**
    * Method to allow manually binding attributes from the request object to properties of
    * the credentials.  Useful when there is no mapping of attribute to property for the 
    * usual Spring binding to handle.
    * 
    * @param request The HttpServletRequest from which we wish to bind credentials to
    * @param credentials The credentials we will be doing custom binding to.
    */
    void bind(HttpServletRequest request, Credentials credentials);
	
    /**
    * 
    * Method to determine if a CredentialsBinder supports a specific class or not.
    * 
    * @param clazz The class to determine is supported or not
    * @return true if this class is supported by the CredentialsBinder, false otherwise.
    */
    boolean supports(Class clazz);
}

/**
 * Interface for components that know how to extract from HttpServletRequest
 * whatever it is that constitutes actual arguments of the request for authentication.
 */
public interface RequestToCredentials {

    /**
     * Parse an HttpServletRequest and extract from it whatever it is that is necessary as input to the AuthenticationHandler
     * which will examine the request for authentication represented by the HttpServletRequest. Return an Object
     * encapsulating that extracted information.  Specific implementations will return specific objects which in turn specific
     * AuthenticationHandler implementations will expect and consume.
     * @returns an object representing the relevant information for the authentication request
     * @throws RuntimeException - indicates failure
     */
   Object credentialsFromHttpServletRequest(HttpServletRequest httpServletRequest);

   /**
    * Returns true if authenticationRequestFromHttpServletRequest() will return an Object for the given
    * argument.  Returns false if this other method will throw a RuntimeException for the given argument.
    *
    * This method exists to allow a client of this class to efficiently determine whether it should use this
    * RequestToCredentials or whether doing so will only throw an exception.
    */
   boolean supports(HttpServletRequest httpServletRequest);

}

protected Object getCommand(HttpServletRequest request) throws Exception {
    return createCommand();
}

protected Object getCommand(HttpServletRequest request) throws Exception {
    return this.requestToCredentials.credentialsFromHttpServletRequest(request);
}

protected final Object getCommand(HttpServletRequest request) throws Exception {
    if (!isSessionForm()) {
        return formBackingObject(request);
    }
    HttpSession session = request.getSession(false);
        if (session == null) {
            throw new ServletException("Must have session when trying to bind");
        }
        Object formObject = session.getAttribute(getFormSessionAttributeName());
        session.removeAttribute(getFormSessionAttributeName());
        if (formObject == null) {
            throw new ServletException("Form object not found in session");
        }
    return formObject;
}

protected Object formBackingObject(HttpServletRequest request) throws Exception {
    return createCommand();
}

    protected ModelAndView processFormSubmission(final HttpServletRequest request, final HttpServletResponse response, final Object object,
        final BindException errors) throws Exception {
        final Credentials credentials = (Credentials)object;
        
        this.credentialsBinder.bind(request, credentials);

        final String ticketGrantingTicketId = this.centralAuthenticationService.createTicketGrantingTicket(credentials);
        final String service = request.getParameter(WebConstants.SERVICE);
        final boolean warn = StringUtils.hasText(request.getParameter(WebConstants.WARN));

public class LoginForm {
    private String service;
    private boolean warn;
    
    /** 
     * Set the Service to which the requestor seeks to authenticate.
     */
    public void setService(String service) {
        this.service = service;
    }

    /**
     * Set whether the user would like to be warned upon Single Sign On to subsequent services.
     */
    public void setWarn(boolean warn) {
        this.warn = warn;
    }

 ... and corresponding getters

}

 

 protected ModelAndView processFormSubmission(final HttpServletRequest request, final HttpServletResponse response, final Object object,
        final BindException errors) throws Exception {
        final LoginForm loginForm = (LoginForm) object;
        
        final Object credentials = this.requestToCredentials.credentialsFromHttpServletRequest(request);

        final String ticketGrantingTicketId = this.centralAuthenticationService.createTicketGrantingTicket(credentials);