[10:47:17 CDT(-0500)] <TonyUnicon> fun fact about hibernate, eagerly loading OneToMany child entities will impact search results (in the form of duplicates)
[10:53:30 CDT(-0500)] <dmccallum541> hmmmm…. specifying either DistinctResultTransformer or DistinctRootEntityResultTransformer doesn't help?
[10:55:19 CDT(-0500)] <dmccallum541> i think you'll see that going on in a few places
[10:55:25 CDT(-0500)] <dmccallum541> stuff like… criteria.setResultTransformer(Criteria.DISTINCT_ROOT_ENTITY);
[10:55:32 CDT(-0500)] <dmccallum541> but i may be misunderstanding the issue
[11:06:50 CDT(-0500)] <JasonElwood> for external_course and external_course_term, is the code column at 20 char enough characters?
[11:09:44 CDT(-0500)] <JasonElwood> I spec'd 35 characters, but the db has 20. If we all think that is enough, then I can just change the spec
[11:13:36 CDT(-0500)] <dmccallum541> so
[11:14:12 CDT(-0500)] <dmccallum541> that field would usually be something like <formatted_course>_<qualifier>, right?
[11:14:40 CDT(-0500)] <dmccallum541> either that or some other synthetic ID that's totally opaque and generated by the institution
[11:15:43 CDT(-0500)] <dmccallum541> if the former it would have to be at least 35+n, where n is something we'd have to guess at for a typical <qualifier> len. when we've done that before for section_number we used '10'. so that would be 45 minimum for course_code
[11:16:08 CDT(-0500)] <dmccallum541> 46, rather, if we assume at least 1 char delim
[11:18:42 CDT(-0500)] <dmccallum541> so since we dont actually know wtf anyone is going to use, how about 64
[11:21:02 CDT(-0500)] <JasonElwood> fine with me
[11:44:34 CDT(-0500)] <JasonElwood> who wants a Jira issue with a bunch of database changes to correct columns in the external tables. It will be really fun.
[11:44:50 CDT(-0500)] <dmccallum541> i'll take it as long as it's properly labeled as such
[11:45:54 CDT(-0500)] <js70> sounds efficient.
[11:46:08 CDT(-0500)] <js70> heard thats a good thing...
[12:05:47 CDT(-0500)] <JasonElwood> SSP-1077
[12:06:48 CDT(-0500)] <dmccallum541> i feel like maybe this ticket is overpromising...
[12:10:35 CDT(-0500)] <dmccallum541> i especially like how each of the "fun" labels includes a literal comma… hinting that there's yet even more "fun" to come...
[12:13:07 CDT(-0500)] <JasonElwood> oh know. once you start, you'll be hooked
[12:46:55 CDT(-0500)] <TonyUnicon> sorry Dan, didn't read this conversation before the standup
[12:47:03 CDT(-0500)] <dmccallum54> no worries