[16:50:29 CDT(-0500)] <JasonElwood> coachSetFromExternalData appears in the config db table and configuration.js Can somebody tell me which is used by the application
[17:00:40 CDT(-0500)] <dmccallum54> the configuration.js value is used in the front end to dis/enable the coach selection controls in the caseload assignment tool
[17:00:54 CDT(-0500)] <dmccallum54> checking on the back-end now
[17:02:23 CDT(-0500)] <dmccallum54> the background external->internal person sync job reads the config table coachSetFromExternalData value. if 'false', the coach assignment portion of the sync is short-circuited
[17:03:30 CDT(-0500)] <dmccallum54> additionally it reads the config table for the value of coachUnsetFromExternalData. if 'false' deletion of existing coach assignments as part of the sync is short-circuited
[17:04:21 CDT(-0500)] <JasonElwood> thanks
[17:05:18 CDT(-0500)] <dmccallum54> if we dont have a ticket for it already, we need one to get all that s…tuff out of configuration.js
[17:06:01 CDT(-0500)] <dmccallum54> oh we do
[17:06:02 CDT(-0500)] <dmccallum54> https://issues.jasig.org/browse/SSP-489
[17:06:16 CDT(-0500)] <JasonElwood> and there's one to create UI for everything in the db
[17:06:28 CDT(-0500)] <dmccallum54> how modest
[17:06:51 CDT(-0500)] <JasonElwood> well, at least the config table and message_templates
[17:06:55 CDT(-0500)] <dmccallum54> we do already have APIs for the config table
[17:07:14 CDT(-0500)] <dmccallum54> so even without a UI, we could get incremental improvement for deployers by putting configuration.js into the db table
[17:07:25 CDT(-0500)] <dmccallum54> one less file to fork and hack
[17:07:34 CDT(-0500)] <dmccallum54> anyway
[17:07:37 CDT(-0500)] <JasonElwood> that would be awesome
[17:07:41 CDT(-0500)] <dmccallum54> choir, consider yourself preached to
[17:12:03 CDT(-0500)] <JasonElwood> for configuration.js coachSetFromExternalData = false means that setting the coach in SSP is enabled. IE the coach can be changed in the UI
[17:23:32 CDT(-0500)] <dmccallum54> that's right
[17:24:21 CDT(-0500)] <dmccallum54> here's the awesome mind-blowing double negative code that only Maven implementors could really love: me.getCoachCombo().setDisabled( me.sspConfig.get('coachSetFromExternalData') );
[17:25:17 CDT(-0500)] <JasonElwood> I gotta get out of the documentation business
[17:25:31 CDT(-0500)] <dmccallum54> no
[17:25:52 CDT(-0500)] <dmccallum54> you gotta not get not out of the documentation business
[17:26:26 CDT(-0500)] <JasonElwood> exactly
[18:35:00 CDT(-0500)] <dmccallum54> js70 i'm trying to cherry-pick SSP-650 into master from rel-1-2-patches. cherry pick of the 1st of those commits (4a5c07594e05014370f451af9103c7b37c90af72) results in a huge conflict on src/main/jasperreports/disabilityServices.jrxml
[18:35:17 CDT(-0500)] <dmccallum54> is it reasonable to assume the entire rel-1-2-patches version of that file is the authoritative version?
[18:35:33 CDT(-0500)] <js70> definitely.
[18:35:40 CDT(-0500)] <dmccallum54> sweet. thx