[09:54:31 CST(-0600)] <athena> hey EricDalquist, just wanted to ping you about the layout.json stuff
[09:54:48 CST(-0600)] <athena> managed to close out a couple other things i was working on - is that something i can help out with today?
[09:54:54 CST(-0600)] <EricDalquist> yeah, got caught up in some other tasks yesterday afternoon
[09:55:01 CST(-0600)] <EricDalquist> hrm
[09:55:25 CST(-0600)] <EricDalquist> well you can't really test it yet but do you want add a portlet to the functional test portlets that supports dashboard window state
[09:55:42 CST(-0600)] <athena> sure, i could do that
[09:55:46 CST(-0600)] <EricDalquist> and sets the badge property on dashboard render?
[09:56:02 CST(-0600)] <athena> at a more base level though, is there something i can do to help get things back to working?
[09:56:23 CST(-0600)] <athena> have a couple big demos tomorrow, but think it's probably more useful to help out than to spend the time reverting changes
[09:57:06 CST(-0600)] <EricDalquist> right, well give me 30 minutes and I'll check back in with you on it and have a better idea
[09:57:08 CST(-0600)] <athena> sure, no worries
[09:57:19 CST(-0600)] <athena> and yes, i can totally add that other portlet 
[09:57:49 CST(-0600)] <athena> i'll be gone briefly in like 20 min - have to get the dog a booster shot
[09:57:53 CST(-0600)] <athena> but that should be brief
[09:58:02 CST(-0600)] <EricDalquist> ok
[09:58:19 CST(-0600)] <EricDalquist> yeah the portlet to help test would be great, that is the easiest thing off the top of my head to split out
[10:04:11 CST(-0600)] <athena> sure
[10:11:11 CST(-0600)] <EricDalquist> so athena, are we good with the plan that unless a portlet supports DASHBOARD we just don't render it
[10:13:03 CST(-0600)] <EricDalquist> hrm, I having second thoughts about all this ...
[10:13:07 CST(-0600)] <athena> lol
[10:13:12 CST(-0600)] <EricDalquist> 
[10:13:18 CST(-0600)] <EricDalquist> we'll get it fixed today
[10:13:22 CST(-0600)] <athena> lol
[10:13:27 CST(-0600)] <EricDalquist> I just want to think through a few other issues ...
[10:13:32 CST(-0600)] <athena> well i can always revert stuff if we want more time
[10:20:36 CST(-0600)] <EricDalquist> ok ... so Im remember more now
[10:21:00 CST(-0600)] <EricDalquist> we had some logic that initialized portlet windows minimized
[10:21:13 CST(-0600)] <EricDalquist> I'm thinking that is the wrong place for that logic
[10:23:29 CST(-0600)] <athena> ahh, that sounds familliar now
[10:23:33 CST(-0600)] <athena> ok, i have to run out briefly
[10:23:36 CST(-0600)] <EricDalquist> ok
[10:23:38 CST(-0600)] <athena> but i should be back in 20 min or so
[10:52:37 CST(-0600)] <EricDalquist> athena: you back?
[10:54:44 CST(-0600)] <athena> yep
[10:54:49 CST(-0600)] <athena> took longer than it should have
[10:55:00 CST(-0600)] <EricDalquist> so I'm trying to figure out the how to deal with this
[10:55:14 CST(-0600)] <EricDalquist> I'm going to abandon the dashboard stuff for now
[10:55:21 CST(-0600)] <athena> ok
[10:55:25 CST(-0600)] <EricDalquist> and just try and figure out the minimized bit
[10:55:32 CST(-0600)] <athena> ok
[10:56:20 CST(-0600)] <EricDalquist> we have logic in place that is supposed to be minimizing portlet windows on init
[10:56:31 CST(-0600)] <EricDalquist> if the current structure or theme say to
[10:56:39 CST(-0600)] <EricDalquist> I'm going to see if I can figure out why that isn't working
[10:56:45 CST(-0600)] <EricDalquist> but I'm also not happy with that solution
[10:57:08 CST(-0600)] <EricDalquist> I had the thought to do this via a pipeline component
[10:57:19 CST(-0600)] <EricDalquist> when rendering the mobile view or the json view it would minimize all portlets
[10:57:35 CST(-0600)] <EricDalquist> unless it was rendering a single portlet (detached state)
[10:57:39 CST(-0600)] <EricDalquist> does that seem reasonable?
[10:58:03 CST(-0600)] <athena> yes
[10:58:06 CST(-0600)] <athena> at least for a start
[10:58:27 CST(-0600)] <athena> we kind of also need something that can enforce that maximized portlets -> detached when the client is native
[10:58:35 CST(-0600)] <athena> i don't know if that's a related use case at all
[10:58:44 CST(-0600)] <EricDalquist> it could be easily
[10:58:54 CST(-0600)] <EricDalquist> it wouldn't be too hard to have a window state filtering component
[11:04:08 CST(-0600)] <athena> so for today for the base use case, what do we need to do? or should i just go occupy myself with something else for a whiel?
[11:04:29 CST(-0600)] <EricDalquist> something else for now, this should be pretty easy ...
[11:04:54 CST(-0600)] <athena> ok
[11:05:05 CST(-0600)] <athena> i in fact have plenty of things to do
[11:05:05 CST(-0600)] <athena> lol
[11:05:47 CST(-0600)] <EricDalquist>
[11:11:27 CST(-0600)] <EricDalquist> so we really have a component that needs to enforce a set of rules
[11:11:46 CST(-0600)] <EricDalquist> man I wish I had time to really dig into this :/
[11:11:55 CST(-0600)] <EricDalquist> for the json view
[11:12:01 CST(-0600)] <EricDalquist> and the mobile browser view
[11:12:21 CST(-0600)] <EricDalquist> everything must render in minimized or detached
[11:12:26 CST(-0600)] <EricDalquist> nothing else is ok
[11:12:36 CST(-0600)] <EricDalquist> for the desktop view, anything goes
[11:29:21 CST(-0600)] <athena> mobile browser uses focused, not detached
[11:29:30 CST(-0600)] <athena> then the native app uses detched, not focused
[11:29:36 CST(-0600)] <athena> just to be extra-helpful-confusing
[11:29:37 CST(-0600)] <EricDalquist> focused == mazimized?
[11:29:40 CST(-0600)] <EricDalquist> er maximized
[11:29:43 CST(-0600)] <athena> er, yeah, that
[11:29:46 CST(-0600)] <EricDalquist> ok
[11:29:48 CST(-0600)] <EricDalquist>
[11:30:16 CST(-0600)] <EricDalquist> but they both use DLMMobileColumns
[11:30:26 CST(-0600)] <athena> yeah
[11:42:33 CST(-0600)] <EricDalquist> blarg
[11:42:53 CST(-0600)] <EricDalquist> so much of this is so hacky
[11:43:01 CST(-0600)] <EricDalquist> it will be really good to fix layouts and profiles 
[11:43:51 CST(-0600)] <EricDalquist> like the fact that the json pipeline hard codes the structure descriptor
[11:43:57 CST(-0600)] <EricDalquist> I realize why that is done
[11:44:01 CST(-0600)] <EricDalquist> but it still sucks
[11:47:14 CST(-0600)] <athena> yeah
[11:47:20 CST(-0600)] <athena> going to be great to have that all refactored
[11:47:24 CST(-0600)] <athena> if there were just more time in the day . . .
[11:47:34 CST(-0600)] <EricDalquist> :/
[11:47:46 CST(-0600)] <EricDalquist> that detached vs maximized thing is a pain
[11:52:25 CST(-0600)] <athena> yeah
[11:52:30 CST(-0600)] <athena> we can ignore that for now if we need to
[11:52:40 CST(-0600)] <athena> it's not triggered often
[11:53:02 CST(-0600)] <athena> we do need to fix it eventually, but we haven't been enforcing it yet, and no one's complained too much
[11:53:08 CST(-0600)] <EricDalquist> if we were doing this right we'd figure out all the nuances of enforcing state/mode restrictions
[11:53:11 CST(-0600)] <EricDalquist> I'd love to do that eventually
[11:53:13 CST(-0600)] <athena> yeah
[11:53:17 CST(-0600)] <athena> that use case isn't a rush
[11:53:18 CST(-0600)] <EricDalquist> since the spec supports that
[12:44:42 CST(-0600)] <EricDalquist> getting closer athena ....
[12:46:08 CST(-0600)] <athena> woooo
[12:46:21 CST(-0600)] <athena> i'm making some of these portlets actually have desktop views
[12:46:40 CST(-0600)] <athena> just you know, in case someone doesn't actually do all of their computing on their phone
[12:46:52 CST(-0600)] <athena> so school gave us loaner droid phones last night
[12:47:05 CST(-0600)] <athena> i walked home with a smartphone in each pocket and it made me super happy
[12:47:11 CST(-0600)] <EricDalquist> lol
[12:48:06 CST(-0600)] <athena> though i uhhhh kinda missed the second half of lecture
[12:48:17 CST(-0600)] <athena> i have no idea what they were thinking handing them out halfway through
[12:48:27 CST(-0600)] <athena> oooh look, new toy to unbox and upgrade and set up accounts on
[12:48:48 CST(-0600)] <athena> oh wait . . . you actually want me to listen to you talk about low-level hardware protocols? errrrr not so much
[12:50:09 CST(-0600)] <EricDalquist> lol
[12:50:23 CST(-0600)] <EricDalquist> man .... its 1 already
[13:04:44 CST(-0600)] <athena> yeah
[13:04:48 CST(-0600)] <athena> day is going by too fast :/
[13:16:22 CST(-0600)] <EricDalquist> oi ... not sure why this didn't click before
[13:16:27 CST(-0600)] <EricDalquist> but when you're using layout.json
[13:16:39 CST(-0600)] <EricDalquist> the detached execution requests actually come through the standard rendering pipeline
[13:16:48 CST(-0600)] <EricDalquist> which makes sense
[13:16:51 CST(-0600)] <EricDalquist> but I didn'
[13:16:55 CST(-0600)] <EricDalquist> 't think about that
[13:21:38 CST(-0600)] <athena> yeah
[13:21:56 CST(-0600)] <athena> we just use layout.json to tell the native app what portlets are in the layout and what their URLs are
[13:22:09 CST(-0600)] <athena> that way it can create a native-based home screen that links to all the right web views
[13:24:06 CST(-0600)] <EricDalquist> grrrr
[13:41:45 CST(-0600)] <athena> not going smoothly?
[13:41:59 CST(-0600)] <EricDalquist> its going
[13:42:01 CST(-0600)] <EricDalquist> and will be fine
[13:42:08 CST(-0600)] <EricDalquist> just being reminded of all the grossness
[13:42:17 CST(-0600)] <EricDalquist> primarily again due to layouts/profiles
[13:59:59 CST(-0600)] <athena> yeah
[14:00:06 CST(-0600)] <athena> going to be SO nice when we have time to refactor that
[14:00:14 CST(-0600)] <athena> least the layers above it are all nice now
[14:00:20 CST(-0600)] <EricDalquist> mostly
[14:00:30 CST(-0600)] <EricDalquist> except for the parts where they are gross to deal with the old code
[14:15:05 CST(-0600)] <EricDalquist> so I'm not sure how much I can do on enforcing detached vs maximized
[14:15:37 CST(-0600)] <EricDalquist> since both umobile and mobile-browser go through the normal rendering pipeline
[14:15:51 CST(-0600)] <EricDalquist> but I think I have a better fix for the minimization issue
[14:20:18 CST(-0600)] <athena> yeah - and we're actually not sending any information that delineates between detached and minimized right now
[14:20:20 CST(-0600)] <athena> so that's really ok
[14:40:06 CST(-0600)] <EricDalquist> ok, I thinkI have this fixed
[14:40:11 CST(-0600)] <EricDalquist> though it will pollute the db a little bit
[14:40:17 CST(-0600)] <EricDalquist> I don't think there is much I can do about it right now
[14:40:18 CST(-0600)] <athena> poor db
[14:40:21 CST(-0600)] <athena>
[14:40:31 CST(-0600)] <EricDalquist> we have the whole 'persistent window state' thing now
[14:40:46 CST(-0600)] <EricDalquist> and so this code results in the window state of minimized getting stored for portlets in the mobile ui
[14:40:49 CST(-0600)] <EricDalquist> which isn't really right
[14:40:51 CST(-0600)] <EricDalquist> hrm
[14:40:59 CST(-0600)] <EricDalquist> I'll try one thing to fix that ...
[15:00:14 CST(-0600)] <EricDalquist> yay
[15:00:18 CST(-0600)] <EricDalquist> ok db polution fixed
[15:01:09 CST(-0600)] <athena> woo!
[15:01:21 CST(-0600)] <athena> is there other stuff that needs fixing?
[15:01:39 CST(-0600)] <EricDalquist> well, testing from you will be needed
[15:01:48 CST(-0600)] <EricDalquist> was there a jira issue for this?
[15:02:33 CST(-0600)] <EricDalquist> the downside is the fix will require a re-import of the stylesheet descriptor files
[15:03:00 CST(-0600)] <athena> that's no problem
[15:03:06 CST(-0600)] <athena> and no i'm not sure we created a JIRA
[15:03:07 CST(-0600)] <athena> i'll do that now
[15:03:38 CST(-0600)] <EricDalquist> https://issues.jasig.org/browse/UP-3327
[15:03:40 CST(-0600)] <EricDalquist> just did
[15:05:15 CST(-0600)] <athena> https://issues.jasig.org/browse/UP-3328
[15:05:15 CST(-0600)] <athena> oh
[15:05:16 CST(-0600)] <athena> lol
[15:05:18 CST(-0600)] <athena> oops
[15:05:26 CST(-0600)] <athena> i can delete mine
[15:05:40 CST(-0600)] <EricDalquist> lol
[15:06:21 CST(-0600)] <athena> all gone!
[15:06:24 CST(-0600)] <athena> poof
[15:06:54 CST(-0600)] <EricDalquist> so currently I have this stylesheet parameter named defaultWindowState
[15:06:57 CST(-0600)] <EricDalquist> but that isn't really right
[15:07:07 CST(-0600)] <EricDalquist> it is more "dashboardForcedWindowState"
[15:07:17 CST(-0600)] <EricDalquist> is that a better name?
[15:08:01 CST(-0600)] <athena> hmmm.
[15:08:05 CST(-0600)] <athena> yeah, i think that makes sense
[15:09:54 CST(-0600)] <EricDalquist> hrm, and maybe this makes more sense on the theme instead of the structure
[15:11:16 CST(-0600)] <athena> yeah, i think that makes sense
[15:11:20 CST(-0600)] <athena> give it more individual control
[15:44:53 CST(-0600)] <EricDalquist> uhg
[15:44:54 CST(-0600)] <EricDalquist> finally
[15:47:04 CST(-0600)] <athena> improvement?
[15:47:14 CST(-0600)] <EricDalquist> pushed to upstream
[15:47:16 CST(-0600)] <EricDalquist> and all fixed
[15:47:21 CST(-0600)] <EricDalquist> much better than the old approach
[15:47:23 CST(-0600)] <EricDalquist> still not the best
[15:47:27 CST(-0600)] <EricDalquist> but hopefully it fixes your problem
[15:49:43 CST(-0600)] <athena> thank! i really do appreciate all the help
[15:49:46 CST(-0600)] <athena> i'll try it out
[15:49:56 CST(-0600)] <EricDalquist> no problem
[15:50:01 CST(-0600)] <EricDalquist> needed to get fixed
[15:50:10 CST(-0600)] <EricDalquist> and I didn't have a decent way to articulate the fix
[15:50:13 CST(-0600)] <EricDalquist> :/
[15:50:28 CST(-0600)] <athena> no worries - just appreciate you being so willing to help
[15:50:39 CST(-0600)] <athena> hoping we can get a umobile 1.1rc1 out soon
[15:50:42 CST(-0600)] <athena> lots of improvements
[15:50:48 CST(-0600)] <athena> performance for some stuff should be a lot better too
[15:50:49 CST(-0600)] <EricDalquist> yeah
[15:50:56 CST(-0600)] <EricDalquist> I'm looking to get 4.0.3 out soon too
[15:51:09 CST(-0600)] <EricDalquist> think you'd have time to review jira in the next day or so?