Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 39 Next »

[09:54:04 CDT(-0500)] <EricDalquist> athena: you awake?
[10:23:57 CDT(-0500)] <athena> hey EricDalquist
[10:24:01 CDT(-0500)] <athena> what's up?
[10:24:27 CDT(-0500)] <EricDalquist> just checking on any thing you may be working on in trunk
[10:24:37 CDT(-0500)] <EricDalquist> I think I'm going to be done with all my trunk tasks today
[10:24:49 CDT(-0500)] <EricDalquist> and so I'm trying to figure out when I can start working on cutting the release
[10:25:16 CDT(-0500)] <athena> sweet (smile)
[10:25:21 CDT(-0500)] <athena> no, don't think i have anything outstanding
[10:25:26 CDT(-0500)] <athena> but i'll take a last pass through JIRA today
[10:25:36 CDT(-0500)] <athena> see if there are any other small tasks i can fix
[10:25:42 CDT(-0500)] <athena> will follow up with jeff about the IE fixes
[10:25:48 CDT(-0500)] <EricDalquist> great
[10:25:51 CDT(-0500)] <EricDalquist> thanks
[10:26:01 CDT(-0500)] <EricDalquist> I think I'll do the encoding/lineending fixes today then too
[10:26:21 CDT(-0500)] <EricDalquist> just got logic in place last night that logs the current stack trace of a portlet that has timed out
[10:26:43 CDT(-0500)] <EricDalquist> and a background process that re-claims worker threads from timed out portlets
[10:27:03 CDT(-0500)] <athena> oh nice (smile)
[10:42:35 CDT(-0500)] <EricDalquist> amazingly some stuff actually renders with a timeout of 1ms (tongue)
[10:42:39 CDT(-0500)] <athena> do you have any suggestions for giving different users different default skins? you guys are doing something on a per-campus basis right?
[10:42:47 CDT(-0500)] <EricDalquist> yeah
[10:42:52 CDT(-0500)] <athena> wow that's impressive
[10:42:57 CDT(-0500)] <EricDalquist> in 3.2 we have a DLM pipeline processor
[10:43:05 CDT(-0500)] <EricDalquist> that overrides the skin attribute based on a user attribute
[10:43:11 CDT(-0500)] <EricDalquist> and we set the user attribute from the host header
[10:43:24 CDT(-0500)] <EricDalquist> the problem with the approach is user's cannot customize their skin
[10:43:46 CDT(-0500)] <EricDalquist> since the processor has no easy way to see if they have picked a skin
[10:43:51 CDT(-0500)] <EricDalquist> and so it just always sets the override
[10:44:01 CDT(-0500)] <EricDalquist> haven't really though about how to do it in 4
[10:44:15 CDT(-0500)] <EricDalquist> but I'm guessing it wouldn't be too hard to figure out a slightly better solution
[10:44:20 CDT(-0500)] <EricDalquist> might even be nice to make it full featured
[10:44:32 CDT(-0500)] <athena> ah, gotcha
[10:44:33 CDT(-0500)] <EricDalquist> and have some component where your default skin is based on a group or something
[10:44:37 CDT(-0500)] <athena> yeah
[10:44:57 CDT(-0500)] <EricDalquist> since in 4 right now that is coming from the stylesheet descriptor
[10:45:10 CDT(-0500)] <EricDalquist> you'd just need to add some logic to override that value based on a group
[10:50:43 CDT(-0500)] <athena> yeah
[10:51:06 CDT(-0500)] <athena> we don't really advocate the use of template users anymore do we?
[10:53:31 CDT(-0500)] <EricDalquist> no
[10:53:51 CDT(-0500)] <EricDalquist> I'd really like to get rid of that concept completely when we re-write users/profiles/layouts
[10:53:51 CDT(-0500)] <athena> ok, that's what i thought
[10:54:02 CDT(-0500)] <athena> hmmm, never found a fix for the config mode url issues
[10:54:03 CDT(-0500)] <EricDalquist> it just turns into an endless headache
[10:54:07 CDT(-0500)] <EricDalquist> oh
[10:54:07 CDT(-0500)] <EricDalquist> ok
[10:54:08 CDT(-0500)] <athena> guess that's one thing that's outstanding
[10:54:10 CDT(-0500)] <EricDalquist> I'll take a look at that
[10:54:13 CDT(-0500)] <athena> ok
[11:11:53 CDT(-0500)] <athena> EricDalquist: this beep thing is completely awesome, by teh way
[11:12:05 CDT(-0500)] <athena> likely to become much more productive
[11:12:14 CDT(-0500)] <athena> my code pops up like toast!
[11:13:24 CDT(-0500)] <EricDalquist> yeah
[11:13:25 CDT(-0500)] <EricDalquist> I love it
[11:13:32 CDT(-0500)] <EricDalquist> I was reading about new lion features
[11:13:37 CDT(-0500)] <EricDalquist> and saw that
[11:13:43 CDT(-0500)] <athena> how hard would it be to do the same for maven?
[11:13:46 CDT(-0500)] <EricDalquist> then spent an hour figuring out how to make ant beep
[11:13:47 CDT(-0500)] <EricDalquist> no idea
[11:13:52 CDT(-0500)] <athena> that's so neat (smile)
[11:14:00 CDT(-0500)] <EricDalquist> in theory you can do it by just editing the ant or mvn shell script
[11:14:04 CDT(-0500)] <EricDalquist> that's where I looked first
[11:14:07 CDT(-0500)] <athena> ah
[11:14:12 CDT(-0500)] <EricDalquist> but I'm not a bash export
[11:14:14 CDT(-0500)] <EricDalquist> expert
[11:14:32 CDT(-0500)] <EricDalquist> yeah doing: printf "\a" in your terminal should have the same result
[11:14:41 CDT(-0500)] <EricDalquist> so you just need to figure out how to get the mvn script to run that at the end
[11:14:42 CDT(-0500)] <athena> nice
[11:15:00 CDT(-0500)] <EricDalquist> it makes me sad that I can't do the same thing on my ubuntu machine at work
[11:15:03 CDT(-0500)] <EricDalquist> I can get it to beep
[11:15:06 CDT(-0500)] <athena> i bet (smile)
[11:15:07 CDT(-0500)] <EricDalquist> but no bounce or badge (tongue)
[11:17:41 CDT(-0500)] <EricDalquist> I wonder with maven if you could write a really simple plugin that implements their listener interface
[11:17:46 CDT(-0500)] <EricDalquist> and just add it to your settings.xml
[11:17:58 CDT(-0500)] <athena> hm, yeah i bet
[12:29:26 CDT(-0500)] <EricDalquist> figured out the problem with the container-runtime-option athena
[12:29:36 CDT(-0500)] <EricDalquist> since the url generation is done via delegation
[12:29:56 CDT(-0500)] <EricDalquist> the pluto URL lookup data all points to the uPortal admin portlet (tongue)
[12:30:22 CDT(-0500)] <athena> yeah, that makes sense
[12:30:30 CDT(-0500)] <athena> i wondered if it had somethign to do w/ delegation
[12:30:43 CDT(-0500)] <athena> weird thing is it almost looked like the URL in the content portlet was getting double-escaped
[12:31:03 CDT(-0500)] <athena> the widgets portlet was the expected javascript-related issue though
[12:31:10 CDT(-0500)] <athena> maybe can handle that w/ an overlay
[12:31:19 CDT(-0500)] <athena> more worried about the content portlet, really
[12:31:22 CDT(-0500)] <EricDalquist> yeah I'm looking at the widgets portlet right now
[12:31:27 CDT(-0500)] <athena> ok (smile)
[12:31:29 CDT(-0500)] <EricDalquist> trying to figure out how best to do it
[12:31:47 CDT(-0500)] <athena> maybe could just do an overlay to use the portlet 2.0 taglib, then use the XML option?
[12:31:53 CDT(-0500)] <EricDalquist> yeah
[12:32:03 CDT(-0500)] <EricDalquist> we'd have to overlay the portlet.xml and the affected JSPs
[12:32:05 CDT(-0500)] <athena> would probably have to overlay portlet.xml, includes.jsp, and the config jsp file
[12:32:08 CDT(-0500)] <athena> think that'd be it
[12:32:12 CDT(-0500)] <athena> i can probably do that today if you'd like
[12:32:17 CDT(-0500)] <EricDalquist> Ill look a little more
[12:32:20 CDT(-0500)] <athena> ok
[12:32:20 CDT(-0500)] <EricDalquist> and see if I have some other ideas
[12:32:29 CDT(-0500)] <EricDalquist> I'd rather not have to do all that work
[12:32:32 CDT(-0500)] <athena> in the meantime i'm going to go through and see what UX patches are outstanding
[12:32:33 CDT(-0500)] <athena> yeah.
[12:32:44 CDT(-0500)] <EricDalquist> I'm actually thinking I might see if I can revert the XML escaping by default for 168 portlets
[12:32:44 CDT(-0500)] <athena> but we could resort to that for this release if we have to
[12:32:52 CDT(-0500)] <EricDalquist> since that would provide better legacy support
[12:35:16 CDT(-0500)] <athena> yeah that'd be awesome
[12:35:21 CDT(-0500)] <athena> will that work given the delegation thougH?
[12:35:28 CDT(-0500)] <EricDalquist> that would be the goal
[12:35:38 CDT(-0500)] <EricDalquist> I'll know how high of a bar that goal is shortly (tongue)
[12:36:24 CDT(-0500)] <athena> lol
[12:37:12 CDT(-0500)] <EricDalquist> though I'm still pretty happy to have gotten all the timeout/thread reclamation/req guarding stuff in
[12:37:16 CDT(-0500)] <athena> yeah (smile)
[12:37:17 CDT(-0500)] <EricDalquist> it ended up being pretty easy
[12:37:24 CDT(-0500)] <EricDalquist> and with my testing we get MUCH better errors
[12:37:37 CDT(-0500)] <EricDalquist> no more randon "the session is null" exception in the logs from a portlet that timed ouit
[12:37:46 CDT(-0500)] <athena> bookmarks portlet needs to be moved to the default data set
[12:37:50 CDT(-0500)] <EricDalquist> you just get a straight forward message that the portlet timed out and the request is no longer valid
[12:37:53 CDT(-0500)] <athena> not getting imported into the welcome fragment
[12:37:57 CDT(-0500)] <EricDalquist> ah ok
[12:37:58 CDT(-0500)] <athena> that's great (smile)
[12:38:02 CDT(-0500)] <EricDalquist> can you do that mv?
[12:38:10 CDT(-0500)] <athena> yep
[12:38:13 CDT(-0500)] <EricDalquist> thanks
[12:40:01 CDT(-0500)] <athena> also fixing the news/bookmarks overlays to really use the filter file
[12:40:09 CDT(-0500)] <EricDalquist> great
[12:40:15 CDT(-0500)] <athena> instead of that break-prone behavior of using the target version
[12:40:16 CDT(-0500)] <athena> no good (smile)
[12:40:32 CDT(-0500)] <EricDalquist> oh I commented out the login portlet in the guest layout
[12:41:00 CDT(-0500)] <athena> hm.
[12:41:02 CDT(-0500)] <EricDalquist> with it their but not being used by the theme it was getting orphaned by the rendering pipeline (started but never had the content retrieved)
[12:41:07 CDT(-0500)] <athena> ahhh
[12:41:08 CDT(-0500)] <athena> gotcha
[12:41:08 CDT(-0500)] <athena> ok
[12:41:12 CDT(-0500)] <athena> we'll ahve to do some documentation
[12:41:16 CDT(-0500)] <EricDalquist> yeah
[12:41:20 CDT(-0500)] <athena> because otherwise it breaks if you turn cas off
[12:41:24 CDT(-0500)] <EricDalquist> it used to be that you'd randomly get a big stack trace
[12:41:34 CDT(-0500)] <EricDalquist> I wonder if we can tweak the theme XSL
[12:41:37 CDT(-0500)] <athena> i wonder if that's what caused some of the errors i saw
[12:41:58 CDT(-0500)] <EricDalquist> and if the login portlet isn't in the XSL we can show a msg about adding it to the guest layout
[12:42:07 CDT(-0500)] <EricDalquist> also the import/export portlet should be working
[12:42:11 CDT(-0500)] <athena> yay (smile)
[12:42:18 CDT(-0500)] <athena> you fixed the fluid error?
[12:42:40 CDT(-0500)] <EricDalquist> yeah
[12:42:46 CDT(-0500)] <EricDalquist> found their current example code
[12:42:53 CDT(-0500)] <EricDalquist> and just added the example error panel
[12:42:56 CDT(-0500)] <EricDalquist> no idea if it looks right
[12:42:58 CDT(-0500)] <EricDalquist> but it works (tongue)
[12:43:08 CDT(-0500)] <athena> lol
[12:43:11 CDT(-0500)] <athena> sounds good
[12:44:22 CDT(-0500)] <EricDalquist> hrm
[12:44:29 CDT(-0500)] <EricDalquist> so I could fix this xml escaping issue
[12:44:33 CDT(-0500)] <EricDalquist> but it will require a pluto mod
[12:44:41 CDT(-0500)] <EricDalquist> which means a minimum 4 days to get a pluto release out
[12:44:43 CDT(-0500)] <EricDalquist> :/
[12:44:51 CDT(-0500)] <athena> ah. (sad)
[12:45:10 CDT(-0500)] <athena> do you want to just do an overlay for the GA and change it later or ?
[12:45:37 CDT(-0500)] <EricDalquist> I might see if I can just extend the taglib in shared/lib
[12:47:20 CDT(-0500)] <athena> ah
[12:47:30 CDT(-0500)] <EricDalquist> hrm
[12:47:31 CDT(-0500)] <EricDalquist> actually
[12:47:38 CDT(-0500)] <EricDalquist> pluto appears to be doing what we want
[12:47:43 CDT(-0500)] <EricDalquist> or at least the comments in the code imply
[12:48:57 CDT(-0500)] <EricDalquist> its a pluto bug
[12:49:09 CDT(-0500)] <EricDalquist> the comments imply that it shouldn't be XML escaping 168 URLs
[12:49:15 CDT(-0500)] <EricDalquist> but the object hierarchy is screwed up
[12:54:18 CDT(-0500)] <athena> ah
[12:54:20 CDT(-0500)] <athena> interesting
[13:05:53 CDT(-0500)] <EricDalquist> I think I might be able to just cut a pluto taglib jar release under the org.jasig groupid for the immediate fix
[13:06:01 CDT(-0500)] <EricDalquist> and then work on getting a pluto release for 4.0.1
[13:07:50 CDT(-0500)] <athena> sounds good to me
[13:12:01 CDT(-0500)] <EricDalquist> https://issues.apache.org/jira/browse/PLUTO-610
[14:17:24 CDT(-0500)] <EricDalquist> progress
[14:17:27 CDT(-0500)] <wgthom1> could be
[14:17:30 CDT(-0500)] <EricDalquist> fixing that pluto bog
[14:17:34 CDT(-0500)] <EricDalquist> bug
[14:17:43 CDT(-0500)] <EricDalquist> fixes the 168 URL encoding issues
[14:17:59 CDT(-0500)] <EricDalquist> though the gadgets portlet just failed with:
[14:17:59 CDT(-0500)] <EricDalquist> Caused by: java.lang.ClassCastException: org.apache.pluto.container.impl.RenderRequestImpl cannot be cast to javax.portlet.ActionRequest
[14:18:08 CDT(-0500)] <EricDalquist> which is ... interesting (tongue)
[14:18:11 CDT(-0500)] <athena> ok, i can take a look at that
[14:18:15 CDT(-0500)] <EricDalquist> oh
[14:18:18 CDT(-0500)] <EricDalquist> no that's ok
[14:18:21 CDT(-0500)] <EricDalquist> its in the delegation code
[14:18:49 CDT(-0500)] <athena> oh ok
[14:52:19 CDT(-0500)] <EricDalquist> apparently I never actually got resource urls working in config mode
[14:52:22 CDT(-0500)] <EricDalquist> (sad)
[14:52:39 CDT(-0500)] <athena> oh
[14:52:44 CDT(-0500)] <athena> do we need them?
[14:52:47 CDT(-0500)] <EricDalquist> yes
[14:52:52 CDT(-0500)] <EricDalquist> for things like the CMS portlet
[14:53:00 CDT(-0500)] <EricDalquist> since it uses resource urls to make requests
[14:53:06 CDT(-0500)] <athena> i think that doesn't use resource URLs yet for config mode thougH?
[14:53:16 CDT(-0500)] <athena> i thought we just used a servlet for that
[14:53:18 CDT(-0500)] <EricDalquist> oh? hrm
[14:53:32 CDT(-0500)] <athena> yeah, because we didn't have htat support before - portlet hasn't been updated much
[14:53:40 CDT(-0500)] <athena> and we decided the request wasn't really sensitive
[14:53:44 CDT(-0500)] <athena> our user-specific
[14:53:56 CDT(-0500)] <EricDalquist> nope resource urls are used
[14:54:06 CDT(-0500)] <EricDalquist> that may be my fault
[14:54:11 CDT(-0500)] <EricDalquist> from when I did the search stuff
[14:54:29 CDT(-0500)] <athena> ah ok (smile)
[14:54:39 CDT(-0500)] <athena> well, i think we probably don't need them - could look through the history
[14:54:46 CDT(-0500)] <athena> woudl be better to use resource urls, of course
[14:54:49 CDT(-0500)] <athena> but not critical
[14:55:04 CDT(-0500)] <EricDalquist> yeah
[14:55:14 CDT(-0500)] <EricDalquist> well we'll see how much work it is
[14:55:22 CDT(-0500)] <EricDalquist> webflow 2.3 supposedly supports resource URLs
[14:55:30 CDT(-0500)] <EricDalquist> just gotta figure out how to actually get it working (tongue)
[14:55:51 CDT(-0500)] <athena> (smile)

  • No labels