Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 12 Current »

[09:27:40 CST(-0600)] <jgribonvald> hi !

[09:28:00 CST(-0600)] <jgribonvald> I have a question about a problems

[09:29:26 CST(-0600)] <jgribonvald> i made 2 PR see on https://github.com/Jasig/resource-server/pulls

[09:30:03 CST(-0600)] <jgribonvald> In my case it's the best way to solve quickly my css problem

[09:32:02 CST(-0600)] <jgribonvald> to explain my problem : I have somes problems with somes portlets that use the jquery-ui-1.8.13-smoothness.min.css from the rs for the resizable tool

[09:32:42 CST(-0600)] <jgribonvald> but this css has a bug on it that add a 1px black background-image

[09:34:10 CST(-0600)] <jgribonvald> is it the best way to do ? or i should make a PR that upgrade all (even in uPortal) to jquery-ui-1.8.24 and test all ?

[09:42:38 CST(-0600)] <jwennmacher> IMHO Ideally I think the community would benefit if we were able to get to newer versions of jquery and jqueryUI. @jsittler any comments?

[09:42:55 CST(-0600)] <jwennmacher> @jsittler any comments?

[09:56:21 CST(-0600)] <jsittler> I would agree with James. Any work that can be done to implement and test against a newer jQuery library would be beneficial to the community. If we are unable to do that testing, then as a temporary solution, you could write a CSS rule in the portlet(s) that would override the theme bug.

[09:58:13 CST(-0600)] <jwennmacher> morning

[09:58:43 CST(-0600)] <jgribonvald> ok

[09:59:25 CST(-0600)] <jgribonvald> i began a talk with Ludovic Auxepaul https://github.com/Jasig/resource-server/pull/11

[09:59:40 CST(-0600)] <jgribonvald> it seems that at least with jquery 1.8.24 it's good

[10:00:46 CST(-0600)] <jgribonvald> and he is testing with jquery 1.9.1

[10:01:23 CST(-0600)] <jsittler> one issue I believe with upgrading to a newer version of jQuery, was Fluid had some issues. I'm not sure if any issues were logged regarding that , but it might be worthwhile to take a look at issues.jasig.com and if there are any then perhaps could patch Fluid.

[10:01:45 CST(-0600)] <jgribonvald> he did the job

[10:01:49 CST(-0600)] <jgribonvald> https://github.com/Jasig/uPortal/pull/189

[10:02:31 CST(-0600)] <jgribonvald> but need portlets in overlay upgrade to use this version from rs

[10:03:22 CST(-0600)] <jgribonvald> he did the work for jquery 1.8.24 at least

[10:03:30 CST(-0600)] <jgribonvald> in uportal

  • No labels