[11:13:18 CDT(-0500)] <b-rock> Greetings uPortal devs: I read on the mail list that 4.0.2 is planned to be cut next week. Is the fix for multi-valued user attributes in that? I know we chatted here about it but I don't think a ticket ever got created.
[11:13:59 CDT(-0500)] <athena> any objection to taking that most popular portlets portlet out of the 3.2 default layout?
[11:15:13 CDT(-0500)] <athena> dont' think it actually works on a lot of non-hsql databases
[11:37:43 CDT(-0500)] <athena> EricDalquist: looking at UP-3195, which notes that if you have the missing channel in your layout, you cant' add new content
[11:37:49 CDT(-0500)] <athena> have a temporary fix that makes that problem go away
[11:38:02 CDT(-0500)] <athena> but do we want to just strip the channel out of the layout entirely when the layout is resaved?
[11:51:32 CDT(-0500)] <EricDalquist> sorry athena, was on a conf call with terrecotta
[11:51:37 CDT(-0500)] <athena> no worries 
[11:52:01 CDT(-0500)] <EricDalquist> they are going to help us get uPortal working on the heap size based cache config when ehcache 2.5 comes out
[11:52:14 CDT(-0500)] <athena> oh wow, that sounds awesome
[11:52:27 CDT(-0500)] <EricDalquist> they also said that if we get an out of the box terrecotta config setup they would add uPortal to their validation suite for terrecottta
[11:52:33 CDT(-0500)] <athena> oh wow
[11:52:42 CDT(-0500)] <EricDalquist> b-rock: a fix was committed for that
[11:52:53 CDT(-0500)] <b-rock> thank you EricDalquist!!
[11:53:47 CDT(-0500)] <EricDalquist> b-rock: https://issues.jasig.org/browse/UP-3217
[11:54:48 CDT(-0500)] <b-rock> cool. quick question EricDalquist. Is the procedure for non-comitters to submit a patch to uPortal now the same as creating a ticket and attaching the patch, or should we try to do a pull request through github?
[11:55:33 CDT(-0500)] <b-rock> I don't have anything to submit at the moment, but I'm sure I will eventually.
[11:55:58 CDT(-0500)] <EricDalquist> either way is fine
[11:56:12 CDT(-0500)] <EricDalquist> doing a pull request through github will get your fix in the fastest though
[11:56:27 CDT(-0500)] <EricDalquist> since then someone can review the diff and merge it in the github UI
[11:56:36 CDT(-0500)] <EricDalquist> which makes it REALLY fast and easy
[11:56:43 CDT(-0500)] <b-rock> ok great. I have been trying it but haven't done a pull request yet.
[11:57:03 CDT(-0500)] <EricDalquist> I'm working on a git usage guide for committers right now
[11:57:11 CDT(-0500)] <EricDalquist> and will add another page for non-committers
[11:57:18 CDT(-0500)] <b-rock> cool. thanks.
[11:57:21 CDT(-0500)] <EricDalquist> since with github anyone can submit a pull
[11:57:27 CDT(-0500)] <EricDalquist> which is REALLY nice for us
[11:57:32 CDT(-0500)] <EricDalquist> so athena 3195
[11:57:35 CDT(-0500)] <athena> yes
[11:57:48 CDT(-0500)] <EricDalquist> I think we should strip the channel
[11:57:53 CDT(-0500)] <athena> ok, that was my thought too
[11:57:56 CDT(-0500)] <EricDalquist> that is what used to happen for expired channels
[11:57:59 CDT(-0500)] <athena> cant' think of any reason to keep it around
[11:58:04 CDT(-0500)] <athena> it's not like there's a chance it might come back
[11:58:15 CDT(-0500)] <EricDalquist> the problem is the code assumed that expired was as "deleted" as something could get
[11:58:16 CDT(-0500)] <athena> it's a bit weird since it won't get stripped until the layout is resaved
[11:58:20 CDT(-0500)] <athena> yeah
[11:58:31 CDT(-0500)] <EricDalquist> and so there were a bunch of places that null checks were needed
[11:59:40 CDT(-0500)] <athena> yeah
[11:59:51 CDT(-0500)] <athena> easy enough to do
[12:02:01 CDT(-0500)] <EricDalquist> yup
[12:08:10 CDT(-0500)] <EricDalquist> I'm going through the git workflow right now on a small set of changes
[12:08:18 CDT(-0500)] <EricDalquist> so I should have it all verified later this afternoon
[12:09:57 CDT(-0500)] <athena> awesome
[12:10:11 CDT(-0500)] <athena> i have some changes to commit this morning on the 3.2 branch as well
[12:36:09 CDT(-0500)] <athena> EricDalquist: just made two commits to the 3.2 branch
[12:36:13 CDT(-0500)] <athena> seems like they tooik
[12:36:31 CDT(-0500)] <athena> instructions were mostly good, though the forking instructions over on the git site give you a URL that doesn't work for pushing
[12:39:09 CDT(-0500)] <EricDalquist> ok good to know
[12:39:23 CDT(-0500)] <EricDalquist> I'll make a note that committers need to use the read/write url when setting up the upstream reamote
[12:39:32 CDT(-0500)] <athena> sounds good
[12:39:36 CDT(-0500)] <athena> other than that it seems fine
[12:39:39 CDT(-0500)] <EricDalquist> great
[12:39:40 CDT(-0500)] <athena> worked well for a branch too
[12:40:04 CDT(-0500)] <EricDalquist> and it looks like you were able to push to both your fork and uPortal
[12:40:08 CDT(-0500)] <athena> yeah
[12:40:12 CDT(-0500)] <athena> seems to have worked
[12:40:14 CDT(-0500)] <EricDalquist> great
[12:40:18 CDT(-0500)] <athena> yeah
[12:40:23 CDT(-0500)] <athena> feel like i can be productive again
[12:40:24 CDT(-0500)] <athena> so that's good
[12:40:24 CDT(-0500)] <EricDalquist> I believe you could also just push to your fork and then do a pull request
[12:40:25 CDT(-0500)] <athena>
[12:40:29 CDT(-0500)] <EricDalquist> if you ever want code review
[12:40:29 CDT(-0500)] <athena> yeah
[12:40:36 CDT(-0500)] <EricDalquist> but I'll make sure to document all of that
[12:40:38 CDT(-0500)] <athena> shoudl be a good workflow
[12:40:47 CDT(-0500)] <EricDalquist>
[12:41:00 CDT(-0500)] <EricDalquist> I'm looking forward to having people like b-rock be able to do pull requests
[12:41:05 CDT(-0500)] <athena> totally
[12:41:07 CDT(-0500)] <EricDalquist> will make applying patches even easier
[12:41:09 CDT(-0500)] <athena> shoudl be a really good thing for us
[12:41:13 CDT(-0500)] <athena> yeah
[13:06:11 CDT(-0500)] <b-rock> Hi again uPortal devs. I'm working on getting the toro gateway sso portlet working in the up4 build. can you tell me if there is an equivalent of UserInstanceManager.getUserInstance(req); in up4? right now I'm getting a noclassdef because the file moved and not sure if this is supported