[01:00:46 CDT(-0500)] * ajan (~ajan@89.205.17.150) has joined ##uportal
[08:09:10 CDT(-0500)] * jessm (~Jess@c-68-40-84-77.hsd1.mi.comcast.net) has joined ##uportal
[08:12:21 CDT(-0500)] * colinclark (~colin@74.198.28.32) has joined ##uportal
[08:37:47 CDT(-0500)] * colinclark (~colin@bas2-clarkson16-1176020144.dsl.bell.ca) has joined ##uportal
[09:17:08 CDT(-0500)] * lfuller (~sparhk@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
[09:22:39 CDT(-0500)] * EricDalquist (~dalquist@2607:f388:e:0:221:9bff:fe37:e768) has joined ##uportal
[09:24:21 CDT(-0500)] * JoeMoore (89d880aa@gateway/web/freenode/ip.137.216.128.170) has joined ##uportal
[09:55:54 CDT(-0500)] * holdorph (~holdorph@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
[09:56:12 CDT(-0500)] * bsparks (~bsparks@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
[10:33:27 CDT(-0500)] * athena (~athena@email.cupcakeroyale.com) has joined ##uportal
[10:44:33 CDT(-0500)] <athena> hey EricDalquist - how's crucible looking so far?
[10:44:40 CDT(-0500)] <EricDalquist> neat
[10:44:43 CDT(-0500)] <EricDalquist> did you get the review email?
[11:05:08 CDT(-0500)] <athena> yeah
[11:05:14 CDT(-0500)] <athena> i wasn't sure what one of them actually meant
[11:05:16 CDT(-0500)] <athena> but i got it 
[11:05:23 CDT(-0500)] <EricDalquist> so I added a few comments to the commit
[11:05:26 CDT(-0500)] <athena> would be great to have that set up - i'd love the feedback
[11:05:34 CDT(-0500)] <EricDalquist> I think you can go and respond to them or something
[11:05:40 CDT(-0500)] <athena> oh neat
[11:05:55 CDT(-0500)] <athena> i saw your comments, but i was reading them from the bus stop outside the basketball arena 
[11:05:59 CDT(-0500)] <EricDalquist> lol
[11:06:31 CDT(-0500)] <athena> yeah
[11:06:34 CDT(-0500)] <athena> great game though
[11:07:00 CDT(-0500)] <athena> watching the WNBA team here - seattle won after coming from way-behind to maintain their perfect home record
[11:07:01 CDT(-0500)] <athena> great time
[11:07:09 CDT(-0500)] <EricDalquist> nice
[11:07:13 CDT(-0500)] <athena> ya
[11:07:19 CDT(-0500)] <athena> so this is the comment i had a question about: "You should be able to do m.group(1); and get just the contents of the matching group in the expression. Then there won't be a need for the additional substring"
[11:07:29 CDT(-0500)] <EricDalquist> ah right
[11:07:34 CDT(-0500)] <athena> does matcher.group(number) return something different than matcher.group()?
[11:07:37 CDT(-0500)] <EricDalquist> yes
[11:07:44 CDT(-0500)] <EricDalquist> group() returns the whole match
[11:07:53 CDT(-0500)] <EricDalquist> the regex has a group defined in it though
[11:07:57 CDT(-0500)] <EricDalquist> the part wrapped in ()
[11:08:09 CDT(-0500)] <EricDalquist> the defined groups are indexed starting at 1
[11:08:12 CDT(-0500)] <athena> oh!
[11:08:14 CDT(-0500)] <athena> i see
[11:08:18 CDT(-0500)] <EricDalquist> so if you want the contents of the first () you do group(1)
[11:08:31 CDT(-0500)] <athena> yep, makes sense
[11:08:32 CDT(-0500)] <athena> will fix
[11:08:39 CDT(-0500)] <EricDalquist> that lets the regex engine do the parsing work
[11:08:45 CDT(-0500)] <athena> yeah
[11:08:48 CDT(-0500)] <athena> definitely a good call
[11:08:54 CDT(-0500)] <athena> will be more stable if we ever change the regex
[11:08:59 CDT(-0500)] <EricDalquist> yup
[11:08:59 CDT(-0500)] <athena> i do see it now
[11:09:01 CDT(-0500)] <EricDalquist> but the code looked great
[11:09:06 CDT(-0500)] <athena> hadn't looked at that regex too closely
[11:09:07 CDT(-0500)] <athena> gr
[11:09:07 CDT(-0500)] <athena> eat
[11:09:09 CDT(-0500)] <EricDalquist> I think that will be a really handy feature
[11:09:17 CDT(-0500)] <athena> hopefully that'll be something we can build on to add the rest of what we need
[11:09:23 CDT(-0500)] <EricDalquist> yeah
[11:09:36 CDT(-0500)] <athena> maybe want to think about whether this is something we might want to use a bunch from other portlets?
[11:09:43 CDT(-0500)] <EricDalquist> the only other thing I thought of on the way in is that we probably want to stick the WebRequest in a Map
[11:09:43 CDT(-0500)] <athena> the content portlet seems like a pretty clear match
[11:09:54 CDT(-0500)] <EricDalquist> do like put("request", webRequest);
[11:10:10 CDT(-0500)] <EricDalquist> so we have additional namespaces we can use when we add more data to the evaluator context
[11:11:33 CDT(-0500)] <athena> that makes sense
[11:11:57 CDT(-0500)] <athena> and then use the map to initialize the evaluation context?
[11:11:57 CDT(-0500)] <EricDalquist> it would suck to use it everywhere then need to add something new and have to update all the existing expressions
[11:12:01 CDT(-0500)] <EricDalquist> yeah
[11:12:01 CDT(-0500)] <athena> that's a pretty easy change
[11:12:02 CDT(-0500)] <athena> yeah
[11:12:17 CDT(-0500)] <EricDalquist> then we can just add more to the map as we find more object we want access to in the SpEL
[11:12:43 CDT(-0500)] <athena> sounds good
[11:13:08 CDT(-0500)] <athena> so will changing that affect the existing expressions (like "request.contextPath")?
[11:13:14 CDT(-0500)] <athena> i've never played with this stuff much
[11:13:22 CDT(-0500)] <EricDalquist> I think so
[11:14:30 CDT(-0500)] <athena> it doesn't become request.request.contextPath or something awful does it?
[11:14:55 CDT(-0500)] <EricDalquist> no I think the root object is unnamed
[11:15:06 CDT(-0500)] <EricDalquist> right now I think you can just do "contextPath"
[11:17:05 CDT(-0500)] <athena> ohh
[11:17:15 CDT(-0500)] <athena> so the expression i'm using now is probably fine either way
[11:18:53 CDT(-0500)] <athena> tested out using a portlet icon using the context path and it works great
[11:19:10 CDT(-0500)] <EricDalquist> great
[11:19:24 CDT(-0500)] <EricDalquist> I'm really happy about getting this in
[11:19:28 CDT(-0500)] <EricDalquist> should be a really handy feature
[11:19:36 CDT(-0500)] <athena> yeah
[11:19:56 CDT(-0500)] <athena> fun to play with, too
[11:20:01 CDT(-0500)] <athena> and it'll be cool to have icons for the portlets
[11:20:02 CDT(-0500)] <EricDalquist> yup
[11:20:08 CDT(-0500)] <athena> that development is really coming along
[11:25:31 CDT(-0500)] <EricDalquist> so on that crucible review page
[11:25:41 CDT(-0500)] <EricDalquist> do you have an option to like accept or close it or something like that>
[11:25:45 CDT(-0500)] <EricDalquist> I'm wondering how they 'complete'
[11:28:53 CDT(-0500)] * athena (~athena@email.cupcakeroyale.com) has joined ##uportal
[11:29:25 CDT(-0500)] <athena> looks like the wifi here makes you log in every hour
[11:29:26 CDT(-0500)] * athena sighs
[12:01:56 CDT(-0500)] <athena> shoot
[12:02:03 CDT(-0500)] <athena> EricDalquist: now i'm getting "Field or property 'request' cannot be found on object of type 'java.util.HashMap'"
[12:02:10 CDT(-0500)] <EricDalquist> ah
[12:02:15 CDT(-0500)] <athena> do we need to use a POJO rather than a map?
[12:02:18 CDT(-0500)] <EricDalquist> yeah
[12:02:19 CDT(-0500)] <EricDalquist> probably
[12:02:21 CDT(-0500)] <athena> ok
[12:02:29 CDT(-0500)] <athena> we can probably just use a throwaway inner class or something?
[12:02:31 CDT(-0500)] <EricDalquist> just need to make a little SpELEnvironmentRoot bean or some such
[12:02:32 CDT(-0500)] <EricDalquist> yeah
[12:02:35 CDT(-0500)] <athena> not sure this thing is going to have much re-use
[12:02:37 CDT(-0500)] <athena> sounds good
[12:02:56 CDT(-0500)] <EricDalquist> probably none at all
[12:05:27 CDT(-0500)] <athena> cool
[12:24:11 CDT(-0500)] <athena> ok, those updates are in
[12:30:27 CDT(-0500)] * colinclark (~colin@bas2-clarkson16-1176020144.dsl.bell.ca) has joined ##uportal
[13:29:23 CDT(-0500)] * athena (~athena@email.cupcakeroyale.com) has joined ##uportal
[13:49:23 CDT(-0500)] * athena (~athena@2002:d8e7:2660:1234:21f:5bff:fec7:31a) has joined ##uportal
[14:10:14 CDT(-0500)] * athena (~athena@2002:d8e7:2660:1234:21f:5bff:fec7:31a) has joined ##uportal
General
Content
Integrations