uPortal IRC Logs-2010-10-29

[09:54:24 CDT(-0500)] <EricDalquist> gotta love the edu work place
[09:54:38 CDT(-0500)] <EricDalquist> one guy in a flamingo costume and I'm in a chicken suit
[10:00:39 CDT(-0500)] <athena> lol
[10:00:48 CDT(-0500)] <EricDalquist> I'll see if we can get pictures
[10:00:48 CDT(-0500)] <athena> happy halloween, i guess!
[10:00:52 CDT(-0500)] <athena> you should!
[10:01:01 CDT(-0500)] <athena> kris and i are dressing up as alligator hunters tomorrow
[10:01:30 CDT(-0500)] <athena> then we're going to the MLS soccer playoffs sunday night
[10:11:58 CDT(-0500)] <EricDalquist> nice
[10:17:03 CDT(-0500)] <mpolizzotti> Hey Eric and Jen, I'm working on revamping the entity selector interface (UP-2742) and was hoping to check these changes in soon. When do you plan on cutting a release? Should I hold off on my updates?
[10:17:31 CDT(-0500)] <athena> do we probably have until the end of the workday today to make changes EricDalquist?
[10:18:24 CDT(-0500)] <mpolizzotti> It doesn't matter to me so much. I can hold off and check in after the milestone. I just don't want to mess anything up or cause additional work for others.
[10:21:32 CDT(-0500)] <EricDalquist> well I'll do the pluto 2 release tonight
[10:21:51 CDT(-0500)] <EricDalquist> and if things are stable on uPortal trunk I can likely do the maven side of the M1 release tonight as well
[10:21:55 CDT(-0500)] <athena> i'd suggest if your changes are ready right now to check them in? i'd be happy to do a bit of testing, and if it seems like something's really wrong we can revert them for a few days
[10:21:59 CDT(-0500)] <EricDalquist> though if you guys have stuff you'd like to do
[10:22:05 CDT(-0500)] <EricDalquist> I can wait until Sunday
[10:22:22 CDT(-0500)] <athena> nah i don't think i'm going to have much time to work this weekend
[10:22:42 CDT(-0500)] <mpolizzotti> No problem. My changes are minor and deal with the ui. I will wait. Just wanted to make sure.
[10:22:52 CDT(-0500)] <EricDalquist> ok
[10:23:02 CDT(-0500)] <mpolizzotti> I will not be working the weekend either
[10:23:18 CDT(-0500)] <EricDalquist> one thing I just did in 3.2 and will do in trunk before the release is stick fn:escapeXml() all over in our JSPs
[10:23:27 CDT(-0500)] <EricDalquist> we had a lot of places where we were writing out user provided content
[10:23:31 CDT(-0500)] <EricDalquist> even if it was from the admin
[10:23:45 CDT(-0500)] <athena> thanks for doing that
[10:23:55 CDT(-0500)] <EricDalquist> yay for regex
[10:24:06 CDT(-0500)] <EricDalquist> I love that I can do regex & capture groups in eclipse search/repelase
[10:24:07 CDT(-0500)] <athena> what tag do we want to use?
[10:24:11 CDT(-0500)] <EricDalquist> replace even
[10:24:15 CDT(-0500)] <athena> that one? spring's escapeBody tag?
[10:24:33 CDT(-0500)] <athena> we should probably make sure we use the escapeBody javaScriptEscape="true" for js content
[10:24:36 CDT(-0500)]

[10:24:46 CDT(-0500)] <EricDalquist> I used escapeBody any time I'm writing content into JS
[10:24:50 CDT(-0500)] <athena> makes sense - that takes less typing
[10:24:50 CDT(-0500)] <athena> yeah
[10:25:04 CDT(-0500)] <athena> sounds like a great change
[10:25:24 CDT(-0500)] <EricDalquist> I think when we're not in a javascript block escapeXml should prevent a <script> tag from appearing so no need to escape JS stuff
[10:25:46 CDT(-0500)] <athena> i think we still neeed to use the javaScriptEscape
[10:25:49 CDT(-0500)] <EricDalquist> but within a <script> block the escapeBody with javaScriptEscape="true" is needed
[10:25:54 CDT(-0500)] <athena> yeah
[10:25:59 CDT(-0500)] <athena> take care of apostrophes
[10:26:38 CDT(-0500)] <athena> went through a few more admin portlets yesterday and pulled out all the messages
[10:26:39 CDT(-0500)] <athena> so painful
[10:26:43 CDT(-0500)] <EricDalquist> uhg
[10:26:46 CDT(-0500)] <EricDalquist> thanks for that though
[10:26:50 CDT(-0500)] <athena> yeah it's really tedious
[10:26:55 CDT(-0500)] <athena> it'll be good to have it done
[10:27:12 CDT(-0500)] <EricDalquist> though that explains why my patch for escape changes in 3.2 didn't apply to trunk
[10:27:18 CDT(-0500)] <athena> it'll take a while to hunt down all the missing messages
[10:27:19 CDT(-0500)] <athena> lol
[10:27:19 CDT(-0500)] <athena> yeah
[10:27:29 CDT(-0500)] <athena> that'd make sense
[10:27:39 CDT(-0500)] <EricDalquist> so do you think we're ok doing fn:escapeXml in HTML and escapeBody with javaScriptEscape within <script>
[10:27:50 CDT(-0500)] <athena> yeah i think so
[10:28:03 CDT(-0500)] <athena> and certainly the fn tag is a much less unweildly syntax
[10:28:27 CDT(-0500)] <EricDalquist> yes
[10:28:36 CDT(-0500)] <athena> are you going to make that change today?
[10:28:43 CDT(-0500)] <EricDalquist> tonight I hope
[10:28:56 CDT(-0500)] <EricDalquist> it goes pretty fast with the regex search/replace
[10:29:12 CDT(-0500)] <athena> ok
[10:29:13 CDT(-0500)] <EricDalquist> just have to be careful to only add it when writing content out
[10:29:46 CDT(-0500)] <athena> yeah
[10:30:17 CDT(-0500)] <athena> and there's a place or two i've started adding stuff that specifically has HTML in the JSTL variable, so that's somethign to watch out for
[10:30:57 CDT(-0500)] <EricDalquist> ah ok
[10:31:50 CDT(-0500)] <athena> so basically doing stuff so that we can have some sort of highlight span or style around some text, but still have it in the right place in the string
[10:32:00 CDT(-0500)]

<athena> so we might want an i18n string of "Edit Group

Unknown macro: {0}

"

[10:32:18 CDT(-0500)] <athena> but want to actually write out to html "Edit Group <span>Administrators</span>"
[10:32:25 CDT(-0500)] <EricDalquist> so we should probably add fn:escapeXml to everything and things like that with HTML output should get a comment next to them explaining why it doesn't have the escaping
[10:32:38 CDT(-0500)] <EricDalquist> well the spring:message tags do the escaping correctly on stuff like that I think
[10:32:40 CDT(-0500)] <EricDalquist> brb
[10:32:50 CDT(-0500)] <athena> so right now setting the variable to be <span>${fn:escapeXml(group.name)</span> or whatever, then writing out that variable with xml escaping turned off
[10:32:58 CDT(-0500)] <athena> yeah
[10:33:14 CDT(-0500)] <athena> message by default actually escapes xml - it's an option though
[10:33:35 CDT(-0500)] <athena> should be pretty obvious from the code
[10:37:59 CDT(-0500)] <EricDalquist> ah
[10:38:06 CDT(-0500)] <EricDalquist> you can override that for specific message tags
[10:38:17 CDT(-0500)] <EricDalquist> so for that one just disable the escapeHtml option
[10:38:26 CDT(-0500)] <EricDalquist> and fn:escapexml() the message arg
[10:42:22 CDT(-0500)] <athena> yeah
[10:42:29 CDT(-0500)] <athena> seems to work well
[10:42:47 CDT(-0500)] <athena> and that way it won't be broken in languages that have different ordering
[10:43:15 CDT(-0500)] <EricDalquist> yup
[11:06:46 CDT(-0500)] <athena> gah
[11:06:59 CDT(-0500)] <EricDalquist> ?
[11:07:08 CDT(-0500)] <athena> i tried to write a new FlowHandler and i can't seem to get the flow to use it
[11:23:08 CDT(-0500)] <athena> oh ugh
[11:23:16 CDT(-0500)] <athena> i bet the link isn't an action url
[11:51:20 CDT(-0500)] <athena> EricDalquist: guess we'll need a 3.0 M1 of the news reader portlet before the uportal release as well
[11:51:29 CDT(-0500)] <EricDalquist> oh yeah
[11:51:34 CDT(-0500)] <EricDalquist> I can do that easily enough
[11:51:41 CDT(-0500)] <athena> i think it should be all ready to go
[11:51:48 CDT(-0500)] <EricDalquist> great
[11:51:48 CDT(-0500)] <athena> just needs pluto
[11:51:50 CDT(-0500)] <athena>
[11:51:51 CDT(-0500)] <EricDalquist> yup
[11:54:18 CDT(-0500)] <athena> incidentally looks like runnign the maven license plugin might be in order before the M1
[11:56:06 CDT(-0500)] <EricDalquist> yup
[11:56:15 CDT(-0500)] <athena> augh
[11:56:24 CDT(-0500)] <athena> you know, i did a bunch of work on the NOTICE file at one point
[11:56:29 CDT(-0500)] <athena> and i have no idea what happened to it
[11:57:15 CDT(-0500)] <EricDalquist> uhoh!
[12:49:25 CDT(-0500)] <EricDalquist> oh and the costume picture is on twitter
[13:18:04 CDT(-0500)] <athena> hurray!
[13:18:18 CDT(-0500)] * athena goes to relaunch tweetdeck
[13:18:29 CDT(-0500)] <athena> i've got all but these licenses classified:
[13:18:35 CDT(-0500)] <athena> jstl-1.1.2.jar
[13:18:35 CDT(-0500)] <athena> jta-1.0.1B.jar
[13:18:36 CDT(-0500)] <athena> script-api-1.0.jar
[13:18:36 CDT(-0500)] <athena> standard-1.1.2.jar
[13:18:43 CDT(-0500)] <athena> you happen to know license for any of those?
[13:18:45 CDT(-0500)] <EricDalquist> hrm
[13:18:54 CDT(-0500)] <EricDalquist> I think jstl and standard are either from apache or sun
[13:18:58 CDT(-0500)] <EricDalquist> jta & script are from sun
[13:19:03 CDT(-0500)] <athena> yeah
[13:19:10 CDT(-0500)] <EricDalquist> so I'm guessing the jssl or whatever that sun license is
[13:19:12 CDT(-0500)] <athena> and the sun ones are always hard to figure out
[13:19:18 CDT(-0500)] <athena> because they just seem to use random license text
[13:19:21 CDT(-0500)] <EricDalquist> yeah
[13:19:24 CDT(-0500)] <athena> though i think on the whole they're moving towards CDDL
[13:19:32 CDT(-0500)] <EricDalquist> yeah that one
[13:19:38 CDT(-0500)] <EricDalquist> that's what I assume
[13:21:26 CDT(-0500)] <athena> wonder if we need to list dependencies of the included portlets
[13:21:35 CDT(-0500)] <athena> or if we can just defer to those portlets' NOTICE files
[13:21:48 CDT(-0500)] <EricDalquist> I'd hope deffering though their notice files would be sufficient
[13:22:08 CDT(-0500)] <athena> yeah
[13:28:04 CDT(-0500)] <athena> OK! we have a notice file
[13:28:11 CDT(-0500)] <EricDalquist> wow awesome
[13:28:25 CDT(-0500)] <athena> should probably backport that to 3.2 and 3.1 and clean it up for those dependencies
[13:28:32 CDT(-0500)] <athena> i think it's actually pretty much right
[13:28:41 CDT(-0500)] <athena> probably missing some institutions under the copywrite section
[13:33:32 CDT(-0500)] <athena> hmmm, trying to find other things to clean up for the release
[13:34:07 CDT(-0500)] <athena> eventually need to figure out how to integrate the attribute swapper into the new user management portlet
[13:39:32 CDT(-0500)] <athena> i wonder if now that we have resource URLs if we could use the fluid uploader for the import/export portlet
[13:39:43 CDT(-0500)] <EricDalquist> probably
[13:40:39 CDT(-0500)] <athena> the problem is just that it's written as a crn portlet
[13:40:56 CDT(-0500)] <EricDalquist> yup
[13:41:01 CDT(-0500)] <EricDalquist> biab ... lunch
[13:41:03 CDT(-0500)] <athena> cya!
[17:48:03 CDT(-0500)] <Bananobot> Is there a way for a portlet to easily override the default button styles without overriding each individual property?
[17:49:40 CDT(-0500)] <Bananobot> I'm making a JavaScript-driven autocomplete/drop-down selection widget (similar to Google Suggest), and I'm using button elements for the items. I don't want to use <a> elements, but with buttons I have to override the default stylesheet stuff
[18:03:43 CDT(-0500)] <Bananobot> OMG! Epiphany! A portlet can't modify the head area of the page, but JavaScript can, and a majority of what I need to style is JavaScript-generated content!