[08:59:28 EDT(-0400)] * jessm (~Jess@c-71-232-3-151.hsd1.ma.comcast.net) has joined ##uportal
[09:23:41 EDT(-0400)] * colinclark (~colin@bas2-toronto09-1176131031.dsl.bell.ca) has joined ##uportal
[09:38:08 EDT(-0400)] * athena (~athena@adsl-99-62-112-41.dsl.wlfrct.sbcglobal.net) has joined ##uportal
[10:51:38 EDT(-0400)] * holdorph (~holdorph@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
[10:56:13 EDT(-0400)] * EricDalquist (~dalquist@2607:f388:e:0:221:9bff:fe37:e768) has joined ##uportal
[11:00:39 EDT(-0400)] * lfuller (~sparhk@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
[11:47:57 EDT(-0400)] * awills (~awills@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
[12:51:45 EDT(-0400)] * Sememmon (~Sememmon@unaffiliated/sememmon) has joined ##uportal
[13:16:09 EDT(-0400)] * colinclark (~colin@142.150.154.101) has joined ##uportal
[13:21:09 EDT(-0400)] <EricDalquist> I cannot wait until 286 in uportal to rewrite the proxy portlet
[13:21:18 EDT(-0400)] <EricDalquist> that thing may work as is but it could be so much better
[13:25:20 EDT(-0400)] <athena> yes!
[13:25:26 EDT(-0400)] * athena cheers wildly
[13:25:27 EDT(-0400)] <athena> 
[13:25:36 EDT(-0400)] <athena> it will be magical
[13:25:44 EDT(-0400)] <EricDalquist> just discovered that the latest version doesn't always close connections
[13:25:46 EDT(-0400)] <EricDalquist> 
[13:36:36 EDT(-0400)] * michelled (~michelled@142.150.154.141) has joined ##uportal
[13:38:44 EDT(-0400)] <athena> oh
[13:38:55 EDT(-0400)] <athena> is it related to the httpclient 4 changes?
[13:39:00 EDT(-0400)] <EricDalquist> yup
[13:39:10 EDT(-0400)] <athena> ugh
[13:39:13 EDT(-0400)] <EricDalquist> it is partially httpclient's fault
[13:39:16 EDT(-0400)] <EricDalquist> for a terribly named API
[13:39:31 EDT(-0400)] <athena> there's a lot of confusion in there, for sure
[13:39:40 EDT(-0400)] <athena> if it's something i need to take a look at, let me know
[13:39:54 EDT(-0400)] <athena> since it sounds like it could have been related to those shib changes
[13:40:15 EDT(-0400)] <EricDalquist> http://uportal.pastebin.com/Ehkc9isy
[13:40:27 EDT(-0400)] <EricDalquist> that is the fix
[13:41:44 EDT(-0400)] <EricDalquist> response.getEntity().consumeContent();
[13:41:55 EDT(-0400)] <EricDalquist> is what has to be called when you're done with the response
[13:42:13 EDT(-0400)] <EricDalquist> the javadoc says they're going to rename it to response.getEntity().finished(); in the next major release
[13:42:14 EDT(-0400)] <athena> wow
[13:42:18 EDT(-0400)] <athena> thanks for letting me know
[13:42:21 EDT(-0400)] <EricDalquist> yeah
[13:42:21 EDT(-0400)] <athena> i'd definitely missed that
[13:42:39 EDT(-0400)] <athena> would be willing to bet i've made that mistake elsewhere too - i'll have to look around
[13:42:40 EDT(-0400)] <EricDalquist> apparently if you actually read all of the content from the response it automatically gets called
[13:42:43 EDT(-0400)] <athena> definitely appreciate the heads up
[13:42:47 EDT(-0400)] <athena> ah, interesting
[13:42:55 EDT(-0400)] <EricDalquist> but as we found out today there are cases where it sure looks like we did that
[13:42:59 EDT(-0400)] <athena> so if you read the whole input stream it closes it, or something like that?
[13:42:59 EDT(-0400)] <EricDalquist> and we leak connections
[13:43:03 EDT(-0400)] <EricDalquist> yeah
[13:43:16 EDT(-0400)] <EricDalquist> which seems annoying
[13:43:24 EDT(-0400)] <athena> yeah
[13:43:31 EDT(-0400)] <EricDalquist> it seems much safer to just require everyone to call .close() or .finish() in a finally block
[13:43:51 EDT(-0400)] <EricDalquist> or provide a doInResponse(Response) type of callback
[14:06:50 EDT(-0400)] <athena> yeah
[17:55:11 EDT(-0400)] * awills1 (~awills@wsip-72-215-204-133.ph.ph.cox.net) has joined ##uportal
General
Content
Integrations