[10:12:30 CST(-0600)] <awills> EricDalquist did you see comments from Denny Denny?
[10:13:04 CST(-0600)] <EricDalquist> I did, I also got a question about the default mvn build not working in trunk
[10:13:28 CST(-0600)] <EricDalquist> does the new filtering stuff require extra setup to make the maven build work?
[10:14:45 CST(-0600)] <awills> it seems that if you maven filters, the filters file must exist... thus the issue with bamboo we addressed on Friday... is that what you mean? or something else?
[10:15:59 CST(-0600)] <athena> (*Unless you're building directly from Maven, without Ant. In that case you'll need a tiny adjustment, as I discovered with the help of Bamboo.)
[10:16:17 CST(-0600)] <athena> from looking at the code, it looks like it has to do with the dot that the ant task appends to the environment name if it's set
[10:16:44 CST(-0600)] <athena> awills i'm also having problems even getting the ant build to run
[10:16:55 CST(-0600)] <awills> i was just refering to the -Dfilters.file=... that we added to bamboo
[10:16:58 CST(-0600)] <EricDalquist> can we have the filters file simply setup by default?
[10:17:09 CST(-0600)] <awills> sure, i believe we can
[10:17:13 CST(-0600)] <EricDalquist> note I've had no time to actually look at the code or changes :/
[10:17:28 CST(-0600)] <athena> maybe we can just tell everyone to rename their current file to be "build.local.properties" and use that as the default rather than a blank env name?
[10:17:44 CST(-0600)] <awills> Denny Denny's comment makes me think there are platform differences to how this works
[10:17:58 CST(-0600)] <athena> dunno, but ant's not working at all for me on os x
[10:18:02 CST(-0600)] <awills> and that may be what athena's seeing
[10:18:52 CST(-0600)] <awills> probably the default value for <filters.file> should point to something that exists
[10:19:34 CST(-0600)] <awills> and also we should add these -Djasig.ignore things
[10:20:18 CST(-0600)] <awills> which is what I was going to ask about... are there known issues with passing blank arguments to mvn from ant?
[10:22:12 CST(-0600)] <EricDalquist> yes
[10:22:14 CST(-0600)] <EricDalquist> you can't do that
[10:22:25 CST(-0600)] <awills> then that's the issue
[10:22:26 CST(-0600)] <EricDalquist> which is why all those jasig.ignore parameters are there
[10:22:54 CST(-0600)] <awills> yeah, never got up to speed on that... works on windows i guess
[10:22:57 CST(-0600)] <athena> i think i can get this stuff fixed this morning if you'd like
[10:23:00 CST(-0600)] <awills> i can put them in
[10:23:40 CST(-0600)] <athena> do you have time right now?
General
Content
Integrations