Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Migration of unmigrated content due to installation of a new plugin

...

[19:46:02 CDT(-0500)] <TonyUnicon> like what?

[19:46:49 CDT(-0500)] <pspaude> I think it can be done. Student type has to be null if empty, so if we have a valid value I dont' think it will matter.

[19:47:38 CDT(-0500)] <TonyUnicon> yeah I dont think we have a choice, id be really hard pressed to make a change to the model code proper

[19:47:47 CDT(-0500)] <TonyUnicon> as we just dont have the time to asses the impact

[19:47:55 CDT(-0500)] <pspaude> No I agree and the json method is ok I think.

[19:48:18 CDT(-0500)] <TonyUnicon> id write a ticket up

[19:48:26 CDT(-0500)] <TonyUnicon> for we can address it soon

[19:48:29 CDT(-0500)] <pspaude> But, yeah we have to let it soak. I think the model might need tobe changed since we changed the idea of allowing those values to be null late in the game, namely this iteration.

[19:48:32 CDT(-0500)] <TonyUnicon> because I have never seen a setter do that

[19:48:34 CDT(-0500)] <TonyUnicon> ever

[19:48:54 CDT(-0500)] <pspaude> Yeah I'll put it in the ticket and then see if Jason wants another ticket.

[19:49:06 CDT(-0500)] <pspaude> I've never seen one do that either, its always the opposite.

[19:49:41 CDT(-0500)] <JasonElwood> we should split out anything we aren't comfortable doing for 2.0.0

[20:39:27 CDT(-0500)] <dmccallum54> back momentarily

[20:39:59 CDT(-0500)] <JasonElwood> created 1696 for impersonation issue. not sure how much we want to describe in the issue

[20:40:07 CDT(-0500)] <JasonElwood> Tony is working on it though

[20:40:45 CDT(-0500)] <TonyUnicon> i dont think its an impersonation issue anymore

[20:40:46 CDT(-0500)] <JasonElwood> Paul is working on a fix for 1695, trying to keep it isolated as possible

[20:40:50 CDT(-0500)] <TonyUnicon> its a race condition

[20:41:02 CDT(-0500)] <TonyUnicon> and ive my swipes at it

[20:41:09 CDT(-0500)] <dmccallum54> yeah. i just got it to happen locally again, but it's erratic

[20:41:15 CDT(-0500)] <TonyUnicon> i get it

[20:41:31 CDT(-0500)] <TonyUnicon> but the UI doesn't degrade, it just blows stack

[20:41:43 CDT(-0500)] <dmccallum54> when i got it just now ssp wouldnt' render

[20:41:44 CDT(-0500)] <TonyUnicon> but I did try a few things that didnt work

[20:41:49 CDT(-0500)] <TonyUnicon> spawning a new transaction being one of them

[20:42:35 CDT(-0500)] <TonyUnicon> really? I got the stack but mygps loaded

[20:42:39 CDT(-0500)] <TonyUnicon> maybe i did not pay close enough attention

[20:42:51 CDT(-0500)] <TonyUnicon> could have been in anonymous mode

[20:42:55 CDT(-0500)] <dmccallum54> GPS will load but behave as if the user is anonymous

[20:42:58 CDT(-0500)] <dmccallum54> SSP will not

[20:43:11 CDT(-0500)] <dmccallum54> Ext throws a fit about the empty response from getAuthenticatedUser

[20:46:17 CDT(-0500)] <TonyUnicon> i also have to step away as eating is apparently a requirement

[20:46:50 CDT(-0500)] <TonyUnicon> be back in ~30 minutes

[20:51:56 CDT(-0500)] <pspaude> Finished SSP-1695. Am leaving for home. Will come back after I'm home and make sure everything is going good.

[20:52:57 CDT(-0500)] <JasonElwood> I'm going to build linux CI to test 1695 while everybody is away

[20:53:05 CDT(-0500)] <pspaude> Cool go ahead.

[20:56:04 CDT(-0500)] <dmccallum54> gunna have to check out again in 5m

[20:56:17 CDT(-0500)] <dmccallum54> but think i have a bead on the impersonation/1st-time login race

[20:56:20 CDT(-0500)] <dmccallum54> famous last words

[20:56:35 CDT(-0500)] <JasonElwood> that would be awesome

[20:58:29 CDT(-0500)] <dmccallum54> ugh gotta run

[21:07:28 CDT(-0500)] <dmccallum54> k. back momentarily think i've got irt

[21:07:36 CDT(-0500)] <dmccallum54> going to go ahead and check it in

[21:08:56 CDT(-0500)] <dmccallum54> pushed

[21:09:07 CDT(-0500)] <JasonElwood> uportal check-in?

[21:10:24 CDT(-0500)] <dmccallum54> no

[21:10:25 CDT(-0500)] <dmccallum54> ssp

[21:10:31 CDT(-0500)] <dmccallum54> gotta disappear again

[21:10:32 CDT(-0500)] <dmccallum54> sorry

[21:10:40 CDT(-0500)] <JasonElwood> no worries. I'll build in a minute

[21:34:39 CDT(-0500)] <TonyUnicon> were you able to test it?

[21:34:45 CDT(-0500)] <TonyUnicon> pulling it down now and see if it works for me

[21:35:26 CDT(-0500)] <JasonElwood> testing it now. no client or service side errors yet

[21:40:16 CDT(-0500)] <TonyUnicon> ok

[21:40:26 CDT(-0500)] <TonyUnicon> looks liked it worked with my test student

[21:40:52 CDT(-0500)] <JasonElwood> nice

[21:40:59 CDT(-0500)] <JasonElwood> if you are comfortable, I can close it

[21:41:25 CDT(-0500)] <TonyUnicon> yeah I think it's pretty cut and dry

[21:41:30 CDT(-0500)] <JasonElwood> sweet

[21:43:17 CDT(-0500)] <JasonElwood> we're in good shape. Dan wanted to pound at the app again tomorrow to make sure nothing else popped up.

[21:44:15 CDT(-0500)] <TonyUnicon> fingers crossed

[21:44:30 CDT(-0500)] <TonyUnicon> hopefully we took all our knocks today

[21:44:34 CDT(-0500)] <TonyUnicon> enjoy your weekend

[21:44:45 CDT(-0500)] <JasonElwood> I'm calling it quits. I'll check in the morning to see if Dan came up with anything.

[21:45:00 CDT(-0500)] <TonyUnicon> alright

[21:45:01 CDT(-0500)] <JasonElwood> I will. you do the same. I'll try to find a place to get to email tomorrow afternoon

[21:45:10 CDT(-0500)] <TonyUnicon> sounds good

[21:45:16 CDT(-0500)] <JasonElwood> thanks man for all the work

[21:45:23 CDT(-0500)] <TonyUnicon> yeah likewise, thanks for the help

[21:45:29 CDT(-0500)] <JasonElwood> later

[21:45:33 CDT(-0500)] <TonyUnicon> later