Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[13:19:22 CDT(-0500)] <EricDalquist> and I just found a spring bug ...

[14:25:34 CDT(-0500)] <jwennmacher> cool ... do share

[14:25:53 CDT(-0500)] <EricDalquist> ordering of spring annotation handlers

[14:26:00 CDT(-0500)] <EricDalquist> their compare impl is broken

[14:26:15 CDT(-0500)] <EricDalquist> in this case a portlet has 6 handler methods

[14:26:18 CDT(-0500)] <EricDalquist> that end up in a list like [ren, res, ren, res, ren, res]

[14:26:23 CDT(-0500)] <EricDalquist> problem is when it compares handlers of different types is returns 0

[14:26:28 CDT(-0500)] <EricDalquist> and with them alternating the merge sort never compares handlers of the same type

[14:26:32 CDT(-0500)] <EricDalquist> so it assumes the list is in order

[14:26:41 CDT(-0500)] <EricDalquist> when the render handlers are in the wrong order

[14:26:46 CDT(-0500)] <EricDalquist> so all requests go to the least-qualified handler

[14:26:49 CDT(-0500)] <EricDalquist> instead of the most

[14:27:20 CDT(-0500)] <EricDalquist> I've verified it in spring's unit tests

[14:27:22 CDT(-0500)] <EricDalquist> writing a fix now

[14:27:27 CDT(-0500)] <EricDalquist> and submitting a pull soon

[14:27:39 CDT(-0500)] <EricDalquist> then going to see if we can figure out a local fix until they get a patch ouit

[14:29:37 CDT(-0500)] <jwennmacher> good fine. bug in new version of spring? I think I saw portal upgraded recently ...

[14:29:44 CDT(-0500)] <EricDalquist> no

[14:29:48 CDT(-0500)] <EricDalquist> this has always been there

[14:29:50 CDT(-0500)] <jwennmacher> good find (smile)

[14:30:06 CDT(-0500)] <EricDalquist> if you hit it really depends on the number and type of handler annotations

[14:35:57 CDT(-0500)] <EricDalquist> oh ... looks like it was found already (smile)

[14:36:12 CDT(-0500)] <EricDalquist> and is supposed to be fixed in spring 3.1.3 which is scheduled for tomorrow

[14:37:08 CDT(-0500)] <EricDalquist> yeah ... there we go

[14:37:16 CDT(-0500)] <EricDalquist> it is fixed

[14:37:17 CDT(-0500)] <EricDalquist> yay

[14:37:21 CDT(-0500)] <EricDalquist> well I guess we just wait then (tongue)

[14:37:30 CDT(-0500)] <EricDalquist> and until then the new stats portlet may or may not work

[14:52:49 CDT(-0500)] <EricDalquist> https://jira.springsource.org/browse/SPR-9874

[16:12:06 CDT(-0500)] <drewwills> heh... good find eric

[16:12:15 CDT(-0500)] <EricDalquist> annoying

[16:12:22 CDT(-0500)] <EricDalquist> I spent an hour being angry at the stats portlet

[16:12:25 CDT(-0500)] <EricDalquist> worked fine on my desktop

[16:12:33 CDT(-0500)] <EricDalquist> but on our dev box none of the report links worked

[16:12:53 CDT(-0500)] <EricDalquist> just heard back from jeurgen that 3.1.3 is coming very soon

[16:12:56 CDT(-0500)] <EricDalquist> and the fix will be in it

[16:13:15 CDT(-0500)] <drewwills> excellent... i'm very excited to see progress in reporting stats

[16:13:41 CDT(-0500)] <drewwills> that's something I can easily use to promote the platform and upgrading