Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Migration of unmigrated content due to installation of a new plugin

...

[17:53:49 CDT(-0500)] <js70> So, I'm looking into the issue right now.

[18:00:08 CDT(-0500)] <js70> the patching is not going to work as significant changes were made that make a simple patch impossible. Looked at the code, we just need to change one line final PagingWrapper<Challenge> challengeWrapper = challengeService.getAll(null); to final PagingWrapper<Challenge> challengeWrapper = challengeService.getAll(new SortingAndPaging(ObjectStatus.Active));

[18:00:32 CDT(-0500)] <dmccallum54> js70 if that fixes the problem, that seems just fine to me

[18:00:43 CDT(-0500)] <js70> Dan, would it be possible to make this change in the 1.1.1 branch, create a patch and go from there.

[18:00:51 CDT(-0500)] <js70> that will fix it.

[18:01:21 CDT(-0500)] <js70> k

[18:01:23 CDT(-0500)] <dmccallum54> i think i'm probably not understanding what you're saying

[18:01:31 CDT(-0500)] <dmccallum54> here's what i think you're saying

[18:01:55 CDT(-0500)] <dmccallum54> a cherry pick from upstream into 1.1 isn't going to work b/c the upstream patches assume a whole bunch of other changes that aren't relevant

[18:02:07 CDT(-0500)] <js70> yes

[18:02:15 CDT(-0500)] <dmccallum54> but you can accomplish the same goal in a completely different way for 1.1 with a one line patch

[18:02:22 CDT(-0500)] <dmccallum54> if that's what you're saying, then great, go for it!

[18:02:39 CDT(-0500)] <js70> ok. kool.

[18:35:14 CDT(-0500)] <js70> SSP-924 and the CounselingReport are now up to date on 1.1 and 1.2

[18:35:38 CDT(-0500)] <JasonElwood> Thanks Jim

[18:35:46 CDT(-0500)] <js70> NP

[18:44:40 CDT(-0500)] <JasonElwood> dan- would you agree that MAP print/email could occur after feature set 1 and 2?

[18:45:16 CDT(-0500)] <dmccallum54> seems like one of the two should definitely be postponable

[18:45:37 CDT(-0500)] <dmccallum54> as to whether both can be postponed… i think it has to do with what's in the export exactly

[18:46:15 CDT(-0500)] <JasonElwood> and there are two options. one that's full description, the other like a grid of terms and courses

[18:46:30 CDT(-0500)] <dmccallum54> given the concern over the External Data Apocalypse i've been assuming that "exportability" of a minimally viable plan representation is a very high priority indeed

[18:47:16 CDT(-0500)] <dmccallum54> if that's a realistic take on things, then it seems like we absolutely need some sort of lightweight export feature in "phase 1"

[18:47:38 CDT(-0500)] <dmccallum54> i.e. an export that works even if you lose all the external data that a plan refers to

[18:48:14 CDT(-0500)] <dmccallum54> that's why the "Core Planning" feature set operational model specifies that certain fields be copied from the external course record into the operational model

[18:48:43 CDT(-0500)] <dmccallum54> w/r/t the actualy delivery format…. an email is actually going to be simplest for us, i think

[18:48:53 CDT(-0500)] <dmccallum54> given the painfulness of building jasper reports

[18:49:39 CDT(-0500)] <JasonElwood> both report examples have student and contact notes on the reports. the rest is pretty much basic information. do we want to build a report for feature set 1 then go back into the reports to add notes OR do it all at once?

[18:51:13 CDT(-0500)] <dmccallum54> imho notes are fluff and should be added later

[18:51:25 CDT(-0500)] <dmccallum54> and i mean fluff in the most respectful sense

[18:51:26 CDT(-0500)] <dmccallum54> of course

[18:51:32 CDT(-0500)] <JasonElwood> sure

[18:56:57 CDT(-0500)] <dmccallum54> js70 1-1 patch does not compile 4413140cfd42393301cf8cdf72d7c955bff5b5b1

[19:01:48 CDT(-0500)] <dmccallum54> js70 i need to run. will take another peek tonight and see about pushing to IRSC

[19:02:01 CDT(-0500)] <js70> k