...
[19:27:16 CDT(-0500)] <dmccallum54> thx
[19:28:46 CDT(-0500)] <dmccallum54> you able to shell into that box?
[19:29:31 CDT(-0500)] <dmccallum54> if you haven't done it before the keys and all that are here: https://wiki.jasig.org/display/SSP/SSP+CI+Server+Notes
[19:29:42 CDT(-0500)] <dmccallum54> to get into postgres CLI
[19:29:52 CDT(-0500)] <dmccallum54> psql -d ssp -U sspadmin
[19:30:18 CDT(-0500)] <JasonElwood> I may need to open the ip
[19:30:48 CDT(-0500)] <dmccallum54> i've not had problems ssh-ing in from various coffee shops
[19:30:53 CDT(-0500)] <dmccallum54> so that port might be wide open 
[19:30:57 CDT(-0500)] <JasonElwood> sweet then
[19:31:18 CDT(-0500)] <dmccallum54> alright. sorry guys. i gotta run. will try to check in later tonight. thx for all the help.
[19:31:25 CDT(-0500)] <pspaude> Dan offhand do you know why there is a guard condition in the Person model for coachID and studenttypeID if they are null don't set it with a current valid value?
[19:31:29 CDT(-0500)] <pspaude> That is the problem for 1695. I'm just worried as to side effects all though so far I don't see any.
[19:31:45 CDT(-0500)] <dmccallum54> i dont know. TonyUnicon?
[19:32:04 CDT(-0500)] <pspaude> Nevermind take off, I think its ok, I'll go ahead and commit. Just tried different test cases and it seems ok.
[19:32:30 CDT(-0500)] <TonyUnicon> hold on
[19:32:40 CDT(-0500)] <dmccallum54> check and make sure saving intake doesn't blow it away or something like that?
[19:32:45 CDT(-0500)] <TonyUnicon> i think there was a ticket that explicitly says that
[19:33:06 CDT(-0500)] <pspaude> Good idea I'll check right now.
[19:33:07 CDT(-0500)] <TonyUnicon> let me find it
[19:34:05 CDT(-0500)] <TonyUnicon> https://issues.jasig.org/browse/SSP-1490
[19:34:21 CDT(-0500)] <pspaude> intake works with the guard removed, let me play git blame and see the issue
[19:34:42 CDT(-0500)] <pspaude> *rather it doesn't blow things to pieces
[19:34:50 CDT(-0500)] <TonyUnicon> Rule: leave the data in SSP alone if there is no coach or student_type in external_person.
[19:35:29 CDT(-0500)] <TonyUnicon> its a business rule
[19:37:05 CDT(-0500)] <TonyUnicon> the file/line are you speaking about specifically
[19:37:51 CDT(-0500)] <pspaude> Person.js line 108 and line 162
[19:38:32 CDT(-0500)] <pspaude> Pretty much makes SSP-1695 and the whole its ok if the values are null thing stop dead in the water.
[19:39:35 CDT(-0500)] <TonyUnicon> this is a very sensitive part of the code
[19:39:41 CDT(-0500)] <TonyUnicon> not a great 11th hour fix
[19:39:49 CDT(-0500)] <pspaude> Yes I know. That is why I was worried.
[19:40:13 CDT(-0500)] <pspaude> This is the direct block to 1695 and coachID null too! (Which I think was a previous issue)
[19:40:18 CDT(-0500)] <TonyUnicon> that method it used in a bunch of places
[19:40:35 CDT(-0500)] <TonyUnicon> i do not recommend changing it
[19:40:44 CDT(-0500)] <TonyUnicon> let me look at the ticket
[19:41:41 CDT(-0500)] <TonyUnicon> although
[19:41:46 CDT(-0500)] <TonyUnicon> that is pretty bizzare behavior
[19:42:21 CDT(-0500)] <pspaude> Hmm those lines were in there originally from when value could be dual.
[19:42:52 CDT(-0500)] <pspaude> Yeah I agree it is bizarre that is why I was scratching my head, I thought at first it was a conditional logic mistake, but two different people implemented it one for coachId and one for studentType id.
[19:43:17 CDT(-0500)] <pspaude> Originally : if ( this.get('coach') != null)
[19:43:20 CDT(-0500)] <pspaude> + {
[19:43:22 CDT(-0500)] <pspaude> + this.get('coach').id = value;
[19:43:24 CDT(-0500)] <pspaude> + }else{
[19:43:26 CDT(-0500)] Wiki Markup <pspaude> + this.set('coach',{"id":value});
[19:43:28 CDT(-0500)] <pspaude> + }
[19:43:40 CDT(-0500)] <pspaude> So someone removed the bottom half.
[19:43:52 CDT(-0500)] <TonyUnicon> but that stuff has been in there for over a year
[19:43:57 CDT(-0500)] <TonyUnicon> and it is used in multiple places
[19:44:07 CDT(-0500)] <TonyUnicon> a change in that code needs to soak IMO
[19:44:23 CDT(-0500)] <pspaude> Yeah that is my opinion as well.
[19:44:44 CDT(-0500)] <TonyUnicon> see if you can code around it
[19:44:50 CDT(-0500)] <TonyUnicon> so that it's only isolated to the bug your fixing
[19:45:11 CDT(-0500)] <TonyUnicon> try to modify the value directly
[19:45:31 CDT(-0500)] <TonyUnicon> and write up for future consumption
[19:45:37 CDT(-0500)] <TonyUnicon> we can do it first thing next iteration and let it sit
[19:45:49 CDT(-0500)] <pspaude> I'm trying modifying the JSON data before its sent but that adds some other peculiarites.
[19:46:02 CDT(-0500)] <TonyUnicon> like what?
[19:46:49 CDT(-0500)] <pspaude> I think it can be done. Student type has to be null if empty, so if we have a valid value I dont' think it will matter.
[19:47:38 CDT(-0500)] <TonyUnicon> yeah I dont think we have a choice, id be really hard pressed to make a change to the model code proper
[19:47:47 CDT(-0500)] <TonyUnicon> as we just dont have the time to asses the impact
[19:47:55 CDT(-0500)] <pspaude> No I agree and the json method is ok I think.
[19:48:18 CDT(-0500)] <TonyUnicon> id write a ticket up
[19:48:26 CDT(-0500)] <TonyUnicon> for we can address it soon
[19:48:29 CDT(-0500)] <pspaude> But, yeah we have to let it soak. I think the model might need tobe changed since we changed the idea of allowing those values to be null late in the game, namely this iteration.
[19:48:32 CDT(-0500)] <TonyUnicon> because I have never seen a setter do that
[19:48:34 CDT(-0500)] <TonyUnicon> ever
[19:48:54 CDT(-0500)] <pspaude> Yeah I'll put it in the ticket and then see if Jason wants another ticket.
[19:49:06 CDT(-0500)] <pspaude> I've never seen one do that either, its always the opposite.
[19:49:41 CDT(-0500)] <JasonElwood> we should split out anything we aren't comfortable doing for 2.0.0
[20:39:27 CDT(-0500)] <dmccallum54> back momentarily
[20:39:59 CDT(-0500)] <JasonElwood> created 1696 for impersonation issue. not sure how much we want to describe in the issue
[20:40:07 CDT(-0500)] <JasonElwood> Tony is working on it though
[20:40:45 CDT(-0500)] <TonyUnicon> i dont think its an impersonation issue anymore
[20:40:46 CDT(-0500)] <JasonElwood> Paul is working on a fix for 1695, trying to keep it isolated as possible
[20:40:50 CDT(-0500)] <TonyUnicon> its a race condition
[20:41:02 CDT(-0500)] <TonyUnicon> and ive my swipes at it
[20:41:09 CDT(-0500)] <dmccallum54> yeah. i just got it to happen locally again, but it's erratic
[20:41:15 CDT(-0500)] <TonyUnicon> i get it
[20:41:31 CDT(-0500)] <TonyUnicon> but the UI doesn't degrade, it just blows stack
[20:41:43 CDT(-0500)] <dmccallum54> when i got it just now ssp wouldnt' render
[20:41:44 CDT(-0500)] <TonyUnicon> but I did try a few things that didnt work
[20:41:49 CDT(-0500)] <TonyUnicon> spawning a new transaction being one of them
[20:42:35 CDT(-0500)] <TonyUnicon> really? I got the stack but mygps loaded
[20:42:39 CDT(-0500)] <TonyUnicon> maybe i did not pay close enough attention
[20:42:51 CDT(-0500)] <TonyUnicon> could have been in anonymous mode
[20:42:55 CDT(-0500)] <dmccallum54> GPS will load but behave as if the user is anonymous
[20:42:58 CDT(-0500)] <dmccallum54> SSP will not
[20:43:11 CDT(-0500)] <dmccallum54> Ext throws a fit about the empty response from getAuthenticatedUser
[20:46:17 CDT(-0500)] <TonyUnicon> i also have to step away as eating is apparently a requirement
[20:46:50 CDT(-0500)] <TonyUnicon> be back in ~30 minutes
[20:51:56 CDT(-0500)] <pspaude> Finished SSP-1695. Am leaving for home. Will come back after I'm home and make sure everything is going good.
[20:52:57 CDT(-0500)] <JasonElwood> I'm going to build linux CI to test 1695 while everybody is away
[20:53:05 CDT(-0500)] <pspaude> Cool go ahead.
[20:56:04 CDT(-0500)] <dmccallum54> gunna have to check out again in 5m
[20:56:17 CDT(-0500)] <dmccallum54> but think i have a bead on the impersonation/1st-time login race
[20:56:20 CDT(-0500)] <dmccallum54> famous last words
[20:56:35 CDT(-0500)] <JasonElwood> that would be awesome
[20:58:29 CDT(-0500)] <dmccallum54> ugh gotta run
[21:07:28 CDT(-0500)] <dmccallum54> k. back momentarily think i've got irt
[21:07:36 CDT(-0500)] <dmccallum54> going to go ahead and check it in
[21:08:56 CDT(-0500)] <dmccallum54> pushed
[21:09:07 CDT(-0500)] <JasonElwood> uportal check-in?
[21:10:24 CDT(-0500)] <dmccallum54> no
[21:10:25 CDT(-0500)] <dmccallum54> ssp
[21:10:31 CDT(-0500)] <dmccallum54> gotta disappear again
[21:10:32 CDT(-0500)] <dmccallum54> sorry
[21:10:40 CDT(-0500)] <JasonElwood> no worries. I'll build in a minute
[21:34:39 CDT(-0500)] <TonyUnicon> were you able to test it?
[21:34:45 CDT(-0500)] <TonyUnicon> pulling it down now and see if it works for me
[21:35:26 CDT(-0500)] <JasonElwood> testing it now. no client or service side errors yet
[21:40:16 CDT(-0500)] <TonyUnicon> ok
[21:40:26 CDT(-0500)] <TonyUnicon> looks liked it worked with my test student
[21:40:52 CDT(-0500)] <JasonElwood> nice
[21:40:59 CDT(-0500)] <JasonElwood> if you are comfortable, I can close it
[21:41:25 CDT(-0500)] <TonyUnicon> yeah I think it's pretty cut and dry
[21:41:30 CDT(-0500)] <JasonElwood> sweet
[21:43:17 CDT(-0500)] <JasonElwood> we're in good shape. Dan wanted to pound at the app again tomorrow to make sure nothing else popped up.
[21:44:15 CDT(-0500)] <TonyUnicon> fingers crossed
[21:44:30 CDT(-0500)] <TonyUnicon> hopefully we took all our knocks today
[21:44:34 CDT(-0500)] <TonyUnicon> enjoy your weekend
[21:44:45 CDT(-0500)] <JasonElwood> I'm calling it quits. I'll check in the morning to see if Dan came up with anything.
[21:45:00 CDT(-0500)] <TonyUnicon> alright
[21:45:01 CDT(-0500)] <JasonElwood> I will. you do the same. I'll try to find a place to get to email tomorrow afternoon
[21:45:10 CDT(-0500)] <TonyUnicon> sounds good
[21:45:16 CDT(-0500)] <JasonElwood> thanks man for all the work
[21:45:23 CDT(-0500)] <TonyUnicon> yeah likewise, thanks for the help
[21:45:29 CDT(-0500)] <JasonElwood> later
[21:45:33 CDT(-0500)] <TonyUnicon> later