Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[16:51:45 CDT(-0500)] <dmccallum54> classy. i know.

[17:14:31 CDT(-0500)] <JasonElwood> not to spend too much time chasing this down, but has there been anything checked-in today that could significantly decrease performance against my local SQL Server env. I'm seeing slow-downs on a few items but not everything. slow-downs to the point of timing out.

[17:16:33 CDT(-0500)] <dmccallum54> this adds a sort on external_course.formatted_course

[17:16:34 CDT(-0500)] <dmccallum54> https://github.com/Jasig/SSP/commit/205eceff05232c88f38b629267f8deaca496e32e

[17:16:50 CDT(-0500)] <dmccallum54> havent updated recently, but i doubt there's an index on that

[17:17:33 CDT(-0500)] <dmccallum54> and https://github.com/Jasig/SSP/commit/53375371f0f332141bf0f63c7b1f31aa04e63bcc changes the way plan-course bindings are loaded

[17:17:34 CDT(-0500)] <JasonElwood> that shouldn't slow down the initial caseload loading though right

[17:17:43 CDT(-0500)] <dmccallum54> initial caseload no

[17:18:41 CDT(-0500)] <dmccallum54> sure it's the caseload call that's slow? has been quite a bit of work on Main recently, which gets loaded by default for the 1st student in caseload...

[17:19:25 CDT(-0500)] <JasonElwood> very possible. the caseload doesn't load. it times out. so it could be Main attempting to load for the first student

[17:20:10 CDT(-0500)] <JasonElwood> there is a S load going on there now

[17:20:28 CDT(-0500)] <dmccallum54> um

[17:21:32 CDT(-0500)] <dmccallum54> if you're so inclined, could post a screencast.com demonstrating what you're seeing while you have chrome dev tools open, set to the network tab and XHR requests only

[18:42:27 CDT(-0500)] <JasonElwood> i did a little more testing on the caseload slowness. I'm working on the linux CI and everything loads as expected, except for the MAP box in the Main Dashboard. That shows the loading dialog until it times out. I know Jim is working on tying that area into the MAP data. But it shows that the amount of data we are adding on the Main tool can have very negative effects. Even though it should work, maybe we should consider not lo

[18:44:11 CDT(-0500)] <JasonElwood> I don't see the common use case that advisors will log into SSP to see the Main Tool for the first student in their list. Again, I know it should work fine.

[18:49:36 CDT(-0500)] <dmccallum54> js70 will probably have a more colorful take on it… but the Main tool, under our current approach, where we basically cache nothing either server- or client-side, is a performance dog

[18:50:11 CDT(-0500)] <dmccallum54> so yes… every extra bit of data we add to that thing is going to make it a bit slower and hog more server side resources

[18:51:17 CDT(-0500)] <JasonElwood> I'll tell Russ we are getting rid of it. Thanks.

[18:51:23 CDT(-0500)] <dmccallum54> hang on hang on

[18:51:31 CDT(-0500)] <dmccallum54> i just want to register the risk

[18:51:38 CDT(-0500)] <JasonElwood> don't worry. I'll say Jim decided

[18:51:55 CDT(-0500)] <dmccallum54> if js70 is actively working on that particular integration now might not be the right time to start digging in heels

[18:52:21 CDT(-0500)] <dmccallum54> but…. overall…. seems to me that screen is unpleasant for both end users and developers

[18:52:23 CDT(-0500)] <JasonElwood> I agree. getting punchy at this point. I do think we should consider not loading it upon login.

[18:52:34 CDT(-0500)] <dmccallum54> my very own person eyes just glaze over every time it comes up

[18:52:41 CDT(-0500)] <dmccallum54> too. much. information.

[18:52:57 CDT(-0500)] <JasonElwood> and the details tab has twice as much

[18:53:21 CDT(-0500)] <dmccallum54> like… everyone thinks they want a dashboard. they don't. they want a speedometer. and maybe a fuel gauge.

[18:53:39 CDT(-0500)] <JasonElwood> agreed

[18:54:07 CDT(-0500)] <js70> that is fixed if you get the latest

[18:54:24 CDT(-0500)] <js70> it is because your student doesn't have a mpa

[18:54:28 CDT(-0500)] <js70> map

[18:55:13 CDT(-0500)] <JasonElwood> cool, thanks. at this point, I'm waiting for the save and load MAP to work to continue testing.

[18:55:17 CDT(-0500)] <js70> Sorry about that. Fixed it about an hour later

[18:55:28 CDT(-0500)] <JasonElwood> but I'll work through the Main Tool as much as possible

[18:58:15 CDT(-0500)] <js70> just checked in the transcript sort stuff.

[18:58:37 CDT(-0500)] <js70> going home.

[18:58:46 CDT(-0500)] <JasonElwood> thanks Jim. peace out