Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Corrected links that should have been relative instead of absolute.

...

[14:00:30 CST(-0600)] <EricDalquist> except for the parts where they are gross to deal with the old code (tongue)

[14:15:05 CST(-0600)] <EricDalquist> so I'm not sure how much I can do on enforcing detached vs maximized

[14:15:37 CST(-0600)] <EricDalquist> since both umobile and mobile-browser go through the normal rendering pipeline

[14:15:51 CST(-0600)] <EricDalquist> but I think I have a better fix for the minimization issue

[14:20:18 CST(-0600)] <athena> yeah - and we're actually not sending any information that delineates between detached and minimized right now

[14:20:20 CST(-0600)] <athena> so that's really ok (smile)

[14:40:06 CST(-0600)] <EricDalquist> ok, I thinkI have this fixed

[14:40:11 CST(-0600)] <EricDalquist> though it will pollute the db a little bit

[14:40:17 CST(-0600)] <EricDalquist> I don't think there is much I can do about it right now

[14:40:18 CST(-0600)] <athena> poor db

[14:40:21 CST(-0600)] <athena> (sad)

[14:40:31 CST(-0600)] <EricDalquist> we have the whole 'persistent window state' thing now

[14:40:46 CST(-0600)] <EricDalquist> and so this code results in the window state of minimized getting stored for portlets in the mobile ui

[14:40:49 CST(-0600)] <EricDalquist> which isn't really right

[14:40:51 CST(-0600)] <EricDalquist> hrm

[14:40:59 CST(-0600)] <EricDalquist> I'll try one thing to fix that ...

[15:00:14 CST(-0600)] <EricDalquist> yay

[15:00:18 CST(-0600)] <EricDalquist> ok db polution fixed

[15:01:09 CST(-0600)] <athena> woo!

[15:01:21 CST(-0600)] <athena> is there other stuff that needs fixing?

[15:01:39 CST(-0600)] <EricDalquist> well, testing from you will be needed

[15:01:48 CST(-0600)] <EricDalquist> was there a jira issue for this?

[15:02:33 CST(-0600)] <EricDalquist> the downside is the fix will require a re-import of the stylesheet descriptor files

[15:03:00 CST(-0600)] <athena> that's no problem

[15:03:06 CST(-0600)] <athena> and no i'm not sure we created a JIRA

[15:03:07 CST(-0600)] <athena> i'll do that now

[15:03:38 CST(-0600)] <EricDalquist> https://issues.jasig.org/browse/UP-3327

[15:03:40 CST(-0600)] <EricDalquist> just did

[15:05:15 CST(-0600)] <athena> https://issues.jasig.org/browse/UP-3328

[15:05:15 CST(-0600)] <athena> oh

[15:05:16 CST(-0600)] <athena> lol

[15:05:18 CST(-0600)] <athena> oops (smile)

[15:05:26 CST(-0600)] <athena> i can delete mine (smile)

[15:05:40 CST(-0600)] <EricDalquist> lol

[15:06:21 CST(-0600)] <athena> all gone!

[15:06:24 CST(-0600)] <athena> poof

[15:06:54 CST(-0600)] <EricDalquist> so currently I have this stylesheet parameter named defaultWindowState

[15:06:57 CST(-0600)] <EricDalquist> but that isn't really right

[15:07:07 CST(-0600)] <EricDalquist> it is more "dashboardForcedWindowState"

[15:07:17 CST(-0600)] <EricDalquist> is that a better name?

[15:08:01 CST(-0600)] <athena> hmmm.

[15:08:05 CST(-0600)] <athena> yeah, i think that makes sense

[15:09:54 CST(-0600)] <EricDalquist> hrm, and maybe this makes more sense on the theme instead of the structure

[15:11:16 CST(-0600)] <athena> yeah, i think that makes sense

[15:11:20 CST(-0600)] <athena> give it more individual control

[15:44:53 CST(-0600)] <EricDalquist> uhg

[15:44:54 CST(-0600)] <EricDalquist> finally

[15:47:04 CST(-0600)] <athena> improvement? (smile)

[15:47:14 CST(-0600)] <EricDalquist> pushed to upstream

[15:47:16 CST(-0600)] <EricDalquist> and all fixed

[15:47:21 CST(-0600)] <EricDalquist> much better than the old approach

[15:47:23 CST(-0600)] <EricDalquist> still not the best

[15:47:27 CST(-0600)] <EricDalquist> but hopefully it fixes your problem

[15:49:43 CST(-0600)] <athena> thank! i really do appreciate all the help

[15:49:46 CST(-0600)] <athena> i'll try it out

[15:49:56 CST(-0600)] <EricDalquist> no problem

[15:50:01 CST(-0600)] <EricDalquist> needed to get fixed

[15:50:10 CST(-0600)] <EricDalquist> and I didn't have a decent way to articulate the fix

[15:50:13 CST(-0600)] <EricDalquist> :/

[15:50:28 CST(-0600)] <athena> no worries - just appreciate you being so willing to help

[15:50:39 CST(-0600)] <athena> hoping we can get a umobile 1.1rc1 out soon

[15:50:42 CST(-0600)] <athena> lots of improvements

[15:50:48 CST(-0600)] <athena> performance for some stuff should be a lot better too

[15:50:49 CST(-0600)] <EricDalquist> yeah

[15:50:56 CST(-0600)] <EricDalquist> I'm looking to get 4.0.3 out soon too

[15:51:09 CST(-0600)] <EricDalquist> think you'd have time to review jira in the next day or so?

[15:56:37 CST(-0600)] <athena> yep

[15:56:43 CST(-0600)] <athena> once i get this demo environment set up

[15:56:57 CST(-0600)] <athena> glanced through it last night and it looks like there are a couple issues that should be pretty simple to fix

[15:57:04 CST(-0600)] <EricDalquist> cool

[15:57:14 CST(-0600)] <EricDalquist> there were a few that I thought might already be fixed as well

[15:57:30 CST(-0600)] <athena> i'll take a look

[15:57:47 CST(-0600)] <athena> have two demos tomorrow, hopefully should get a bit of a breather after that

[15:57:57 CST(-0600)] <EricDalquist> sounds good

[16:09:29 CST(-0600)] <athena> heh, oops, forgot to run initdb (smile)

[16:09:39 CST(-0600)] <EricDalquist> (smile)

[16:09:48 CST(-0600)] <EricDalquist> you should be fine just importing the stylsheet descriptors

[16:09:51 CST(-0600)] <EricDalquist> if you want to try that

[16:11:58 CST(-0600)] <athena> eh no worries

[16:12:03 CST(-0600)] <athena> i run initdb on this one all the time

[16:12:08 CST(-0600)] <athena> jsut spaced out

[16:23:06 CST(-0600)] <athena> hurray!

[16:23:12 CST(-0600)] <EricDalquist> fixed?

[16:23:32 CST(-0600)] <athena> yes!!

[16:23:34 CST(-0600)] <athena> and snappy

[16:23:54 CST(-0600)] <EricDalquist> yay