Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[18:25:08 CDT(-0500)] <dmccallum541> exactly

[18:26:12 CDT(-0500)] <dmccallum541> for what we actually need it should just be return dao.getStepById(uuid).getDetails();

[18:26:42 CDT(-0500)] <dmccallum541> but i'm sure there's more to it that i'm not thinking of

[18:28:36 CDT(-0500)] <TonyUnicon> its more then that because of object status considerations

[18:28:55 CDT(-0500)] <TonyUnicon> but that old logic did not respect the object status of the association

[18:29:06 CDT(-0500)] <TonyUnicon> only the detail being referenced

[18:29:37 CDT(-0500)] <TonyUnicon> i got a little lazy in that code thinking the data sets were rather small

[18:29:54 CDT(-0500)] <TonyUnicon> but ill replace it with some cleaner code

[18:30:05 CDT(-0500)] <TonyUnicon> how terribly dissapointed would you be if we did not respect the paging?

[18:30:40 CDT(-0500)] <dmccallum541> i can totally live without the paging

[18:30:49 CDT(-0500)] <TonyUnicon> ok

[18:31:08 CDT(-0500)] <dmccallum541> we have no use case where we actually need it. it only exists to prevent user abuse in this case

[18:31:19 CDT(-0500)] <TonyUnicon> i should have it fixed by monday's standup

[18:31:26 CDT(-0500)] <dmccallum541> well, and consistency w/ other APIs. but we've run roughshod over that in other places already

[18:32:57 CDT(-0500)] <TonyUnicon> the beers will go down easy tonight I htink

[18:33:05 CDT(-0500)] <dmccallum541> tell me about it

[18:39:47 CDT(-0500)] <dmccallum541> hmmm… i bet you're right that the SortingAndPaging support was part of the root motivation(s) for a lot of the way this was originally laid out…

[18:40:09 CDT(-0500)] <dmccallum541> and they can't eager load any multi-valued associations with their current implementation...

[18:40:34 CDT(-0500)] <dmccallum541> so navigating the object model for any of this was going to be a different sort of disaster...

[18:40:57 CDT(-0500)] <TonyUnicon> yep