Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[10:43:36 CST(-0600)] <js70> k

[14:02:01 CST(-0600)] <TonyUnicon> there are some uportal tests failing for me since i pulled down the latest property placeholder stuff

[14:02:05 CST(-0600)] <TonyUnicon> not sure whats wrong

[14:02:14 CST(-0600)] <TonyUnicon> im getting

[14:02:20 CST(-0600)] <TonyUnicon> These tests assume SSP_CONFIGDIR hasn't been set in the OS env.

[14:03:01 CST(-0600)] <dmccallum54> which tests specifically?

[14:04:15 CST(-0600)] <TonyUnicon> doesntRequireExternalConfigOverrideDirectory(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:16 CST(-0600)] <TonyUnicon> doesntRequireExternalConfigOverrideFile(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:16 CST(-0600)] <TonyUnicon> overridesDefaultsWithExternalConfig(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:16 CST(-0600)] <TonyUnicon> resolvesPlaceholdersRecursivelyAcrossFiles(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:16 CST(-0600)] <TonyUnicon> resolvesPrefixedPlaceholders(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:16 CST(-0600)] <TonyUnicon> resolvesSuffixedPlaceholders(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:16 CST(-0600)] <TonyUnicon> supportsArbitraryPropertyResolutionAfterProcessingBeanFactory(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:17 CST(-0600)] <TonyUnicon> canErrorOutOnArbitraryLookupOfUnresolvablePlaceholders(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:17 CST(-0600)] <TonyUnicon> canEchoOriginalValueOnArbitraryLookupOfUnresolvablePlaceholders(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:18 CST(-0600)] <TonyUnicon> canDeferToConfigurerBehaviorOnArbitraryLookupOfUnresolvablePlaceholders(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:18 CST(-0600)] <TonyUnicon> failsApplicationContextStartupWhenPlaceholdersDontResolve(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:19 CST(-0600)] <TonyUnicon> propertyManagerRespectsConfigOverrides(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:19 CST(-0600)] <TonyUnicon> propertyManagerInitializesSuccessfullyDespiteUnresolvedPlaceholders(org.jasig.portal.properties.QueryablePropertySourcesPlaceholderConfigurerTest)

[14:04:54 CST(-0600)] <dmccallum54> ah. i see

[14:05:07 CST(-0600)] <dmccallum54> you set that var in your shell profile?

[14:05:21 CST(-0600)] <TonyUnicon> yeah, are we not suppose to?

[14:06:44 CST(-0600)] <dmccallum54> i dont personally… i manage the config locations on a per-tomcat basis. but let me see if there's a way to fix these tests so they'll ignore what you've got set in your env

[14:06:51 CST(-0600)] <dmccallum54> the problem is that the env value "wins"

[14:06:56 CST(-0600)] <dmccallum54> thus invalidating the tests

[14:09:26 CST(-0600)] <TonyUnicon> im a bit confused

[14:09:30 CST(-0600)] <TonyUnicon> for something like initdb

[14:09:47 CST(-0600)] <TonyUnicon> wouldn't it have to be a path var?

[14:11:15 CST(-0600)] <dmccallum54> i always run with tests off for initdb (smile)

[14:23:40 CST(-0600)] <dmccallum54> i pushed a change that just removes the assertion.

[14:23:52 CST(-0600)] <dmccallum54> looks like the tests as written will be ok without it

[14:24:05 CST(-0600)] <dmccallum54> let me know if the tests still break in your env

[14:28:50 CST(-0600)] <TonyUnicon> yep all the tests pass

[14:28:51 CST(-0600)] <TonyUnicon> thanks

[14:30:11 CST(-0600)] <dmccallum54> sorry 'bout that

[14:30:39 CST(-0600)] <TonyUnicon> no worries