Page Comparison

...

[12:32:55 CDT(-0500)] <drewwills> jwennmacher is also setting up maven filters for log settings, so it's also the case that managing log level in a per-environment way, across all portlets, will become easier

[12:33:28 CDT(-0500)] <athena> agreed that we probably want to default to something production-ready

[12:33:39 CDT(-0500)] <drewwills> so perhaps we could set examples like filters/prod.properties = WARN, but filters/local.properties = DEBUG

[12:33:52 CDT(-0500)] <athena> yeah, that would be reasonable

[12:34:11 CDT(-0500)] <athena> and either way we should add inline documentation for that property

[12:34:14 CDT(-0500)] <drewwills> and probably we should update the wiki page accordingly

[12:34:21 CDT(-0500)] <athena> yes, that too

[12:34:25 CDT(-0500)] <drewwills> that too

[12:42:29 CDT(-0500)] <jwennmacher> That's a good suggestion. I was thinking the properties to put in local.properties are

[12:42:29 CDT(-0500)] <jwennmacher> portal.logging.rootLevel=WARN

[12:42:29 CDT(-0500)] <jwennmacher> # Directory to place portal and portlet log files into.

[12:42:29 CDT(-0500)]

 <jwennmacher> portal.logging.logfileDirectory=${catalina.base}/logs

[12:42:29 CDT(-0500)] <jwennmacher> # Assume a DailyRollingFileAppender is used. Set the pattern to daily log-file roll-overs.

[12:42:29 CDT(-0500)] <jwennmacher> # Can also set to hourly, weekly, etc.

[12:42:30 CDT(-0500)] <jwennmacher> # See http://logging.apache.org/log4j/1.2/apidocs/index.html

[12:42:30 CDT(-0500)] <jwennmacher> portal.logging.rollingLogFileDatePattern='.'yyyy-MM-dd

[12:42:31 CDT(-0500)] <jwennmacher> # Pattern to specify format of each log file entry. See http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/DailyRollingFileAppender.html

[12:42:31 CDT(-0500)]

 <jwennmacher> portal.logging.layoutConversionPattern=%5p \[%t\] %c{2}.\[%x\] %d{ISO8601} - %m%n

[12:42:32 CDT(-0500)] <jwennmacher> Any thoughts on other properties to consider (or elimination of some I have)? Log files seem to use the DailyRollingFileAppender. I don't see a reason to make the appender class file configurable; too many supplemental properties.

[12:43:37 CDT(-0500)] <athena> those seem reasonable to me

[12:43:38 CDT(-0500)] <jwennmacher> That didn't look good. I learned IRC doesn't handle messages with line terminators in them as a single message

[12:44:08 CDT(-0500)] <athena> we frequently use paste tools like pastebin or github, especially for long stack traces

[12:44:19 CDT(-0500)] <athena> but it came through ok

[12:44:23 CDT(-0500)] <Daskreech> Github has a pastebin?

[12:44:34 CDT(-0500)] <athena> well, gists

[12:44:38 CDT(-0500)] <athena> https://gist.github.com/

[12:45:34 CDT(-0500)] <athena> jwennmacher: i think what you have is a great start and you should go ahead and submit a pull request when you're ready

[12:45:44 CDT(-0500)] <athena> it's a good start, and we can always tweak it or add more later

[12:56:14 CDT(-0500)] <Daskreech> And they are git repos. That's interesting

[12:56:46 CDT(-0500)] <athena> yeah

[12:56:51 CDT(-0500)] <athena> interesting way to share code