...
[16:45:17 CDT(-0500)] <dmccallum54> do we need a technical debt ticket to figure a cleaner solution?
[16:46:00 CDT(-0500)] <pspaude> The comment is larger than the code.
[16:46:06 CDT(-0500)] <dmccallum54> hah
[16:46:28 CDT(-0500)] <dmccallum54> still… seem like there should be a less heuristic way of figuring out what state we're in
[16:46:36 CDT(-0500)] <dmccallum54> definitely not saying we need to fix it now
[16:47:07 CDT(-0500)] <dmccallum54> but a ticket to remind us to check on it again when we're feeling like we have some tech debt payback cycles sounds like a good idea
[16:47:23 CDT(-0500)] <pspaude> No I agree if anyone has a better way.
[16:47:58 CDT(-0500)] <pspaude> The problem is the panel is nested and you can't get at the is expanded value. Normally that doesn't matter but for that one button mentioned it does.
[16:48:27 CDT(-0500)] <dmccallum54> if ext doesn't give us what we need i'm thinking we'd track state ourselves by trapping events that collapse/uncollapse
[16:49:15 CDT(-0500)] <pspaude> Right we could do that, we just have to add in more code.
[16:49:40 CDT(-0500)] <dmccallum54> aint nothing cant be fixed by stabbing ourselves in the eye with more javascript
[16:49:41 CDT(-0500)] <dmccallum54> anyway
[16:49:45 CDT(-0500)] <dmccallum54> if what you've got works
[16:50:04 CDT(-0500)] <dmccallum54> just like to create a ticket to record the fact that there might be some fragile assumptions there
[16:50:37 CDT(-0500)] <pspaude> Exactly, that is why I had concerns with adding in all that overhead. This way works and "should" be fast and like I said is only called on the button press to go back to the caseload from search. That is it.
[16:50:58 CDT(-0500)] <pspaude> Yeah no problem I agree.
[16:52:44 CDT(-0500)] <dmccallum54> 'git add -p' is the coolest thing ever, btw
[16:54:50 CDT(-0500)] <pspaude> That looks cool, better than diff'ing the file before you commit
[16:55:22 CDT(-0500)] <dmccallum54> has been specifically helpful b/c of that damned uPortal JDBC driver dep issue
[16:55:37 CDT(-0500)] <dmccallum54> where i never actually want to check in that portion of a pom.xml diff