Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[16:44:05 CDT(-0500)] <EricDalquist> since you'll need DB lookups to figure if there are missing terms/quarters

[16:44:14 CDT(-0500)] <EricDalquist> and a singleton won't work

[16:44:20 CDT(-0500)] <EricDalquist> since the date/time fields need to be correct

[16:44:21 CDT(-0500)] <EricDalquist> damnit

[16:45:04 CDT(-0500)] <EricDalquist> public <T extends BaseAggregation> List<T> fillInBlanks(List<T> data, Function<DateTime, T> missingDataCreator);

[16:45:05 CDT(-0500)] <EricDalquist> there

[16:45:12 CDT(-0500)] <EricDalquist> where Function is a com.google.common.base.Function

[16:45:23 CDT(-0500)] <athena> ok

[16:45:31 CDT(-0500)] <EricDalquist> then that can call missingDataCreator.apply(missingDateTime)

[16:45:48 CDT(-0500)] <athena> so basically we're adding a utility method to the interval helper that will help fill in missing holes and return a new list of aggregations

[16:45:53 CDT(-0500)] <EricDalquist> yes

[16:46:10 CDT(-0500)] <athena> and we'll need logic specific to each aggregation type

[16:46:15 CDT(-0500)] <EricDalquist> just because the "find the hole" logic isn't straight forward for all intervals

[16:46:20 CDT(-0500)] <athena> so that it can create aggregation-specific empty objects

[16:47:00 CDT(-0500)] <EricDalquist> yeah, which is what that Function should be doing

[16:47:02 CDT(-0500)] <EricDalquist> grr

[16:47:03 CDT(-0500)] <EricDalquist> ok

[16:47:03 CDT(-0500)] <EricDalquist> public <T extends BaseAggregation> List<T> fillInBlanks(List<T> data, Function<Tuple<DateDimension, TimeDimension>, T> missingDataCreator);

[16:47:06 CDT(-0500)] <EricDalquist> there

[16:47:17 CDT(-0500)] <EricDalquist> the fillInTheBlank function will have to figure out the date and time dimensions

[16:47:19 CDT(-0500)] <EricDalquist> and provide those

[16:47:29 CDT(-0500)] <EricDalquist> just a DateTime wouldn't be enough info for the function

[16:47:31 CDT(-0500)] <EricDalquist> blah

[16:47:59 CDT(-0500)] <athena> yeah

[16:48:01 CDT(-0500)] <EricDalquist> so you'd get the aggregation from the dao

[16:48:01 CDT(-0500)] <athena> not trivial

[16:48:07 CDT(-0500)] <EricDalquist> run the list through fillInBlanks

[16:48:10 CDT(-0500)] <athena> but if we can at least keep this out of the controller that'll help

[16:48:14 CDT(-0500)] <EricDalquist> yes

[16:48:22 CDT(-0500)] <EricDalquist> keeping it in one method will be good

[16:48:30 CDT(-0500)] <athena> i finally got something reasonable working displaying the graphs

[16:48:35 CDT(-0500)] <EricDalquist> then use that list to build the DataTable

[16:48:38 CDT(-0500)] <EricDalquist> yay!

[16:48:46 CDT(-0500)] <athena> managed to use google's logic to serialize the DataTable to a JSON fragment without it taking over the whole response

[16:48:47 CDT(-0500)] <athena> yeah

[16:48:52 CDT(-0500)] <EricDalquist> "sometime soon" I'll be working on more aggregators

[16:48:56 CDT(-0500)] <EricDalquist> oh nice

[16:48:56 CDT(-0500)] <athena> so we shoudl be able to include multiple tables in a response now, etc.

[16:49:08 CDT(-0500)] <athena> once i get all this working i'll check it in and then we can have a real example to work from

[16:49:11 CDT(-0500)] <EricDalquist> yay for reverse engineering (smile)

[16:49:12 CDT(-0500)] <athena> just keep finding little things

[16:49:13 CDT(-0500)] <EricDalquist> wonderful

[16:49:13 CDT(-0500)] <athena> lol

[16:49:13 CDT(-0500)] <athena> yeah

[16:49:17 CDT(-0500)] <EricDalquist> yeah

[16:49:20 CDT(-0500)] <athena> yay for being able to look at source code online

[16:49:22 CDT(-0500)] <EricDalquist> I think we found an aggregator bug

[16:49:28 CDT(-0500)] <EricDalquist> so have to fix that soon

[16:49:33 CDT(-0500)] <EricDalquist> but time for me to head home

[16:49:37 CDT(-0500)] <EricDalquist> have a good evening (smile)

[16:50:06 CDT(-0500)] <athena> you too!