...
[12:19:32 CDT(-0500)] <athena> and i'll write some tests for this at least
[12:23:49 CDT(-0500)] <athena> and actually you did write tests it turns out - that class just didn't get renamed
[12:24:28 CDT(-0500)] <EricDalquist> oh
[12:24:29 CDT(-0500)] <EricDalquist> hah
[12:24:46 CDT(-0500)] <EricDalquist> that's good
[12:24:52 CDT(-0500)] <EricDalquist> I was feeling really bad for not writing a test for that class
[12:26:17 CDT(-0500)] <athena>
[12:26:20 CDT(-0500)] <athena> i'll add tests for this
[12:26:22 CDT(-0500)] <athena> and can rename it
[12:26:27 CDT(-0500)] <EricDalquist> sounds good
[13:02:20 CDT(-0500)] <EricDalquist> !@#$!@ timezones
[13:02:30 CDT(-0500)] <EricDalquist> another unit test failing on bamboo because I forgot to setup the TZ
[13:29:06 CDT(-0500)] <athena> eeoops
[13:29:15 CDT(-0500)] <athena> writing unit tests for this turns out to be a pian
[13:29:38 CDT(-0500)] <athena> need something for date dimensions, time dimensions, etc.
[13:30:18 CDT(-0500)] <EricDalquist> ah right
[13:30:25 CDT(-0500)] <EricDalquist> you'd need to mock out the dimension daos
[13:30:27 CDT(-0500)] <athena> yeah
[13:30:42 CDT(-0500)] <athena> going to back up and create something
[13:30:47 CDT(-0500)] <athena> maybe a snack first though
[13:39:50 CDT(-0500)] <EricDalquist> I hate TZs: https://gist.github.com/2361273
[14:50:55 CDT(-0500)] <athena> they are evil
[15:37:32 CDT(-0500)] <EricDalquist> my brain is frying from copying commits
[15:56:38 CDT(-0500)] <athena> uhoh
[15:56:41 CDT(-0500)] <athena> brain fry bad
[15:56:57 CDT(-0500)] <EricDalquist> I didn't quite realize how many I had to copy over
[15:57:01 CDT(-0500)] <EricDalquist> I thought I was making progress
[15:57:02 CDT(-0500)] <EricDalquist> I'
[15:57:11 CDT(-0500)] <EricDalquist> I'm only at 3/28 in UW's commit history
[15:59:44 CDT(-0500)] <EricDalquist> I didn't really propose it anywhere
[15:59:52 CDT(-0500)] <EricDalquist> but any objections to that tabbed search ui I showd today?
[16:00:10 CDT(-0500)] <EricDalquist> the idea is that you can configure the which result types show up on which tabs
[16:00:26 CDT(-0500)] <EricDalquist> so it is easier to add new searchers via uPortal or other portlets
[16:00:35 CDT(-0500)] <EricDalquist> and just have results show up in the right section
[16:22:05 CDT(-0500)] <athena> sounds great to me
[16:51:31 CDT(-0500)] <EricDalquist> ok ... hopefully I can get this merging done tonight ...
[16:51:42 CDT(-0500)] <EricDalquist> up to our 4.0.4.14 release ...
[16:51:53 CDT(-0500)] <EricDalquist> and we're up to 4.0.4.25
[16:52:06 CDT(-0500)] <EricDalquist> only 20 or so more fixes to get merged into uPortal master