Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[16:08:50 CDT(-0500)] <chris_cousquer> humm...

[16:10:08 CDT(-0500)] <chris_cousquer> didn't see that there is a difference of title structure between desktop/mobile

[16:11:22 CDT(-0500)] <chris_cousquer> that could have some pb with accessibity

[16:13:22 CDT(-0500)] <chris_cousquer> if you do a cms portlet for mobile&desktop view with a main title for the portlet content its h3

[16:14:19 CDT(-0500)] <chris_cousquer> so in desktop view you have a correct sequence of title: h1>h2>h3

[16:14:38 CDT(-0500)] <chris_cousquer> but on mobile you have

[16:14:45 CDT(-0500)] <chris_cousquer> h1>h3

[16:20:38 CDT(-0500)] <EricDalquist> ok stats reporting is in 4.0-patches now

[16:41:56 CDT(-0500)] <chris_cousquer> @EricDalquist I think git cherry have a strange behavior on date in Github...

[16:42:12 CDT(-0500)] <EricDalquist> not cherry-pick

[16:42:21 CDT(-0500)] <EricDalquist> that does do "fun" stuff with dates

[16:42:29 CDT(-0500)] <EricDalquist> since the date of the cherry-picked commit doesn't change

[16:42:38 CDT(-0500)] <EricDalquist> git cherry shows things that might need to be merged

[16:42:54 CDT(-0500)] <EricDalquist> like when on the master branch

[16:42:57 CDT(-0500)] <EricDalquist> I run:

[16:42:58 CDT(-0500)] <EricDalquist> git cherry -v rel-4-0-patches HEAD uportal-4.0.6.SR1

[16:43:20 CDT(-0500)] <EricDalquist> that shows me all the commits on master since 4.0.6 with markers for what needs to be merged and what has been merged

[16:43:34 CDT(-0500)] <chris_cousquer> yes but look at https://github.com/Jasig/uPortal/commits/master

[16:43:59 CDT(-0500)] <EricDalquist> right

[16:44:05 CDT(-0500)] <EricDalquist> commit date != commit order in git

[16:44:08 CDT(-0500)] <EricDalquist> this isn't svn (smile)

[16:44:20 CDT(-0500)] <chris_cousquer> yes

[16:44:31 CDT(-0500)] <EricDalquist> I made those changes in UW's branch of uPortal

[16:44:38 CDT(-0500)] <EricDalquist> and realized I needed to merge them over

[16:45:25 CDT(-0500)] <chris_cousquer> was looking at your latest change and authored a month ago...

[16:45:34 CDT(-0500)] <chris_cousquer> (smile)

[16:45:59 CDT(-0500)] <chris_cousquer> sorry

[16:46:27 CDT(-0500)] <chris_cousquer> but I'm french (wink)

[16:46:42 CDT(-0500)] <EricDalquist> lol