Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[11:14:15 CST(-0600)] <EricDalquist> yeah it would have to be for 4.1 then

[11:18:09 CST(-0600)] <mmoayyed> coolio.

[11:18:30 CST(-0600)] <EricDalquist> though really moving to JDK7 and TC7 for 4.1 is probably a reasonable step

[11:20:31 CST(-0600)] <mmoayyed> great. so, in my pull, I

[11:20:40 CST(-0600)] <mmoayyed> I will also force the build to be on JDK7

[11:21:13 CST(-0600)] <EricDalquist> do two different pulls

[11:21:22 CST(-0600)] <EricDalquist> those are two different and really unrelated changes

[11:21:29 CST(-0600)] <EricDalquist> other than they are both "7" (smile)

[11:21:55 CST(-0600)] <mmoayyed> (big grin) no problem.

[11:22:04 CST(-0600)] <athena> at what point are we going to pull this into uportal?

[11:22:19 CST(-0600)] <EricDalquist> what do you mean athena?

[11:22:26 CST(-0600)] <athena> the jdk7 change in particular

[11:22:37 CST(-0600)] <EricDalquist> not sure ...

[11:22:37 CST(-0600)] <athena> just wondering at what point we're going to integrate that into the trunk

[11:22:45 CST(-0600)] <EricDalquist> do you have any concerns about it?

[11:22:56 CST(-0600)] <athena> just the normal mac jdk-switching stupidness

[11:23:00 CST(-0600)] <EricDalquist> ah

[11:23:07 CST(-0600)] <athena> imagine it'll make it harder to work on both 4.1 and 4.0.x alternately

[11:23:12 CST(-0600)] <EricDalquist> yeah ...

[11:23:20 CST(-0600)] <athena> completely stupid that that's even an issue

[11:23:29 CST(-0600)] <EricDalquist> well it depends on if 4.0 compiles on jdk7

[11:23:32 CST(-0600)] <EricDalquist> I think it might

[11:23:58 CST(-0600)] <EricDalquist> maven will still have the compiler generate 1.6 compatible class files for 4.0

[11:24:07 CST(-0600)] <athena> ah, gotcha

[11:24:11 CST(-0600)] <athena> so that might help indeed

[12:08:52 CST(-0600)] <EricDalquist> athena: you have any input on https://github.com/Jasig/uPortal/pull/81?

[12:17:33 CST(-0600)] <athena> looks decent to me - and misagh knows cas better than i do

[12:17:46 CST(-0600)] <athena> only comment i have is that clearpass is currently disabled by default in uportal

[12:17:54 CST(-0600)] <athena> this looks like maybe it's enabled by default, though not 100% sure

[12:19:57 CST(-0600)] <EricDalquist> yeah the pull says it is enabled by default

[12:20:14 CST(-0600)] <EricDalquist> I'm thinking we don't want that on by default?

[12:20:34 CST(-0600)] <athena> probably not

[12:20:42 CST(-0600)] <athena> but we want it easy to enable, since it's a common use case